Remove unused authorized_find method
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29921#note_184713939
This commit is contained in:
parent
b2a615c3c6
commit
bbdcbd98ae
3 changed files with 1 additions and 25 deletions
|
@ -447,7 +447,7 @@ want to validate the abilities for.
|
|||
|
||||
Alternatively, we can add a `find_object` method that will load the
|
||||
object on the mutation. This would allow you to use the
|
||||
`authorized_find!` and `authorized_find!` helper methods.
|
||||
`authorized_find!` helper method.
|
||||
|
||||
When a user is not allowed to perform the action, or an object is not
|
||||
found, we should raise a
|
||||
|
|
|
@ -27,12 +27,6 @@ module Gitlab
|
|||
raise NotImplementedError, "Implement #find_object in #{self.class.name}"
|
||||
end
|
||||
|
||||
def authorized_find(*args)
|
||||
object = find_object(*args)
|
||||
|
||||
object if authorized?(object)
|
||||
end
|
||||
|
||||
def authorized_find!(*args)
|
||||
object = find_object(*args)
|
||||
authorize!(object)
|
||||
|
|
|
@ -34,12 +34,6 @@ describe Gitlab::Graphql::Authorize::AuthorizeResource do
|
|||
end
|
||||
end
|
||||
|
||||
describe '#authorized_find' do
|
||||
it 'returns the object' do
|
||||
expect(loading_resource.authorized_find).to eq(project)
|
||||
end
|
||||
end
|
||||
|
||||
describe '#authorized_find!' do
|
||||
it 'returns the object' do
|
||||
expect(loading_resource.authorized_find!).to eq(project)
|
||||
|
@ -66,12 +60,6 @@ describe Gitlab::Graphql::Authorize::AuthorizeResource do
|
|||
end
|
||||
end
|
||||
|
||||
describe '#authorized_find' do
|
||||
it 'returns `nil`' do
|
||||
expect(loading_resource.authorized_find).to be_nil
|
||||
end
|
||||
end
|
||||
|
||||
describe '#authorized_find!' do
|
||||
it 'raises an error' do
|
||||
expect { loading_resource.authorize!(project) }.to raise_error(Gitlab::Graphql::Errors::ResourceNotAvailable)
|
||||
|
@ -127,12 +115,6 @@ describe Gitlab::Graphql::Authorize::AuthorizeResource do
|
|||
end
|
||||
let(:error) { /#{fake_class.name} has no authorizations/ }
|
||||
|
||||
describe '#authorized_find' do
|
||||
it 'raises a comprehensive error message' do
|
||||
expect { loading_resource.authorized_find }.to raise_error(error)
|
||||
end
|
||||
end
|
||||
|
||||
describe '#authorized_find!' do
|
||||
it 'raises a comprehensive error message' do
|
||||
expect { loading_resource.authorized_find! }.to raise_error(error)
|
||||
|
|
Loading…
Reference in a new issue