Merge branch '18942-dropdowns-should-apply-any-present-filter-once-data-is-loaded' into 'master'
Fixed dropdown not filtering queries entered before data is loaded ## What does this MR do? Triggers a 'keyup' event on a filters input to force it to process any text that was added before the data was retrieved and rendered. ## Are there points in the code the reviewer needs to double check? 😕 ## Why was this MR needed? UX ## What are the relevant issue numbers? Closes #18942. ## Screenshots (if relevant) ## Does this MR meet the acceptance criteria? - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md) - [ ] API support added - Tests - [ ] Added for this feature/bug - [ ] All builds are passing - [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides) - [x] Branch has no merge conflicts with `master` (if you do - rebase it please) - [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits) See merge request !4846
This commit is contained in:
commit
bcebdee751
|
@ -186,6 +186,8 @@ class GitLabDropdown
|
||||||
@fullData = data
|
@fullData = data
|
||||||
|
|
||||||
@parseData @fullData
|
@parseData @fullData
|
||||||
|
|
||||||
|
@filter.input.trigger('keyup') if @options.filterable and @filter and @filter.input
|
||||||
}
|
}
|
||||||
|
|
||||||
# Init filterable
|
# Init filterable
|
||||||
|
|
Loading…
Reference in New Issue