From bcfd9386f54f12bf5b294686afbc6bcdad8a39c5 Mon Sep 17 00:00:00 2001 From: Jacob Vosmaer Date: Mon, 7 Apr 2014 11:17:55 +0200 Subject: [PATCH] Fix popen bug in `rake gitlab:satellites:create` The Satellite#create method no longer sets the `$?` global variable. Instead, we can use the method return value to test if the satellite was created successfully --- CHANGELOG | 1 + lib/tasks/gitlab/enable_automerge.rake | 7 ++----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index 59e3e22524b..d0613c301ea 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -8,6 +8,7 @@ v 6.8.0 - Create branches via API (sponsored by O'Reilly Media) - Changed permission of gitlab-satellites directory not to be world accessible - Protected branch does not allow force push + - Fix popen bug in `rake gitlab:satellites:create` v 6.7.3 - Fix the merge notification email not being sent (Pierre de La Morinerie) diff --git a/lib/tasks/gitlab/enable_automerge.rake b/lib/tasks/gitlab/enable_automerge.rake index 6822e5cf1ad..aa9869daf2f 100644 --- a/lib/tasks/gitlab/enable_automerge.rake +++ b/lib/tasks/gitlab/enable_automerge.rake @@ -27,11 +27,8 @@ namespace :gitlab do if project.satellite.exists? puts "exists already".green else - puts "" - project.satellite.create - - print "... " - if $?.success? + print "\n... " + if project.satellite.create puts "created".green else puts "error".red