kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Improve MetricGroup specs

This commit is contained in:
Kamil Trzciński 2018-09-05 17:02:23 +02:00
parent a3fbaffc0c
commit bdb06db0f6
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
spec/lib/gitlab/prometheus/metric_group_spec.rb
View File

@ -12,7 +12,8 @@ describe Gitlab::Prometheus::MetricGroup do
subject { described_class.common_metrics } subject { described_class.common_metrics }
it 'returns exactly two groups' do it 'returns exactly two groups' do
expect(subject.map(&:name)).to contain_exactly('Response metrics (AWS ELB)', 'System metrics (Kubernetes)') expect(subject.map(&:name)).to contain_exactly(
'Response metrics (AWS ELB)', 'System metrics (Kubernetes)')
end end
it 'returns exactly three metric queries' do it 'returns exactly three metric queries' do
@ -27,10 +28,14 @@ describe Gitlab::Prometheus::MetricGroup do
let!(:project_metric) { create(:prometheus_metric) } let!(:project_metric) { create(:prometheus_metric) }
let!(:common_metric) { create(:prometheus_metric, :common, group: :aws_elb) } let!(:common_metric) { create(:prometheus_metric, :common, group: :aws_elb) }
subject { described_class.for_project(other_project) } subject do
described_class.for_project(other_project)
.map(&:metrics).flatten
.map(&:id)
end
it 'returns exactly one common metric' do it 'returns exactly one common metric' do
expect(subject.map(&:metrics).flatten.map(&:id)).to contain_exactly(common_metric.id) is_expected.to contain_exactly(common_metric.id)
end end
end end
end end