Untangle status label and text in ci status helper
This commit is contained in:
parent
c8b2aa8de5
commit
bdc13c3142
2 changed files with 21 additions and 2 deletions
|
@ -5,8 +5,8 @@ module CiStatusHelper
|
|||
end
|
||||
|
||||
def ci_status_with_icon(status, target = nil)
|
||||
content = ci_icon_for_status(status) + ci_label_for_status(status)
|
||||
klass = "ci-status ci-#{status}" # TODO, add support for detailed status
|
||||
content = ci_icon_for_status(status) + ci_text_for_status(status)
|
||||
klass = "ci-status ci-#{status}"
|
||||
|
||||
if target
|
||||
link_to content, target, class: klass
|
||||
|
@ -15,6 +15,14 @@ module CiStatusHelper
|
|||
end
|
||||
end
|
||||
|
||||
def ci_text_for_status(status)
|
||||
if detailed_status?(status)
|
||||
status.text
|
||||
else
|
||||
status
|
||||
end
|
||||
end
|
||||
|
||||
def ci_label_for_status(status)
|
||||
if detailed_status?(status)
|
||||
return status.label
|
||||
|
|
|
@ -22,6 +22,17 @@ module Gitlab
|
|||
"#{@subject.class.name.demodulize}: #{label}"
|
||||
end
|
||||
|
||||
# Deprecation warning: this method is here because we need to maintain
|
||||
# backwards compatibility with legacy statuses. We often do something
|
||||
# like "ci-status ci-status-#{status}" to set CSS class.
|
||||
#
|
||||
# `to_s` method should be renamed to `group` at some point, after
|
||||
# phasing legacy satuses out.
|
||||
#
|
||||
def to_s
|
||||
self.class.name.demodulize.downcase
|
||||
end
|
||||
|
||||
def has_details?
|
||||
raise NotImplementedError
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue