From be3e24ea3c9f497efde85900df298ce9bc42fce8 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 22 Jan 2020 12:08:40 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/global.gitlab-ci.yml | 1 + .gitlab/ci/qa.gitlab-ci.yml | 1 + .rubocop.yml | 1 + .../components/discussion_filter_note.vue | 6 +- .../notes/components/note_attachment.vue | 16 +- .../notes/components/note_header.vue | 7 +- .../list/components/release_block.vue | 12 +- app/graphql/types/blob_viewers/type_enum.rb | 14 + app/graphql/types/snippet_type.rb | 8 +- app/graphql/types/snippets/blob_type.rb | 46 +++ .../types/snippets/blob_viewer_type.rb | 41 +++ app/models/epic.rb | 2 - app/presenters/blob_presenter.rb | 6 +- app/presenters/snippet_blob_presenter.rb | 31 ++ app/services/submit_usage_ping_service.rb | 6 +- app/workers/all_queues.yml | 137 ++++---- ...fj-add-graphql-blob-viewer-to-snippets.yml | 5 + ...e-storage-version-column-from-snippets.yml | 5 + .../remove_milestone_id_from_epics3.yml | 5 + .../sh-fix-mermaid-releases-page.yml | 5 + config/gitlab.yml.example | 2 +- ...ve_storage_version_column_from_snippets.rb | 30 ++ db/schema.rb | 1 - .../operations/extra_sidekiq_processes.md | 5 +- .../graphql/reference/gitlab_schema.graphql | 98 +++++- doc/api/graphql/reference/gitlab_schema.json | 313 +++++++++++++++++- doc/api/graphql/reference/index.md | 31 +- doc/development/fe_guide/graphql.md | 2 +- doc/development/sidekiq_style_guide.md | 7 +- doc/user/application_security/sast/index.md | 3 +- lib/gitlab/import_export/import_export.yml | 1 - lib/gitlab/sidekiq_config.rb | 56 +++- lib/gitlab/sidekiq_config/worker.rb | 51 +++ lib/tasks/gitlab/sidekiq.rake | 48 +++ lib/tasks/lint.rake | 1 + package.json | 2 +- .../project_error_tracking_settings.rb | 2 +- .../user_sees_error_details_spec.rb | 32 ++ .../user_sees_error_index_spec.rb | 69 ++++ .../sentry/issue_sample_response.json | 282 ++++------------ .../grafana_integration_spec.js.snap | 3 + .../date_time_picker/date_time_picker_spec.js | 2 +- .../components/discussion_filter_note_spec.js | 89 +---- .../notes/components/note_attachment_spec.js | 56 +++- .../notes/components/note_header_spec.js | 206 ++++++------ .../delete_user_modal_spec.js.snap | 3 + .../project_empty_state_spec.js.snap | 6 +- .../__snapshots__/settings_form_spec.js.snap | 3 + .../list/components/release_block_spec.js | 7 + .../__snapshots__/self_monitor_spec.js.snap | 2 + .../__snapshots__/expand_button_spec.js.snap | 88 ++++- .../components/expand_button_spec.js | 4 +- .../types/blob_viewers/type_enum_spec.rb | 11 + spec/graphql/types/snippet_type_spec.rb | 4 +- spec/graphql/types/snippets/blob_type_spec.rb | 13 + .../types/snippets/blob_viewer_type_spec.rb | 12 + spec/lib/gitlab/sidekiq_config/worker_spec.rb | 84 +++++ spec/lib/gitlab/sidekiq_config_spec.rb | 42 ++- spec/lib/sentry/client/issue_spec.rb | 4 +- .../presenters/snippet_blob_presenter_spec.rb | 60 ++++ .../graphql/mutations/snippets/create_spec.rb | 4 +- .../graphql/mutations/snippets/update_spec.rb | 4 +- .../submit_usage_ping_service_spec.rb | 130 ++++---- spec/support/matchers/log_spam.rb | 2 +- .../features/error_tracking_shared_context.rb | 23 ++ .../features/error_tracking_shared_example.rb | 86 +++++ spec/workers/every_sidekiq_worker_spec.rb | 14 +- yarn.lock | 119 +++++-- 68 files changed, 1821 insertions(+), 651 deletions(-) create mode 100644 app/graphql/types/blob_viewers/type_enum.rb create mode 100644 app/graphql/types/snippets/blob_type.rb create mode 100644 app/graphql/types/snippets/blob_viewer_type.rb create mode 100644 app/presenters/snippet_blob_presenter.rb create mode 100644 changelogs/unreleased/fj-add-graphql-blob-viewer-to-snippets.yml create mode 100644 changelogs/unreleased/fj-remove-storage-version-column-from-snippets.yml create mode 100644 changelogs/unreleased/remove_milestone_id_from_epics3.yml create mode 100644 changelogs/unreleased/sh-fix-mermaid-releases-page.yml create mode 100644 db/post_migrate/20200120083607_remove_storage_version_column_from_snippets.rb create mode 100644 lib/gitlab/sidekiq_config/worker.rb create mode 100644 lib/tasks/gitlab/sidekiq.rake create mode 100644 spec/features/error_tracking/user_sees_error_details_spec.rb create mode 100644 spec/features/error_tracking/user_sees_error_index_spec.rb create mode 100644 spec/graphql/types/blob_viewers/type_enum_spec.rb create mode 100644 spec/graphql/types/snippets/blob_type_spec.rb create mode 100644 spec/graphql/types/snippets/blob_viewer_type_spec.rb create mode 100644 spec/lib/gitlab/sidekiq_config/worker_spec.rb create mode 100644 spec/presenters/snippet_blob_presenter_spec.rb create mode 100644 spec/support/shared_contexts/features/error_tracking_shared_context.rb create mode 100644 spec/support/shared_examples/features/error_tracking_shared_example.rb diff --git a/.gitlab/ci/global.gitlab-ci.yml b/.gitlab/ci/global.gitlab-ci.yml index 4c407045411..121ce76d1dd 100644 --- a/.gitlab/ci/global.gitlab-ci.yml +++ b/.gitlab/ci/global.gitlab-ci.yml @@ -13,6 +13,7 @@ .default-before_script: before_script: - date + - '[ "$FOSS_ONLY" = "1" ] && rm -rf ee/' - export GOPATH=$CI_PROJECT_DIR/.go - mkdir -p $GOPATH - source scripts/utils.sh diff --git a/.gitlab/ci/qa.gitlab-ci.yml b/.gitlab/ci/qa.gitlab-ci.yml index 5a58c3f9416..effc950f3c8 100644 --- a/.gitlab/ci/qa.gitlab-ci.yml +++ b/.gitlab/ci/qa.gitlab-ci.yml @@ -40,6 +40,7 @@ paths: - vendor/ruby before_script: + - '[ "$FOSS_ONLY" = "1" ] && rm -rf ee/' - cd qa/ - bundle install --clean --jobs=$(nproc) --path=vendor --retry=3 --quiet - bundle check diff --git a/.rubocop.yml b/.rubocop.yml index b374012cac5..b6a5c686f84 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -347,6 +347,7 @@ RSpec/HaveGitlabHttpStatus: Enabled: true Include: - 'spec/support/shared_examples/**/*' + - 'ee/spec/support/shared_examples/**/*' Style/MultilineWhenThen: Enabled: false diff --git a/app/assets/javascripts/notes/components/discussion_filter_note.vue b/app/assets/javascripts/notes/components/discussion_filter_note.vue index 889731df180..8dc4b43d69a 100644 --- a/app/assets/javascripts/notes/components/discussion_filter_note.vue +++ b/app/assets/javascripts/notes/components/discussion_filter_note.vue @@ -38,12 +38,12 @@ export default {
-
+
- + {{ __('Show all activity') }} - + {{ __('Show comments only') }}
diff --git a/app/assets/javascripts/notes/components/note_attachment.vue b/app/assets/javascripts/notes/components/note_attachment.vue index b6d8c831e2e..72f9a4c7e74 100644 --- a/app/assets/javascripts/notes/components/note_attachment.vue +++ b/app/assets/javascripts/notes/components/note_attachment.vue @@ -12,11 +12,23 @@ export default {