From be4b3134a282f7a8812306777abd2d3150deecdc Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Tue, 4 May 2021 15:10:36 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop_todo.yml | 8 -- GITALY_SERVER_VERSION | 2 +- .../sidebar/board_sidebar_labels_select.vue | 7 +- .../frequent_items/components/app.vue | 2 +- .../components/frequent_items_list.vue | 6 +- .../components/issuable_item.vue | 13 +- .../components/issues_list_app.vue | 30 ++++- .../javascripts/issues_list/constants.js | 83 ------------ app/assets/javascripts/issues_list/utils.js | 119 +++++++++++++++++- .../jobs/components/table/index.js | 10 +- .../jobs/components/table/jobs_table.vue | 7 +- .../jobs/components/table/jobs_table_app.vue | 10 ++ .../table/jobs_table_empty_state.vue | 35 ++++++ .../javascripts/lib/utils/datetime_utility.js | 2 + .../components/diff_file_editor.vue | 34 ++--- .../components/inline_conflict_lines.vue | 2 +- .../components/parallel_conflict_lines.vue | 2 +- .../merge_conflict_resolver_app.vue | 111 +++++++--------- .../components/date/sidebar_date_widget.vue | 2 +- app/assets/stylesheets/framework/diffs.scss | 4 - .../stylesheets/framework/dropdowns.scss | 3 +- .../stylesheets/framework/issue_box.scss | 11 +- .../page_bundles/merge_conflicts.scss | 17 --- .../stylesheets/page_bundles/milestone.scss | 17 --- app/controllers/concerns/page_limiter.rb | 2 +- app/finders/packages/go/version_finder.rb | 2 +- app/helpers/time_zone_helper.rb | 2 +- app/models/bulk_imports/tracker.rb | 2 +- app/models/concerns/cache_markdown_field.rb | 4 +- app/models/concerns/group_descendant.rb | 4 +- .../concerns/has_wiki_page_meta_attributes.rb | 2 +- app/models/concerns/reactive_caching.rb | 2 +- app/models/concerns/sha256_attribute.rb | 2 +- app/models/concerns/sha_attribute.rb | 2 +- .../concerns/storage/legacy_namespace.rb | 4 +- app/models/concerns/token_authenticatable.rb | 2 +- .../concerns/x509_serial_number_attribute.rb | 2 +- app/models/namespace/traversal_hierarchy.rb | 2 +- app/models/namespaces/traversal/linear.rb | 2 +- app/models/packages/go/module.rb | 4 +- app/models/packages/go/module_version.rb | 12 +- app/models/project.rb | 2 +- app/models/releases/evidence.rb | 2 +- app/models/releases/link.rb | 2 +- app/models/ssh_host_key.rb | 4 +- .../process_prometheus_alert_service.rb | 7 -- .../clusters/aws/fetch_credentials_service.rb | 2 +- .../alert_management/alert_processing.rb | 20 +-- .../groups/import_export/export_service.rb | 2 +- .../groups/import_export/import_service.rb | 2 +- .../dashboard/grafana_metric_embed_service.rb | 6 +- .../dashboard/transient_embed_service.rb | 2 +- .../statistics_refresher_service.rb | 2 +- .../notification_recipients/builder/base.rb | 24 ++++ .../extract_changes_metadata_service.rb | 20 +-- .../debian/extract_metadata_service.rb | 2 +- .../nuget/metadata_extraction_service.rb | 6 +- .../update_package_from_metadata_service.rb | 4 +- .../packages/pypi/create_package_service.rb | 2 +- .../packages/rubygems/process_gem_service.rb | 2 +- app/services/projects/after_rename_service.rb | 6 +- app/services/projects/destroy_service.rb | 2 +- .../projects/import_export/export_service.rb | 2 +- app/services/projects/transfer_service.rb | 8 +- app/services/projects/update_service.rb | 6 +- .../static_site_editor/config_service.rb | 2 +- app/services/submit_usage_ping_service.rb | 6 +- .../terraform/remote_state_handler.rb | 2 +- .../todos/destroy/entity_leave_service.rb | 2 +- ...pdate_assigned_open_issue_count_service.rb | 2 +- .../users/update_canonical_email_service.rb | 2 +- app/services/users/update_service.rb | 2 +- app/uploaders/object_storage.rb | 2 +- app/validators/cron_validator.rb | 2 +- app/views/projects/jobs/index.html.haml | 2 +- .../_shared_runners_description.html.haml | 9 +- .../concerns/git_garbage_collect_methods.rb | 4 +- .../object_storage/migrate_uploads_worker.rb | 2 +- .../packages/maven/metadata/sync_worker.rb | 4 +- .../users/update_open_issue_count_worker.rb | 4 +- .../unreleased/321090-leipert-gitlab-ui.yml | 5 + ...ification-recipients-builder-for-watch.yml | 5 + ...ue-due-date-changes-without-user-input.yml | 5 + .../mrincon-fix-xss-shared-runners-text.yml | 5 + .../unreleased/pl-rubocop-todo-raise-args.yml | 5 + .../sy-consistently-auto-resolve-alerts.yml | 5 + .../development/api_caching_releases.yml | 8 ++ ...190402150158_backport_enterprise_schema.rb | 2 +- .../geo/disaster_recovery/index.md | 22 ++-- doc/administration/geo/index.md | 2 +- .../packages/container_registry.md | 4 +- doc/api/events.md | 18 +-- .../index.md | 4 +- .../blueprints/image_resizing/index.md | 4 +- doc/development/feature_flags/controls.md | 2 +- .../multi_version_compatibility.md | 2 +- doc/development/packages.md | 4 +- doc/integration/jira/connect-app.md | 34 ++--- doc/integration/jira/development_panel.md | 2 +- .../prometheus_library/cloudwatch.md | 2 +- .../repository/repository_mirroring.md | 5 +- lib/api/helpers/caching.rb | 7 +- lib/api/helpers/headers_helpers.rb | 2 +- lib/api/internal/base.rb | 2 +- lib/api/releases.rb | 16 ++- lib/bulk_imports/clients/http.rb | 2 +- lib/declarative_enum.rb | 2 +- lib/flowdock/git.rb | 2 +- lib/gitlab/alert_management/payload/base.rb | 2 +- lib/gitlab/auth/auth_finders.rb | 2 +- lib/gitlab/auth/ldap/config.rb | 2 +- lib/gitlab/bare_repository_import/importer.rb | 2 +- lib/gitlab/changelog/committer.rb | 2 +- lib/gitlab/changelog/parser.rb | 2 +- lib/gitlab/ci/parsers/test/junit.rb | 2 +- lib/gitlab/ci/yaml_processor.rb | 2 +- lib/gitlab/cycle_analytics/summary/base.rb | 4 +- .../loose_index_scan_distinct_count.rb | 2 +- lib/gitlab/encrypted_configuration.rb | 4 +- lib/gitlab/experimentation.rb | 2 +- lib/gitlab/external_authorization/client.rb | 2 +- lib/gitlab/git/conflict/resolver.rb | 4 +- lib/gitlab/git/repository.rb | 10 +- lib/gitlab/git/rugged_impl/repository.rb | 2 +- lib/gitlab/git/wraps_gitaly_errors.rb | 8 +- lib/gitlab/gitaly_client/operation_service.rb | 4 +- lib/gitlab/gitaly_client/ref_service.rb | 2 +- .../gitaly_client/repository_service.rb | 2 +- lib/gitlab/golang.rb | 6 +- .../graphql/pagination/keyset/connection.rb | 4 +- .../graphql/pagination/keyset/order_info.rb | 8 +- .../pagination/keyset/query_builder.rb | 4 +- lib/gitlab/graphql/variables.rb | 2 +- .../web_upload_strategy.rb | 2 +- .../after_export_strategy_builder.rb | 2 +- lib/gitlab/import_export/file_importer.rb | 4 +- lib/gitlab/import_export/importer.rb | 4 +- .../import_export/json/legacy_reader.rb | 2 +- lib/gitlab/import_export/lfs_restorer.rb | 2 +- lib/gitlab/import_export/shared.rb | 2 +- lib/gitlab/import_export/version_checker.rb | 4 +- .../redis_cluster_validator.rb | 2 +- lib/gitlab/jira/http_client.rb | 2 +- lib/gitlab/json.rb | 2 +- .../legacy_github_import/label_formatter.rb | 2 +- lib/gitlab/lfs/client.rb | 2 +- lib/gitlab/metrics/dashboard/errors.rb | 2 +- .../metrics/dashboard/stages/base_stage.rb | 6 +- .../stages/cluster_endpoint_inserter.rb | 8 +- .../stages/metric_endpoint_inserter.rb | 4 +- .../stages/variable_endpoint_inserter.rb | 2 +- lib/gitlab/multi_collection_paginator.rb | 2 +- lib/gitlab/object_hierarchy.rb | 2 +- lib/gitlab/otp_key_rotator.rb | 4 +- lib/gitlab/patch/draw_route.rb | 2 +- .../phabricator_import/conduit/client.rb | 2 +- .../phabricator_import/conduit/response.rb | 2 +- .../prometheus/additional_metrics_parser.rb | 2 +- lib/gitlab/redis/boolean.rb | 8 +- lib/gitlab/redis/hll.rb | 2 +- lib/gitlab/repository_url_builder.rb | 2 +- lib/gitlab/routing.rb | 2 +- lib/gitlab/runtime.rb | 8 +- lib/gitlab/search/parsed_query.rb | 2 +- lib/gitlab/sidekiq_config/worker_matcher.rb | 6 +- lib/gitlab/task_helpers.rb | 2 +- lib/gitlab/untrusted_regexp.rb | 2 +- lib/gitlab/url_builder.rb | 2 +- .../usage_data_counters/hll_redis_counter.rb | 4 +- lib/gitlab/utils.rb | 2 +- lib/gitlab/utils/override.rb | 4 +- lib/gitlab/verify/batch_verifier.rb | 14 +-- lib/gitlab/view/presenter/delegated.rb | 2 +- lib/grafana/time_window.rb | 2 +- lib/mattermost/client.rb | 4 +- lib/mattermost/session.rb | 4 +- qa/qa/page/base.rb | 2 +- .../graceful_timeout_handling_spec.rb | 2 +- .../projects/labels_controller_spec.rb | 2 +- .../user_resolves_conflicts_spec.rb | 2 +- spec/features/runners_spec.rb | 67 ++++++++-- .../components/issuable_item_spec.js | 26 ++++ .../components/issues_list_app_spec.js | 44 ++++--- spec/frontend/issues_list/utils_spec.js | 34 +++++ .../components/table/job_table_app_spec.js | 32 ++++- .../table/jobs_table_empty_state_spec.js | 37 ++++++ spec/frontend/jobs/mock_data.js | 8 ++ .../merge_conflict_resolver_app_spec.js | 12 +- .../date/sidebar_date_widget_spec.js | 8 ++ .../alert_management/payload/base_spec.rb | 6 + spec/lib/gitlab/database_spec.rb | 2 +- .../external_authorization/access_spec.rb | 2 +- .../external_authorization/client_spec.rb | 2 +- .../gitlab/git/wraps_gitaly_errors_spec.rb | 2 +- spec/models/ci/pipeline_schedule_spec.rb | 2 +- .../namespace/traversal_hierarchy_spec.rb | 2 +- .../api_guard/admin_mode_middleware_spec.rb | 2 +- spec/requests/api/helpers_spec.rb | 2 +- spec/requests/api/releases_spec.rb | 70 ++++++++++- .../process_prometheus_alert_service_spec.rb | 2 +- spec/services/auto_merge/base_service_spec.rb | 8 +- spec/services/branches/delete_service_spec.rb | 2 +- .../ci/parse_dotenv_artifact_service_spec.rb | 2 +- .../merge_to_ref_service_spec.rb | 2 +- spec/support/helpers/board_helpers.rb | 1 + spec/support/helpers/dns_helpers.rb | 2 +- .../support/helpers/next_found_instance_of.rb | 2 +- spec/support/helpers/redis_without_keys.rb | 4 +- spec/support/helpers/require_migration.rb | 2 +- .../alert_recovery_shared_examples.rb | 64 ---------- .../alert_management_shared_examples.rb | 20 ++- spec/support/stored_repositories.rb | 2 +- 212 files changed, 1002 insertions(+), 658 deletions(-) create mode 100644 app/assets/javascripts/jobs/components/table/jobs_table_empty_state.vue create mode 100644 changelogs/unreleased/321090-leipert-gitlab-ui.yml create mode 100644 changelogs/unreleased/326045-refactor-notification-recipients-builder-for-watch.yml create mode 100644 changelogs/unreleased/329614-issue-due-date-changes-without-user-input.yml create mode 100644 changelogs/unreleased/mrincon-fix-xss-shared-runners-text.yml create mode 100644 changelogs/unreleased/pl-rubocop-todo-raise-args.yml create mode 100644 changelogs/unreleased/sy-consistently-auto-resolve-alerts.yml create mode 100644 config/feature_flags/development/api_caching_releases.yml create mode 100644 spec/frontend/jobs/components/table/jobs_table_empty_state_spec.js diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 64332dfc0ce..0f2f3bc44a4 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -820,14 +820,6 @@ Style/NumericLiteralPrefix: Style/PercentLiteralDelimiters: Enabled: false -# Offense count: 247 -# Cop supports --auto-correct. -# Configuration parameters: . -# SupportedStyles: compact, exploded -Style/RaiseArgs: - Enabled: false - EnforcedStyle: exploded - # Offense count: 26 # Cop supports --auto-correct. # Configuration parameters: SafeForConstants. diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index 83823ce4036..94c23ab5110 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -bb763fb573555a0f9714002c2755bdd396cab3dd +9523fe6434ea464a6a16c895222a4b001a5c0bca diff --git a/app/assets/javascripts/boards/components/sidebar/board_sidebar_labels_select.vue b/app/assets/javascripts/boards/components/sidebar/board_sidebar_labels_select.vue index f78be83cd82..aedd695d07b 100644 --- a/app/assets/javascripts/boards/components/sidebar/board_sidebar_labels_select.vue +++ b/app/assets/javascripts/boards/components/sidebar/board_sidebar_labels_select.vue @@ -77,7 +77,12 @@ export default {