From bf1990164b801489b4475504701eefb66146e724 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 12 Aug 2021 18:10:45 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../admin/users/components/actions/ban.vue | 7 +- .../components/service_credentials_form.vue | 2 +- .../components/environments_app.vue | 36 +++- .../javascripts/environments/constants.js | 2 + .../jobs/index/components/stop_jobs_modal.vue | 2 +- .../components/states_table_actions.vue | 2 +- app/finders/issues_finder.rb | 13 +- app/finders/issues_finder/params.rb | 8 +- app/graphql/resolvers/issues_resolver.rb | 3 +- .../nuget/dependency_link_metadatum_type.rb | 2 +- app/helpers/issues_helper.rb | 4 + app/models/issue.rb | 17 +- app/policies/issue_policy.rb | 7 + .../permit_data_categories_service.rb | 8 +- .../appearances/_form.html.haml | 2 +- app/views/projects/issues/_issue.html.haml | 3 + ...6181508_i_quickactions_approve_monthly.yml | 4 + ...2_i_quickactions_assign_single_monthly.yml | 4 + ...519_i_quickactions_assign_self_monthly.yml | 4 + ...i_quickactions_assign_reviewer_monthly.yml | 4 + ...216181527_i_quickactions_award_monthly.yml | 4 + ...1530_i_quickactions_board_move_monthly.yml | 4 + ...216181541_i_quickactions_clone_monthly.yml | 4 + ...216181545_i_quickactions_close_monthly.yml | 4 + ...49_i_quickactions_confidential_monthly.yml | 4 + ...ns_copy_metadata_merge_request_monthly.yml | 4 + ...ickactions_copy_metadata_issue_monthly.yml | 4 + ...ckactions_create_merge_request_monthly.yml | 4 + ...0216181604_i_quickactions_done_monthly.yml | 4 + ...216181607_i_quickactions_draft_monthly.yml | 4 + ...10216181611_i_quickactions_due_monthly.yml | 4 + ...81615_i_quickactions_duplicate_monthly.yml | 4 + ...181622_i_quickactions_estimate_monthly.yml | 4 + ...216181629_i_quickactions_label_monthly.yml | 4 + ...0216181633_i_quickactions_lock_monthly.yml | 4 + ...216181637_i_quickactions_merge_monthly.yml | 4 + ...81641_i_quickactions_milestone_monthly.yml | 4 + ...0216181644_i_quickactions_move_monthly.yml | 4 + ...181659_i_quickactions_reassign_monthly.yml | 4 + ...quickactions_reassign_reviewer_monthly.yml | 6 +- ...16181707_i_quickactions_rebase_monthly.yml | 4 + ...6181710_i_quickactions_relabel_monthly.yml | 4 + ...16181714_i_quickactions_relate_monthly.yml | 4 + ...i_quickactions_remove_due_date_monthly.yml | 4 + ...i_quickactions_remove_estimate_monthly.yml | 4 + ..._quickactions_remove_milestone_monthly.yml | 4 + ...quickactions_remove_time_spent_monthly.yml | 4 + ...747_i_quickactions_remove_zoom_monthly.yml | 4 + ...16181751_i_quickactions_reopen_monthly.yml | 4 + ...216181755_i_quickactions_shrug_monthly.yml | 4 + ..._i_quickactions_spend_subtract_monthly.yml | 4 + ...81802_i_quickactions_spend_add_monthly.yml | 4 + ...6_i_quickactions_submit_review_monthly.yml | 4 + ...81809_i_quickactions_subscribe_monthly.yml | 4 + ...81813_i_quickactions_tableflip_monthly.yml | 4 + ...10216181817_i_quickactions_tag_monthly.yml | 4 + ...1_i_quickactions_target_branch_monthly.yml | 4 + ...216181824_i_quickactions_title_monthly.yml | 4 + ...0216181828_i_quickactions_todo_monthly.yml | 4 + ...quickactions_unassign_specific_monthly.yml | 4 + ...35_i_quickactions_unassign_all_monthly.yml | 4 + ...quickactions_unassign_reviewer_monthly.yml | 4 + ..._quickactions_unlabel_specific_monthly.yml | 4 + ...846_i_quickactions_unlabel_all_monthly.yml | 4 + ...16181850_i_quickactions_unlock_monthly.yml | 4 + ...854_i_quickactions_unsubscribe_monthly.yml | 4 + ...10216181901_i_quickactions_wip_monthly.yml | 4 + ...0216181905_i_quickactions_zoom_monthly.yml | 4 + ...ickactions_total_unique_counts_monthly.yml | 71 ++++++++ ...ickactions_invite_email_single_monthly.yml | 4 + ...kactions_invite_email_multiple_monthly.yml | 4 + ...042227_i_quickactions_severity_monthly.yml | 4 + ...16181506_i_quickactions_approve_weekly.yml | 4 + ...10_i_quickactions_assign_single_weekly.yml | 4 + ...1517_i_quickactions_assign_self_weekly.yml | 4 + ..._i_quickactions_assign_reviewer_weekly.yml | 4 + ...0216181525_i_quickactions_award_weekly.yml | 4 + ...81529_i_quickactions_board_move_weekly.yml | 4 + ...0216181540_i_quickactions_clone_weekly.yml | 4 + ...0216181543_i_quickactions_close_weekly.yml | 4 + ...547_i_quickactions_confidential_weekly.yml | 4 + ...ons_copy_metadata_merge_request_weekly.yml | 4 + ...uickactions_copy_metadata_issue_weekly.yml | 4 + ...ickactions_create_merge_request_weekly.yml | 4 + ...10216181602_i_quickactions_done_weekly.yml | 4 + ...0216181605_i_quickactions_draft_weekly.yml | 4 + ...210216181609_i_quickactions_due_weekly.yml | 4 + ...181613_i_quickactions_duplicate_weekly.yml | 4 + ...6181620_i_quickactions_estimate_weekly.yml | 4 + ...0216181628_i_quickactions_label_weekly.yml | 4 + ...10216181631_i_quickactions_lock_weekly.yml | 4 + ...0216181635_i_quickactions_merge_weekly.yml | 4 + ...181639_i_quickactions_milestone_weekly.yml | 4 + ...10216181642_i_quickactions_move_weekly.yml | 4 + ...6181657_i_quickactions_reassign_weekly.yml | 4 + ..._quickactions_reassign_reviewer_weekly.yml | 6 +- ...216181705_i_quickactions_rebase_weekly.yml | 4 + ...16181708_i_quickactions_relabel_weekly.yml | 4 + ...216181712_i_quickactions_relate_weekly.yml | 4 + ..._i_quickactions_remove_due_date_weekly.yml | 4 + ..._i_quickactions_remove_estimate_weekly.yml | 4 + ...i_quickactions_remove_milestone_weekly.yml | 4 + ..._quickactions_remove_time_spent_weekly.yml | 4 + ...1745_i_quickactions_remove_zoom_weekly.yml | 4 + ...216181749_i_quickactions_reopen_weekly.yml | 4 + ...0216181753_i_quickactions_shrug_weekly.yml | 4 + ...6_i_quickactions_spend_subtract_weekly.yml | 4 + ...181800_i_quickactions_spend_add_weekly.yml | 4 + ...04_i_quickactions_submit_review_weekly.yml | 4 + ...181808_i_quickactions_subscribe_weekly.yml | 4 + ...181811_i_quickactions_tableflip_weekly.yml | 4 + ...210216181815_i_quickactions_tag_weekly.yml | 4 + ...19_i_quickactions_target_branch_weekly.yml | 4 + ...0216181822_i_quickactions_title_weekly.yml | 4 + ...10216181826_i_quickactions_todo_weekly.yml | 4 + ..._quickactions_unassign_specific_weekly.yml | 4 + ...833_i_quickactions_unassign_all_weekly.yml | 4 + ..._quickactions_unassign_reviewer_weekly.yml | 4 + ...i_quickactions_unlabel_specific_weekly.yml | 4 + ...1845_i_quickactions_unlabel_all_weekly.yml | 4 + ...216181848_i_quickactions_unlock_weekly.yml | 4 + ...1852_i_quickactions_unsubscribe_weekly.yml | 4 + ...210216181859_i_quickactions_wip_weekly.yml | 4 + ...10216181903_i_quickactions_zoom_weekly.yml | 4 + ...uickactions_invite_email_single_weekly.yml | 4 + ...ckactions_invite_email_multiple_weekly.yml | 4 + ...1042223_i_quickactions_severity_weekly.yml | 4 + .../collected_data_categories_schema.json | 2 +- config/metrics/schema.json | 2 +- ...722151951_add_columns_to_security_scans.rb | 21 +++ ...174349_add_fk_to_security_scans_columns.rb | 21 +++ ...opy_ci_builds_columns_to_security_scans.rb | 33 ++++ db/schema_migrations/20210722151951 | 1 + db/schema_migrations/20210728174349 | 1 + db/schema_migrations/20210811214811 | 1 + db/structure.sql | 11 +- doc/api/graphql/reference/index.md | 2 +- .../service_ping/metrics_dictionary.md | 10 +- doc/user/admin_area/moderate_users.md | 6 +- .../metric_definition.yml | 2 +- ...opy_ci_builds_columns_to_security_scans.rb | 44 +++++ lib/gitlab/ci/reports/security/finding.rb | 3 +- lib/gitlab/usage/metric_definition.rb | 6 +- locale/gitlab.pot | 48 ++++-- spec/db/schema_spec.rb | 3 +- .../clusters/cluster_health_dashboard_spec.rb | 2 +- spec/finders/issues_finder_spec.rb | 162 ++++++++++++++---- .../sample_metric.yml | 2 +- .../sample_metric_with_ee.yml | 2 +- .../sample_metric_with_name_suggestions.yml | 2 +- .../environments/environments_app_spec.js | 50 +++++- .../components/states_table_actions_spec.js | 2 +- .../design_management/delete_spec.rb | 39 +++-- .../graphql/resolvers/issues_resolver_spec.rb | 6 +- ...i_builds_columns_to_security_scans_spec.rb | 51 ++++++ spec/lib/gitlab/usage/docs/helper_spec.rb | 4 +- .../gitlab/usage/metric_definition_spec.rb | 4 +- .../collected_data_categories_metric_spec.rb | 2 +- spec/lib/gitlab/usage_data_metrics_spec.rb | 162 +++++------------- spec/lib/gitlab/usage_data_spec.rb | 2 +- ...i_builds_columns_to_security_scans_spec.rb | 43 +++++ spec/models/issue_spec.rb | 59 +++++++ spec/policies/issue_policy_spec.rb | 15 ++ .../permit_data_categories_service_spec.rb | 2 +- ...ping_metrics_definitions_shared_context.rb | 8 +- 165 files changed, 1223 insertions(+), 246 deletions(-) create mode 100644 db/migrate/20210722151951_add_columns_to_security_scans.rb create mode 100644 db/migrate/20210728174349_add_fk_to_security_scans_columns.rb create mode 100644 db/post_migrate/20210811214811_schedule_copy_ci_builds_columns_to_security_scans.rb create mode 100644 db/schema_migrations/20210722151951 create mode 100644 db/schema_migrations/20210728174349 create mode 100644 db/schema_migrations/20210811214811 create mode 100644 lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb create mode 100644 spec/lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans_spec.rb create mode 100644 spec/migrations/schedule_copy_ci_builds_columns_to_security_scans_spec.rb diff --git a/app/assets/javascripts/admin/users/components/actions/ban.vue b/app/assets/javascripts/admin/users/components/actions/ban.vue index 4e9cefbfdd7..e5ab0f9123f 100644 --- a/app/assets/javascripts/admin/users/components/actions/ban.vue +++ b/app/assets/javascripts/admin/users/components/actions/ban.vue @@ -6,10 +6,11 @@ import { I18N_USER_ACTIONS } from '../../constants'; // TODO: To be replaced with