kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch '46861-issuable-title-with-longer-username' into 'master'

Browse source 
Buttons disappear on merge request page in some case

Closes #46861 and #14348

See merge request gitlab-org/gitlab-ce!19176
This commit is contained in:
Clement Ho 2018-06-18 19:40:16 +00:00
commit bfa7983dd6
4 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/assets/stylesheets/pages/detail_page.scss
View file

@ -23,7 +23,8 @@
position: relative;
line-height: 35px;
display: flex;
flex-grow: 1;
flex: 1 1;
min-width: 0;
@include media-breakpoint-up(sm) {
padding-left: 0;

2
app/assets/stylesheets/pages/issuable.scss
View file

@ -698,6 +698,8 @@
font-size: 14px;
line-height: 24px;
align-self: center;
overflow: hidden;
text-overflow: ellipsis;
}
.js-issuable-selector-wrap {

2
app/helpers/issuables_helper.rb
View file

@ -157,7 +157,7 @@ module IssuablesHelper
output = ""
output << "Opened #{time_ago_with_tooltip(issuable.created_at)} by ".html_safe
output << content_tag(:strong) do
author_output = link_to_member(project, issuable.author, size: 24, mobile_classes: "d-none d-sm-inline-block", tooltip: true)
author_output = link_to_member(project, issuable.author, size: 24, mobile_classes: "d-none d-sm-inline", tooltip: true)
author_output << link_to_member(project, issuable.author, size: 24, by_username: true, avatar: false, mobile_classes: "d-block d-sm-none")
end

5
changelogs/unreleased/46861-issuable-title-with-longer-username.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Fix CSS for buttons not to be hidden on issues/MR title
merge_request: 19176
author: Takuya Noguchi
type: fixed