Rename priority sorting option to label priority

This commit is contained in:
Dimitrie Hoekstra 2017-03-07 17:12:53 +00:00 committed by Sean McGivern
parent e84afa8bed
commit bfd33645f5
4 changed files with 11 additions and 7 deletions

View file

@ -50,7 +50,7 @@ module SortingHelper
end
def sort_title_priority
'Priority'
'Label priority'
end
def sort_title_oldest_updated

View file

@ -0,0 +1,4 @@
---
title: Rename priority sorting option to label priority
merge_request:
author:

View file

@ -32,7 +32,7 @@ feature 'Issue prioritization', feature: true do
visit namespace_project_issues_path(project.namespace, project, sort: 'priority')
# Ensure we are indicating that issues are sorted by priority
expect(page).to have_selector('.dropdown-toggle', text: 'Priority')
expect(page).to have_selector('.dropdown-toggle', text: 'Label priority')
page.within('.issues-holder') do
issue_titles = all('.issues-list .issue-title-text').map(&:text)
@ -70,7 +70,7 @@ feature 'Issue prioritization', feature: true do
login_as user
visit namespace_project_issues_path(project.namespace, project, sort: 'priority')
expect(page).to have_selector('.dropdown-toggle', text: 'Priority')
expect(page).to have_selector('.dropdown-toggle', text: 'Label priority')
page.within('.issues-holder') do
issue_titles = all('.issues-list .issue-title-text').map(&:text)

View file

@ -56,8 +56,8 @@ describe "Dashboard > User sorts todos", feature: true do
expect(results_list.all('p')[4]).to have_content("merge_request_1")
end
it "sorts by priority" do
click_link "Priority"
it "sorts by label priority" do
click_link "Label priority"
results_list = page.find('.todos-list')
expect(results_list.all('p')[0]).to have_content("issue_3")
@ -85,8 +85,8 @@ describe "Dashboard > User sorts todos", feature: true do
visit dashboard_todos_path
end
it "doesn't mix issues and merge requests priorities" do
click_link "Priority"
it "doesn't mix issues and merge requests label priorities" do
click_link "Label priority"
results_list = page.find('.todos-list')
expect(results_list.all('p')[0]).to have_content("issue_1")