Add Projects::Clusters::ApplicationsController tests
This commit is contained in:
parent
e6616e0468
commit
c0299ce494
|
@ -9,7 +9,7 @@ class Projects::Clusters::ApplicationsController < Projects::ApplicationControll
|
|||
application_class: @application_class,
|
||||
cluster: @cluster).execute
|
||||
if scheduled
|
||||
head :no_data
|
||||
head :no_content
|
||||
else
|
||||
head :bad_request
|
||||
end
|
||||
|
|
|
@ -192,7 +192,7 @@ constraints(ProjectUrlConstrainer.new) do
|
|||
get :status, format: :json
|
||||
|
||||
scope :applications do
|
||||
post '/*application', to: 'clusters/applications#create'
|
||||
post '/*application', to: 'clusters/applications#create', as: :install_applications
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
|
@ -0,0 +1,73 @@
|
|||
require 'spec_helper'
|
||||
|
||||
describe Projects::Clusters::ApplicationsController do
|
||||
include AccessMatchersForController
|
||||
|
||||
def current_application
|
||||
Clusters::Cluster::APPLICATIONS[application]
|
||||
end
|
||||
|
||||
describe 'POST create' do
|
||||
let(:cluster) { create(:cluster, :project, :providing_by_gcp) }
|
||||
let(:project) { cluster.project }
|
||||
let(:application) { 'helm' }
|
||||
let(:params) { { application: application, id: cluster.id } }
|
||||
|
||||
describe 'functionality' do
|
||||
let(:user) { create(:user) }
|
||||
|
||||
before do
|
||||
project.add_master(user)
|
||||
sign_in(user)
|
||||
end
|
||||
|
||||
it 'schedule an application installation' do
|
||||
expect(ClusterInstallAppWorker).to receive(:perform_async).with(application, anything).once
|
||||
|
||||
expect { go }.to change { current_application.count }
|
||||
expect(response).to have_http_status(:no_content)
|
||||
expect(cluster.application_helm).to be_scheduled
|
||||
end
|
||||
|
||||
context 'when cluster do not exists' do
|
||||
before do
|
||||
cluster.destroy!
|
||||
end
|
||||
|
||||
it 'return 404' do
|
||||
expect { go }.not_to change { current_application.count }
|
||||
expect(response).to have_http_status(:not_found)
|
||||
end
|
||||
end
|
||||
|
||||
context 'when application is unknown' do
|
||||
let(:application) { 'unkwnown-app' }
|
||||
|
||||
it 'return 404' do
|
||||
go
|
||||
|
||||
expect(response).to have_http_status(:not_found)
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
describe 'security' do
|
||||
before do
|
||||
allow(ClusterInstallAppWorker).to receive(:perform_async)
|
||||
end
|
||||
|
||||
it { expect { go }.to be_allowed_for(:admin) }
|
||||
it { expect { go }.to be_allowed_for(:owner).of(project) }
|
||||
it { expect { go }.to be_allowed_for(:master).of(project) }
|
||||
it { expect { go }.to be_denied_for(:developer).of(project) }
|
||||
it { expect { go }.to be_denied_for(:reporter).of(project) }
|
||||
it { expect { go }.to be_denied_for(:guest).of(project) }
|
||||
it { expect { go }.to be_denied_for(:user) }
|
||||
it { expect { go }.to be_denied_for(:external) }
|
||||
end
|
||||
|
||||
def go
|
||||
post :create, params.merge(namespace_id: project.namespace, project_id: project)
|
||||
end
|
||||
end
|
||||
end
|
|
@ -5,7 +5,7 @@ module AccessMatchersForController
|
|||
extend RSpec::Matchers::DSL
|
||||
include Warden::Test::Helpers
|
||||
|
||||
EXPECTED_STATUS_CODE_ALLOWED = [200, 201, 302].freeze
|
||||
EXPECTED_STATUS_CODE_ALLOWED = [200, 201, 204, 302].freeze
|
||||
EXPECTED_STATUS_CODE_DENIED = [401, 404].freeze
|
||||
|
||||
def emulate_user(role, membership = nil)
|
||||
|
|
Loading…
Reference in New Issue