Remove IIFEs around several javascript classes

app/assets/javascripts/signin_tabs_memoizer.js

@@ -2,12 +2,11 @@
 /* eslint no-new: "off" */
 import AccessorUtilities from './lib/utils/accessor';
 
-((global) => {
+/**
-  /**
  * Memorize the last selected tab after reloading a page.
  * Does that setting the current selected tab in the localStorage
  */
-  class ActiveTabMemoizer {
+class ActiveTabMemoizer {
   constructor({ currentTabKey = 'current_signin_tab', tabSelector = 'ul.nav-tabs' } = {}) {
     this.currentTabKey = currentTabKey;
     this.tabSelector = tabSelector;
@@ -51,7 +50,6 @@ import AccessorUtilities from './lib/utils/accessor';
 
     return window.localStorage.getItem(this.currentTabKey);
   }
-  }
+}
 
-  global.ActiveTabMemoizer = ActiveTabMemoizer;
+window.ActiveTabMemoizer = ActiveTabMemoizer;
-})(window);

app/assets/javascripts/single_file_diff.js

@@ -2,8 +2,7 @@
 
 import FilesCommentButton from './files_comment_button';
 
-(function() {
+window.SingleFileDiff = (function() {
-  window.SingleFileDiff = (function() {
   var COLLAPSED_HTML, ERROR_HTML, LOADING_HTML, WRAPPER;
 
   WRAPPER = '<div class="diff-content"></div>';
@@ -88,13 +87,12 @@ import FilesCommentButton from './files_comment_button';
   };
 
   return SingleFileDiff;
-  })();
+})();
 
-  $.fn.singleFileDiff = function() {
+$.fn.singleFileDiff = function() {
   return this.each(function() {
     if (!$.data(this, 'singleFileDiff')) {
       return $.data(this, 'singleFileDiff', new window.SingleFileDiff(this));
     }
   });
-  };
+};
-}).call(window);

app/assets/javascripts/smart_interval.js

@@ -1,11 +1,9 @@
-/*
+/**
-* Instances of SmartInterval extend the functionality of `setInterval`, make it configurable
+ * Instances of SmartInterval extend the functionality of `setInterval`, make it configurable
-* and controllable by a public API.
+ * and controllable by a public API.
-*
+ */
-* */
 
-(() => {
+class SmartInterval {
-  class SmartInterval {
   /**
    * @param { function } opts.callback Function to be called on each iteration (required)
    * @param { milliseconds } opts.startingInterval `currentInterval` is set to this initially
@@ -37,6 +35,7 @@
 
     this.initInterval();
   }
+
   /* public */
 
   start() {
@@ -153,6 +152,6 @@
 
     state.intervalId = window.clearInterval(state.intervalId);
   }
-  }
+}
-  gl.SmartInterval = SmartInterval;
+
-})(window.gl || (window.gl = {}));
+window.gl.SmartInterval = SmartInterval;

app/assets/javascripts/snippets_list.js

@@ -1,13 +1,9 @@
 /* eslint-disable arrow-parens, no-param-reassign, space-before-function-paren, func-names, no-var, max-len */
 
-(global => {
+window.gl.SnippetsList = function() {
-  global.gl = global.gl || {};
-
-  gl.SnippetsList = function() {
   var $holder = $('.snippets-list-holder');
 
   $holder.find('.pagination').on('ajax:success', (e, data) => {
     $holder.replaceWith(data.html);
   });
-  };
+};
-})(window);

app/assets/javascripts/star.js

@@ -1,8 +1,7 @@
 /* eslint-disable func-names, space-before-function-paren, wrap-iife, no-unused-vars, one-var, no-var, one-var-declaration-per-line, prefer-arrow-callback, no-new, max-len */
 /* global Flash */
 
-(function() {
+window.Star = (function() {
-  this.Star = (function() {
   function Star() {
     $('.project-home-panel .toggle-star').on('ajax:success', function(e, data, status, xhr) {
       var $starIcon, $starSpan, $this, toggleStar;
@@ -26,5 +25,4 @@
   }
 
   return Star;
-  })();
+})();
-}).call(window);

app/assets/javascripts/subscription.js

@@ -1,5 +1,4 @@
-(() => {
+class Subscription {
-  class Subscription {
   constructor(containerElm) {
     this.containerElm = containerElm;
 
@@ -40,8 +39,7 @@
   static bindAll(selector) {
     [].forEach.call(document.querySelectorAll(selector), elm => new Subscription(elm));
   }
-  }
+}
 
-  window.gl = window.gl || {};
+window.gl = window.gl || {};
-  window.gl.Subscription = Subscription;
+window.gl.Subscription = Subscription;
-})();

app/assets/javascripts/subscription_select.js

@@ -1,6 +1,6 @@
 /* eslint-disable func-names, space-before-function-paren, wrap-iife, no-var, quotes, object-shorthand, no-unused-vars, no-shadow, one-var, one-var-declaration-per-line, comma-dangle, max-len */
-(function() {
+
-  this.SubscriptionSelect = (function() {
+window.SubscriptionSelect = (function() {
   function SubscriptionSelect() {
     $('.js-subscription-event').each(function(i, el) {
       var fieldName;
@@ -30,5 +30,4 @@
   }
 
   return SubscriptionSelect;
-  })();
+})();
-}).call(window);

app/assets/javascripts/syntax_highlight.js

@@ -9,8 +9,8 @@
 //
 //   <div class="js-syntax-highlight"></div>
 //
-(function() {
+
-  $.fn.syntaxHighlight = function() {
+$.fn.syntaxHighlight = function() {
   var $children;
 
   if ($(this).hasClass('js-syntax-highlight')) {
@@ -23,5 +23,4 @@
       return $children.syntaxHighlight();
     }
   }
-  };
+};
-}).call(window);

app/assets/javascripts/tree.js

@@ -1,7 +1,6 @@
 /* eslint-disable func-names, space-before-function-paren, wrap-iife, max-len, quotes, consistent-return, no-var, one-var, one-var-declaration-per-line, no-else-return, prefer-arrow-callback, max-len */
 
-(function() {
+window.TreeView = (function() {
-  this.TreeView = (function() {
   function TreeView() {
     this.initKeyNav();
     // Code browser tree slider
@@ -64,5 +63,4 @@
   };
 
   return TreeView;
-  })();
+})();
-}).call(window);

app/assets/javascripts/user.js

@@ -2,8 +2,7 @@
 
 import Cookies from 'js-cookie';
 
-((global) => {
+class User {
-  global.User = class {
   constructor({ action }) {
     this.action = action;
     this.placeProfileAvatarsToTop();
@@ -18,7 +17,7 @@ import Cookies from 'js-cookie';
   }
 
   initTabs() {
-      return new global.UserTabs({
+    return new window.gl.UserTabs({
       parentEl: '.user-profile',
       action: this.action
     });
@@ -31,5 +30,7 @@ import Cookies from 'js-cookie';
       $(this).parents('.project-limit-message').remove();
     });
   }
-  };
+}
-})(window.gl || (window.gl = {}));
+
+window.gl = window.gl || {};
+window.gl.User = User;

app/assets/javascripts/user_tabs.js

@@ -59,8 +59,8 @@ content on the Users#show page.
      </div>
    </div>
 */
-((global) => {
+
-  class UserTabs {
+class UserTabs {
   constructor ({ defaultAction, action, parentEl }) {
     this.loaded = {};
     this.defaultAction = defaultAction || 'activity';
@@ -170,6 +170,7 @@ content on the Users#show page.
   getCurrentAction() {
     return this.$parentEl.find('.nav-links .active a').data('action');
   }
-  }
+}
-  global.UserTabs = UserTabs;
+
-})(window.gl || (window.gl = {}));
+window.gl = window.gl || {};
+window.gl.UserTabs = UserTabs;

app/assets/javascripts/username_validator.js

@@ -1,15 +1,14 @@
 /* eslint-disable comma-dangle, consistent-return, class-methods-use-this, arrow-parens, no-param-reassign, max-len */
 
-((global) => {
+const debounceTimeoutDuration = 1000;
-  const debounceTimeoutDuration = 1000;
+const invalidInputClass = 'gl-field-error-outline';
-  const invalidInputClass = 'gl-field-error-outline';
+const successInputClass = 'gl-field-success-outline';
-  const successInputClass = 'gl-field-success-outline';
+const unavailableMessageSelector = '.username .validation-error';
-  const unavailableMessageSelector = '.username .validation-error';
+const successMessageSelector = '.username .validation-success';
-  const successMessageSelector = '.username .validation-success';
+const pendingMessageSelector = '.username .validation-pending';
-  const pendingMessageSelector = '.username .validation-pending';
+const invalidMessageSelector = '.username .gl-field-error';
-  const invalidMessageSelector = '.username .gl-field-error';
 
-  class UsernameValidator {
+class UsernameValidator {
   constructor() {
     this.inputElement = $('#new_user_username');
     this.inputDomElement = this.inputElement.get(0);
@@ -129,7 +128,6 @@
     this.inputElement.addClass(invalidInputClass).removeClass(successInputClass);
     $inputErrorMessage.show();
   }
-  }
+}
 
-  global.UsernameValidator = UsernameValidator;
+window.UsernameValidator = UsernameValidator;
-})(window);

app/assets/javascripts/visibility_select.js

@@ -1,7 +1,4 @@
-(() => {
+class VisibilitySelect {
-  const gl = window.gl || (window.gl = {});
-
-  class VisibilitySelect {
   constructor(container) {
     if (!container) throw new Error('VisibilitySelect requires a container element as argument 1');
     this.container = container;
@@ -21,7 +18,7 @@
   updateHelpText() {
     this.helpBlock.textContent = this.select.querySelector('option:checked').dataset.description;
   }
-  }
+}
 
-  gl.VisibilitySelect = VisibilitySelect;
+window.gl = window.gl || {};
-})();
+window.gl.VisibilitySelect = VisibilitySelect;

app/assets/javascripts/wikis.js

@@ -4,8 +4,7 @@
 import 'vendor/jquery.nicescroll';
 import './breakpoints';
 
-((global) => {
+class Wikis {
-  class Wikis {
   constructor() {
     this.bp = Breakpoints.get();
     this.sidebarEl = document.querySelector('.js-wiki-sidebar');
@@ -63,7 +62,7 @@ import './breakpoints';
       classList.remove('right-sidebar-expanded');
     }
   }
-  }
+}
 
-  global.Wikis = Wikis;
+window.gl = window.gl || {};
-})(window.gl || (window.gl = {}));
+window.gl.Wikis = Wikis;

app/assets/javascripts/zen_mode.js

@@ -34,8 +34,8 @@ window.Dropzone = Dropzone;
 // **Cancelable** No
 // **Target** a.js-zen-leave
 //
-(function() {
+
-  this.ZenMode = (function() {
+window.ZenMode = (function() {
   function ZenMode() {
     this.active_backdrop = null;
     this.active_textarea = null;
@@ -94,5 +94,4 @@ window.Dropzone = Dropzone;
   };
 
   return ZenMode;
-  })();
+})();
-}).call(window);