From c0716421fac7494bfad058f2608095687be49773 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matija=20=C4=8Cupi=C4=87?= Date: Fri, 28 Sep 2018 23:56:56 +0200 Subject: [PATCH] Refactor pipeline id ordering --- .../populate_external_pipeline_source_spec.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb b/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb index 1a1193fa1fa..05a95cb5ba4 100644 --- a/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb +++ b/spec/lib/gitlab/background_migration/populate_external_pipeline_source_spec.rb @@ -6,6 +6,7 @@ describe Gitlab::BackgroundMigration::PopulateExternalPipelineSource, :migration let(:migration) { described_class.new } let!(:internal_pipeline) { create(:ci_pipeline, source: :web) } + let(:pipelines) { [internal_pipeline, external_pipeline, second_external_pipeline].map(&:id) } let!(:external_pipeline) do build(:ci_pipeline, source: :unknown) @@ -21,7 +22,7 @@ describe Gitlab::BackgroundMigration::PopulateExternalPipelineSource, :migration create(:ci_build, pipeline: internal_pipeline) end - subject { migration.perform(external_pipeline.id, second_external_pipeline.id) } + subject { migration.perform(pipelines.min, pipelines.max) } it 'populates the pipeline source' do subject