Remove param from CommitRange#to_s
This commit is contained in:
parent
81a21e5796
commit
c11d3c5789
2 changed files with 6 additions and 22 deletions
|
@ -67,12 +67,8 @@ class CommitRange
|
|||
end
|
||||
end
|
||||
|
||||
def to_s(short: true)
|
||||
if short
|
||||
"#{sha_from[0..7]}#{notation}#{sha_to[0..7]}"
|
||||
else
|
||||
"#{sha_from}#{notation}#{sha_to}"
|
||||
end
|
||||
def to_s
|
||||
"#{sha_from[0..7]}#{notation}#{sha_to[0..7]}"
|
||||
end
|
||||
|
||||
# Returns a String for use in a link's title attribute
|
||||
|
|
|
@ -39,24 +39,12 @@ describe CommitRange do
|
|||
end
|
||||
|
||||
describe '#to_s' do
|
||||
context 'with short IDs' do
|
||||
it 'is correct for three-dot syntax' do
|
||||
expect(range.to_s).to eq "#{sha_from[0..7]}...#{sha_to[0..7]}"
|
||||
end
|
||||
|
||||
it 'is correct for two-dot syntax' do
|
||||
expect(range2.to_s).to eq "#{sha_from[0..7]}..#{sha_to[0..7]}"
|
||||
end
|
||||
it 'is correct for three-dot syntax' do
|
||||
expect(range.to_s).to eq "#{sha_from[0..7]}...#{sha_to[0..7]}"
|
||||
end
|
||||
|
||||
context 'with full IDs' do
|
||||
it 'is correct for three-dot syntax' do
|
||||
expect(range.to_s(short: false)).to eq "#{sha_from}...#{sha_to}"
|
||||
end
|
||||
|
||||
it 'is correct for two-dot syntax' do
|
||||
expect(range2.to_s(short: false)).to eq "#{sha_from}..#{sha_to}"
|
||||
end
|
||||
it 'is correct for two-dot syntax' do
|
||||
expect(range2.to_s).to eq "#{sha_from[0..7]}..#{sha_to[0..7]}"
|
||||
end
|
||||
end
|
||||
|
||||
|
|
Loading…
Reference in a new issue