Improvements to user organization field feature after code review
* Add newline to user organization spec according to test guide * Remove unnecessary comments from user organization database migration Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
This commit is contained in:
parent
d0b556eb1b
commit
c17383a730
2 changed files with 1 additions and 17 deletions
|
@ -4,25 +4,8 @@
|
|||
class AddOrganizationToUser < ActiveRecord::Migration
|
||||
include Gitlab::Database::MigrationHelpers
|
||||
|
||||
# Set this constant to true if this migration requires downtime.
|
||||
DOWNTIME = false
|
||||
|
||||
# When a migration requires downtime you **must** uncomment the following
|
||||
# constant and define a short and easy to understand explanation as to why the
|
||||
# migration requires downtime.
|
||||
# DOWNTIME_REASON = ''
|
||||
|
||||
# When using the methods "add_concurrent_index" or "add_column_with_default"
|
||||
# you must disable the use of transactions as these methods can not run in an
|
||||
# existing transaction. When using "add_concurrent_index" make sure that this
|
||||
# method is the _only_ method called in the migration, any other changes
|
||||
# should go in a separate migration. This ensures that upon failure _only_ the
|
||||
# index creation fails and can be retried or reverted easily.
|
||||
#
|
||||
# To disable transactions uncomment the following line and remove these
|
||||
# comments:
|
||||
# disable_ddl_transaction!
|
||||
|
||||
def change
|
||||
add_column :users, :organization, :string
|
||||
end
|
||||
|
|
|
@ -267,6 +267,7 @@ describe API::API, api: true do
|
|||
|
||||
it "updates user with organization" do
|
||||
put api("/users/#{user.id}", admin), { organization: 'GitLab' }
|
||||
|
||||
expect(response).to have_http_status(200)
|
||||
expect(json_response['organization']).to eq('GitLab')
|
||||
expect(user.reload.organization).to eq('GitLab')
|
||||
|
|
Loading…
Reference in a new issue