From c1f785fe21ee785618ef3bf0407fee166b6e0ecd Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 6 Jul 2022 12:08:36 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitpod.yml | 8 +- .../logs/components/log_control_buttons.vue | 95 ------- .../logs/components/log_simple_filters.vue | 68 ----- .../tokens/token_with_loading_state.vue | 30 -- .../javascripts/logs/stores/mutation_types.js | 26 -- .../javascripts/logs/stores/mutations.js | 110 -------- app/assets/javascripts/logs/stores/state.js | 56 ---- .../settings/group/bundle.js | 2 - .../components/dependency_proxy_settings.vue | 9 +- .../group/components/packages_settings.vue | 9 +- .../shared/components/settings_block.vue | 17 ++ app/assets/stylesheets/pages/settings.scss | 1 + app/models/concerns/ci/artifactable.rb | 2 + .../_cloud_provider_button.html.haml | 7 +- .../_cloud_provider_selector.html.haml | 10 +- .../packages_and_registries/show.html.haml | 3 +- config/initializers/0_log_deprecations.rb | 14 +- doc/administration/sidekiq.md | 113 ++++++-- .../graphql/pagination/keyset/connection.rb | 2 +- lib/gitlab/pagination/keyset/order.rb | 4 +- locale/gitlab.pot | 17 +- scripts/pipeline_test_report_builder.rb | 7 +- .../settings/packages_and_registries_spec.rb | 1 - .../components/log_control_buttons_spec.js | 88 ------ .../tokens/token_with_loading_state_spec.js | 71 ----- spec/frontend/logs/mock_data.js | 71 ----- spec/frontend/logs/stores/mutations_spec.js | 257 ------------------ .../dependency_proxy_settings_spec.js | 7 - .../components/group_settings_app_spec.js | 1 - .../group/components/package_settings_spec.js | 7 - .../shared/components/settings_block_spec.js | 43 +++ .../releases/__snapshots__/util_spec.js.snap | 4 +- spec/initializers/0_log_deprecations_spec.rb | 11 +- .../keyset/connection_generic_keyset_spec.rb | 2 +- .../pagination/keyset/connection_spec.rb | 6 +- spec/models/concerns/ci/artifactable_spec.rb | 9 + .../pipeline_test_report_builder_spec.rb | 48 +++- 37 files changed, 269 insertions(+), 967 deletions(-) delete mode 100644 app/assets/javascripts/logs/components/log_control_buttons.vue delete mode 100644 app/assets/javascripts/logs/components/log_simple_filters.vue delete mode 100644 app/assets/javascripts/logs/components/tokens/token_with_loading_state.vue delete mode 100644 app/assets/javascripts/logs/stores/mutation_types.js delete mode 100644 app/assets/javascripts/logs/stores/mutations.js delete mode 100644 app/assets/javascripts/logs/stores/state.js create mode 100644 app/assets/javascripts/packages_and_registries/shared/components/settings_block.vue delete mode 100644 spec/frontend/logs/components/log_control_buttons_spec.js delete mode 100644 spec/frontend/logs/components/tokens/token_with_loading_state_spec.js delete mode 100644 spec/frontend/logs/mock_data.js delete mode 100644 spec/frontend/logs/stores/mutations_spec.js create mode 100644 spec/frontend/packages_and_registries/shared/components/settings_block_spec.js diff --git a/.gitpod.yml b/.gitpod.yml index 07cc7f2ecb6..3fb623b9fb6 100644 --- a/.gitpod.yml +++ b/.gitpod.yml @@ -5,6 +5,7 @@ tasks: - name: GDK command: | echo START_TIME_IN_SECONDS="$(date +%s)" | tee /workspace/gitpod_start_time.sh + gp sync-done gitpod-start gp sync-await gdk-copied && cd /workspace/gitlab-development-kit && gdk help - init: | @@ -35,9 +36,10 @@ tasks: ) command: | ( + gp sync-await gitpod-start set -e gp sync-done gdk-copied - source /workspace/gitpod_start_time.sh + [[ -f /workspace/gitpod_start_time.sh ]] && source /workspace/gitpod_start_time.sh SECONDS=0 cd /workspace/gitlab-development-kit # update GDK @@ -72,7 +74,7 @@ tasks: git checkout db/structure.sql cd /workspace/gitlab-development-kit # Waiting for GitLab ... - gp await-port 3000 + gp ports await 3000 printf "Waiting for GitLab at $(gp url 3000) ..." # Check /-/readiness which returns JSON, but we're only interested in the exit code # @@ -84,7 +86,7 @@ tasks: printf "$(date) – GitLab is up (took ~%.1f minutes)\n" "$((10*$SECONDS/60))e-1" | tee -a /workspace/startup.log gp preview $(gp url 3000) || true PREBUILD_LOG=(/workspace/.gitpod/prebuild-log-*) - printf "Took %.1f minutes from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitpod.yml being executed through to completion %s\n" "$((10*(($(date +%s)-${START_TIME_IN_SECONDS}))/60))e-1" "$([[ -f "$PREBUILD_LOG" ]] && echo "With Prebuilds")" + [[ -f /workspace/gitpod_start_time.sh ]] && printf "Took %.1f minutes from https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitpod.yml being executed through to completion %s\n" "$((10*(($(date +%s)-${START_TIME_IN_SECONDS}))/60))e-1" "$([[ -f "$PREBUILD_LOG" ]] && echo "With Prebuilds")" ) ports: diff --git a/app/assets/javascripts/logs/components/log_control_buttons.vue b/app/assets/javascripts/logs/components/log_control_buttons.vue deleted file mode 100644 index e44b5394fa1..00000000000 --- a/app/assets/javascripts/logs/components/log_control_buttons.vue +++ /dev/null @@ -1,95 +0,0 @@ - - - diff --git a/app/assets/javascripts/logs/components/log_simple_filters.vue b/app/assets/javascripts/logs/components/log_simple_filters.vue deleted file mode 100644 index 55bdd5f0088..00000000000 --- a/app/assets/javascripts/logs/components/log_simple_filters.vue +++ /dev/null @@ -1,68 +0,0 @@ - - diff --git a/app/assets/javascripts/logs/components/tokens/token_with_loading_state.vue b/app/assets/javascripts/logs/components/tokens/token_with_loading_state.vue deleted file mode 100644 index 4e672c1d121..00000000000 --- a/app/assets/javascripts/logs/components/tokens/token_with_loading_state.vue +++ /dev/null @@ -1,30 +0,0 @@ - - - diff --git a/app/assets/javascripts/logs/stores/mutation_types.js b/app/assets/javascripts/logs/stores/mutation_types.js deleted file mode 100644 index c1ed65ff48b..00000000000 --- a/app/assets/javascripts/logs/stores/mutation_types.js +++ /dev/null @@ -1,26 +0,0 @@ -export const SET_PROJECT_ENVIRONMENT = 'SET_PROJECT_ENVIRONMENT'; -export const SET_SEARCH = 'SET_SEARCH'; -export const SET_MANAGED_APP = 'SET_MANAGED_APP'; - -export const SET_TIME_RANGE = 'SET_TIME_RANGE'; -export const SHOW_TIME_RANGE_INVALID_WARNING = 'SHOW_TIME_RANGE_INVALID_WARNING'; -export const HIDE_TIME_RANGE_INVALID_WARNING = 'HIDE_TIME_RANGE_INVALID_WARNING'; - -export const SET_CURRENT_POD_NAME = 'SET_CURRENT_POD_NAME'; - -export const REQUEST_ENVIRONMENTS_DATA = 'REQUEST_ENVIRONMENTS_DATA'; -export const RECEIVE_ENVIRONMENTS_DATA_SUCCESS = 'RECEIVE_ENVIRONMENTS_DATA_SUCCESS'; -export const RECEIVE_ENVIRONMENTS_DATA_ERROR = 'RECEIVE_ENVIRONMENTS_DATA_ERROR'; -export const HIDE_REQUEST_ENVIRONMENTS_ERROR = 'HIDE_REQUEST_ENVIRONMENTS_ERROR'; - -export const REQUEST_LOGS_DATA = 'REQUEST_LOGS_DATA'; -export const RECEIVE_LOGS_DATA_SUCCESS = 'RECEIVE_LOGS_DATA_SUCCESS'; -export const RECEIVE_LOGS_DATA_ERROR = 'RECEIVE_LOGS_DATA_ERROR'; -export const REQUEST_LOGS_DATA_PREPEND = 'REQUEST_LOGS_DATA_PREPEND'; -export const RECEIVE_LOGS_DATA_PREPEND_SUCCESS = 'RECEIVE_LOGS_DATA_PREPEND_SUCCESS'; -export const RECEIVE_LOGS_DATA_PREPEND_ERROR = 'RECEIVE_LOGS_DATA_PREPEND_ERROR'; -export const HIDE_REQUEST_LOGS_ERROR = 'HIDE_REQUEST_LOGS_ERROR'; -export const REFRESH_POD_LOGS = 'REFRESH_POD_LOGS'; - -export const RECEIVE_PODS_DATA_SUCCESS = 'RECEIVE_PODS_DATA_SUCCESS'; -export const RECEIVE_PODS_DATA_ERROR = 'RECEIVE_PODS_DATA_ERROR'; diff --git a/app/assets/javascripts/logs/stores/mutations.js b/app/assets/javascripts/logs/stores/mutations.js deleted file mode 100644 index 6736d7204b4..00000000000 --- a/app/assets/javascripts/logs/stores/mutations.js +++ /dev/null @@ -1,110 +0,0 @@ -import { convertToFixedRange } from '~/lib/utils/datetime_range'; -import * as types from './mutation_types'; - -const mapLine = ({ timestamp, pod, message }) => ({ - timestamp, - pod, - message, -}); - -export default { - // Search Data - [types.SET_SEARCH](state, searchQuery) { - state.search = searchQuery; - }, - - // Time Range Data - [types.SET_TIME_RANGE](state, timeRange) { - state.timeRange.selected = timeRange; - state.timeRange.current = convertToFixedRange(timeRange); - }, - [types.SHOW_TIME_RANGE_INVALID_WARNING](state) { - state.timeRange.invalidWarning = true; - }, - [types.HIDE_TIME_RANGE_INVALID_WARNING](state) { - state.timeRange.invalidWarning = false; - }, - - // Environments Data - [types.SET_PROJECT_ENVIRONMENT](state, environmentName) { - state.environments.current = environmentName; - - // Clear current pod options - state.pods.current = null; - state.pods.options = []; - }, - [types.REQUEST_ENVIRONMENTS_DATA](state) { - state.environments.options = []; - state.environments.isLoading = true; - }, - [types.RECEIVE_ENVIRONMENTS_DATA_SUCCESS](state, environmentOptions) { - state.environments.options = environmentOptions; - state.environments.isLoading = false; - }, - [types.RECEIVE_ENVIRONMENTS_DATA_ERROR](state) { - state.environments.options = []; - state.environments.isLoading = false; - state.environments.fetchError = true; - }, - [types.HIDE_REQUEST_ENVIRONMENTS_ERROR](state) { - state.environments.fetchError = false; - }, - - // Logs data - [types.REQUEST_LOGS_DATA](state) { - state.timeRange.current = convertToFixedRange(state.timeRange.selected); - - state.logs.lines = []; - state.logs.isLoading = true; - - // start pagination from the beginning - state.logs.cursor = null; - state.logs.isComplete = false; - }, - [types.RECEIVE_LOGS_DATA_SUCCESS](state, { logs = [], cursor }) { - state.logs.lines = logs.map(mapLine); - state.logs.isLoading = false; - state.logs.cursor = cursor; - - if (!cursor) { - state.logs.isComplete = true; - } - }, - [types.RECEIVE_LOGS_DATA_ERROR](state) { - state.logs.lines = []; - state.logs.isLoading = false; - state.logs.fetchError = true; - }, - - [types.REQUEST_LOGS_DATA_PREPEND](state) { - state.logs.isLoading = true; - }, - [types.RECEIVE_LOGS_DATA_PREPEND_SUCCESS](state, { logs = [], cursor }) { - const lines = logs.map(mapLine); - state.logs.lines = lines.concat(state.logs.lines); - state.logs.isLoading = false; - state.logs.cursor = cursor; - - if (!cursor) { - state.logs.isComplete = true; - } - }, - [types.RECEIVE_LOGS_DATA_PREPEND_ERROR](state) { - state.logs.isLoading = false; - state.logs.fetchError = true; - }, - [types.HIDE_REQUEST_LOGS_ERROR](state) { - state.logs.fetchError = false; - }, - - // Pods data - [types.SET_CURRENT_POD_NAME](state, podName) { - state.pods.current = podName; - }, - [types.RECEIVE_PODS_DATA_SUCCESS](state, podOptions) { - state.pods.options = podOptions; - }, - [types.RECEIVE_PODS_DATA_ERROR](state) { - state.pods.options = []; - }, -}; diff --git a/app/assets/javascripts/logs/stores/state.js b/app/assets/javascripts/logs/stores/state.js deleted file mode 100644 index ee17e8ecef2..00000000000 --- a/app/assets/javascripts/logs/stores/state.js +++ /dev/null @@ -1,56 +0,0 @@ -import { convertToFixedRange } from '~/lib/utils/datetime_range'; -import { timeRanges, defaultTimeRange } from '~/vue_shared/constants'; - -export default () => ({ - /** - * Full text search - */ - search: '', - - /** - * Time range (Show last) - */ - timeRange: { - options: timeRanges, - // Selected time range, can be fixed or relative - selected: defaultTimeRange, - // Current time range, must be fixed - current: convertToFixedRange(defaultTimeRange), - - invalidWarning: false, - }, - - /** - * Environments list information - */ - environments: { - options: [], - isLoading: false, - current: null, - fetchError: false, - }, - - /** - * Jobs with logs - */ - logs: { - lines: [], - isLoading: false, - /** - * Logs `cursor` represents the current pagination position, - * Should be sent in next batch (page) of logs to be fetched - */ - cursor: null, - isComplete: false, - - fetchError: false, - }, - - /** - * Pods list information - */ - pods: { - options: [], - current: null, - }, -}); diff --git a/app/assets/javascripts/packages_and_registries/settings/group/bundle.js b/app/assets/javascripts/packages_and_registries/settings/group/bundle.js index 482a3ef2ead..3689199751d 100644 --- a/app/assets/javascripts/packages_and_registries/settings/group/bundle.js +++ b/app/assets/javascripts/packages_and_registries/settings/group/bundle.js @@ -1,7 +1,6 @@ import { GlToast } from '@gitlab/ui'; import Vue from 'vue'; -import { parseBoolean } from '~/lib/utils/common_utils'; import Translate from '~/vue_shared/translate'; import SettingsApp from './components/group_settings_app.vue'; import { apolloProvider } from './graphql'; @@ -20,7 +19,6 @@ export default () => { provide: { groupPath: el.dataset.groupPath, groupDependencyProxyPath: el.dataset.groupDependencyProxyPath, - defaultExpanded: parseBoolean(el.dataset.defaultExpanded), }, render(createElement) { return createElement(SettingsApp); diff --git a/app/assets/javascripts/packages_and_registries/settings/group/components/dependency_proxy_settings.vue b/app/assets/javascripts/packages_and_registries/settings/group/components/dependency_proxy_settings.vue index 4c17b555d1b..59d4f5e24d0 100644 --- a/app/assets/javascripts/packages_and_registries/settings/group/components/dependency_proxy_settings.vue +++ b/app/assets/javascripts/packages_and_registries/settings/group/components/dependency_proxy_settings.vue @@ -1,7 +1,7 @@