From c21e817a9081e01bdbf27f4a28bdb7af791a7e8a Mon Sep 17 00:00:00 2001
From: Tomasz Maczukin
Date: Wed, 21 Feb 2018 05:28:31 +0100
Subject: [PATCH] Add link to timeout overriding documentation from job page
sidebar
---
.../jobs/components/sidebar_detail_row.vue | 20 +++++++++++++++++++
.../jobs/components/sidebar_details_block.vue | 1 +
2 files changed, 21 insertions(+)
diff --git a/app/assets/javascripts/jobs/components/sidebar_detail_row.vue b/app/assets/javascripts/jobs/components/sidebar_detail_row.vue
index a6819aaeb12..a24a0c5e779 100644
--- a/app/assets/javascripts/jobs/components/sidebar_detail_row.vue
+++ b/app/assets/javascripts/jobs/components/sidebar_detail_row.vue
@@ -11,11 +11,19 @@
type: String,
required: true,
},
+ helpUrl: {
+ type: String,
+ required: false,
+ default: '',
+ },
},
computed: {
hasTitle() {
return this.title.length > 0;
},
+ hasHelpURL() {
+ return this.helpUrl.length > 0;
+ },
},
};
@@ -28,5 +36,17 @@
{{ title }}:
{{ value }}
+
+
+
+
+
+
diff --git a/app/assets/javascripts/jobs/components/sidebar_details_block.vue b/app/assets/javascripts/jobs/components/sidebar_details_block.vue
index 94c2084623b..c979e11b469 100644
--- a/app/assets/javascripts/jobs/components/sidebar_details_block.vue
+++ b/app/assets/javascripts/jobs/components/sidebar_details_block.vue
@@ -127,6 +127,7 @@
class="js-job-timeout"
v-if="job.timeout"
title="Timeout"
+ help-url="/help/ci/runners/README.html#setting-maximum-job-timeout-for-a-runner"
:value="timeout"
/>