From c287c01821c4db4830dbdd5263907f08c2ed4cc4 Mon Sep 17 00:00:00 2001
From: Clement Ho <ClemMakesApps@gmail.com>
Date: Tue, 27 Feb 2018 16:28:17 -0600
Subject: [PATCH] Remove unnecessary element checks

---
 .../pipelines/pipeline_details_bundle.js      | 110 +++++++++---------
 1 file changed, 52 insertions(+), 58 deletions(-)

diff --git a/app/assets/javascripts/pipelines/pipeline_details_bundle.js b/app/assets/javascripts/pipelines/pipeline_details_bundle.js
index 1119a65e5be..6b26708148c 100644
--- a/app/assets/javascripts/pipelines/pipeline_details_bundle.js
+++ b/app/assets/javascripts/pipelines/pipeline_details_bundle.js
@@ -16,64 +16,58 @@ export default () => {
 
   mediator.fetchPipeline();
 
-  const pipelineGraphEl = document.querySelector('#js-pipeline-graph-vue');
-  if (pipelineGraphEl) {
-    // eslint-disable-next-line
-    new Vue({
-      el: pipelineGraphEl,
-      components: {
-        pipelineGraph,
-      },
-      data() {
-        return {
-          mediator,
-        };
-      },
-      render(createElement) {
-        return createElement('pipeline-graph', {
-          props: {
-            isLoading: this.mediator.state.isLoading,
-            pipeline: this.mediator.store.state.pipeline,
-          },
-        });
-      },
-    });
-  }
-
-  const pipelineHeaderEl = document.querySelector('#js-pipeline-header-vue');
-  if (pipelineHeaderEl) {
-    // eslint-disable-next-line
-    new Vue({
-      el: pipelineHeaderEl,
-      components: {
-        pipelineHeader,
-      },
-      data() {
-        return {
-          mediator,
-        };
-      },
-      created() {
-        eventHub.$on('headerPostAction', this.postAction);
-      },
-      beforeDestroy() {
-        eventHub.$off('headerPostAction', this.postAction);
-      },
-      methods: {
-        postAction(action) {
-          this.mediator.service.postAction(action.path)
-            .then(() => this.mediator.refreshPipeline())
-            .catch(() => Flash(__('An error occurred while making the request.')));
+  // eslint-disable-next-line
+  new Vue({
+    el: '#js-pipeline-graph-vue',
+    components: {
+      pipelineGraph,
+    },
+    data() {
+      return {
+        mediator,
+      };
+    },
+    render(createElement) {
+      return createElement('pipeline-graph', {
+        props: {
+          isLoading: this.mediator.state.isLoading,
+          pipeline: this.mediator.store.state.pipeline,
         },
+      });
+    },
+  });
+
+  // eslint-disable-next-line
+  new Vue({
+    el: '#js-pipeline-header-vue',
+    components: {
+      pipelineHeader,
+    },
+    data() {
+      return {
+        mediator,
+      };
+    },
+    created() {
+      eventHub.$on('headerPostAction', this.postAction);
+    },
+    beforeDestroy() {
+      eventHub.$off('headerPostAction', this.postAction);
+    },
+    methods: {
+      postAction(action) {
+        this.mediator.service.postAction(action.path)
+          .then(() => this.mediator.refreshPipeline())
+          .catch(() => Flash(__('An error occurred while making the request.')));
       },
-      render(createElement) {
-        return createElement('pipeline-header', {
-          props: {
-            isLoading: this.mediator.state.isLoading,
-            pipeline: this.mediator.store.state.pipeline,
-          },
-        });
-      },
-    });
-  }
+    },
+    render(createElement) {
+      return createElement('pipeline-header', {
+        props: {
+          isLoading: this.mediator.state.isLoading,
+          pipeline: this.mediator.store.state.pipeline,
+        },
+      });
+    },
+  });
 };