kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add be_like_time matcher to Testing Styleguide

Browse source
This commit is contained in:
Luke Duncalfe 2019-08-15 16:56:04 +12:00
parent 7c9fb3c617
commit c2c86e3514
1 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
doc/development/testing_guide/best_practices.md
View file

@ -454,6 +454,19 @@ complexity of RSpec expectations.They should be placed under
a certain type of specs only (e.g. features, requests etc.) but shouldn't be if a certain type of specs only (e.g. features, requests etc.) but shouldn't be if
they apply to multiple type of specs. they apply to multiple type of specs.
#### `be_like_time`
Time returned from a database can differ in precision from time objects
in Ruby, so we need flexible tolerances when comparing in specs. We can
use `be_like_time` to compare that times are within one second of each
other.
Example:
```ruby
expect(metrics.merged_at).to be_like_time(time)
```
#### `have_gitlab_http_status` #### `have_gitlab_http_status`
Prefer `have_gitlab_http_status` over `have_http_status` because the former Prefer `have_gitlab_http_status` over `have_http_status` because the former