From c3c22cb210dd1545b1a4ef500643480836245bae Mon Sep 17 00:00:00 2001 From: Thong Kuah Date: Tue, 16 Oct 2018 21:05:04 +1300 Subject: [PATCH] Move shared examples into the only file where used This will make it easier to perform in place adjustments, etc for future MRs involving group clusters. --- spec/services/clusters/create_service_spec.rb | 109 +++++++++++++++--- .../clusters/create_service_shared.rb | 59 ---------- 2 files changed, 90 insertions(+), 78 deletions(-) delete mode 100644 spec/support/services/clusters/create_service_shared.rb diff --git a/spec/services/clusters/create_service_spec.rb b/spec/services/clusters/create_service_spec.rb index 3959295c13e..5373ad7f4b2 100644 --- a/spec/services/clusters/create_service_spec.rb +++ b/spec/services/clusters/create_service_spec.rb @@ -2,33 +2,104 @@ require 'spec_helper' describe Clusters::CreateService do let(:access_token) { 'xxx' } - let(:project) { create(:project) } let(:user) { create(:user) } + let(:service) { described_class.new(user, params) } - subject { described_class.new(user, params).execute(project: project, access_token: access_token) } + describe '#execute' do + before do + allow(ClusterProvisionWorker).to receive(:perform_async) + end - context 'when provider is gcp' do - context 'when project has no clusters' do - context 'when correct params' do - include_context 'valid cluster create params' - - include_examples 'create cluster service success' - end - - context 'when invalid params' do - include_context 'invalid cluster create params' - - include_examples 'create cluster service error' + shared_context 'valid cluster create params' do + let(:params) do + { + name: 'test-cluster', + provider_type: :gcp, + provider_gcp_attributes: { + gcp_project_id: 'gcp-project', + zone: 'us-central1-a', + num_nodes: 1, + machine_type: 'machine_type-a', + legacy_abac: 'true' + } + } end end - context 'when project has a cluster' do - include_context 'valid cluster create params' - let!(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, projects: [project]) } + shared_context 'invalid cluster create params' do + let(:params) do + { + name: 'test-cluster', + provider_type: :gcp, + provider_gcp_attributes: { + gcp_project_id: '!!!!!!!', + zone: 'us-central1-a', + num_nodes: 1, + machine_type: 'machine_type-a' + } + } + end + end - it 'does not create a cluster' do + shared_examples 'create cluster service success' do + it 'creates a cluster object and performs a worker' do + expect(ClusterProvisionWorker).to receive(:perform_async) + + expect { subject } + .to change { Clusters::Cluster.count }.by(1) + .and change { Clusters::Providers::Gcp.count }.by(1) + + expect(subject.name).to eq('test-cluster') + expect(subject.user).to eq(user) + expect(subject.provider.gcp_project_id).to eq('gcp-project') + expect(subject.provider.zone).to eq('us-central1-a') + expect(subject.provider.num_nodes).to eq(1) + expect(subject.provider.machine_type).to eq('machine_type-a') + expect(subject.provider.access_token).to eq(access_token) + expect(subject.provider).to be_legacy_abac + expect(subject.platform).to be_nil + end + end + + shared_examples 'create cluster service error' do + it 'returns an error' do expect(ClusterProvisionWorker).not_to receive(:perform_async) - expect { subject }.to raise_error(ArgumentError).and change { Clusters::Cluster.count }.by(0) + expect { subject }.to change { Clusters::Cluster.count }.by(0) + expect(subject.errors[:"provider_gcp.gcp_project_id"]).to be_present + end + end + + context 'create cluster for project' do + let(:project) { create(:project) } + + subject { service.execute(project: project, access_token: access_token) } + + context 'when project has no clusters' do + context 'when correct params' do + include_context 'valid cluster create params' + + include_examples 'create cluster service success' + + it 'associates project to the cluster' do + expect(subject.project).to eq(project) + end + end + + context 'when invalid params' do + include_context 'invalid cluster create params' + + include_examples 'create cluster service error' + end + end + + context 'when project has a cluster' do + include_context 'valid cluster create params' + let!(:cluster) { create(:cluster, :provided_by_gcp, :production_environment, projects: [project]) } + + it 'does not create a cluster' do + expect(ClusterProvisionWorker).not_to receive(:perform_async) + expect { subject }.to raise_error(ArgumentError).and change { Clusters::Cluster.count }.by(0) + end end end end diff --git a/spec/support/services/clusters/create_service_shared.rb b/spec/support/services/clusters/create_service_shared.rb deleted file mode 100644 index b0bf942aa09..00000000000 --- a/spec/support/services/clusters/create_service_shared.rb +++ /dev/null @@ -1,59 +0,0 @@ -shared_context 'valid cluster create params' do - let(:params) do - { - name: 'test-cluster', - provider_type: :gcp, - provider_gcp_attributes: { - gcp_project_id: 'gcp-project', - zone: 'us-central1-a', - num_nodes: 1, - machine_type: 'machine_type-a', - legacy_abac: 'true' - } - } - end -end - -shared_context 'invalid cluster create params' do - let(:params) do - { - name: 'test-cluster', - provider_type: :gcp, - provider_gcp_attributes: { - gcp_project_id: '!!!!!!!', - zone: 'us-central1-a', - num_nodes: 1, - machine_type: 'machine_type-a' - } - } - end -end - -shared_examples 'create cluster service success' do - it 'creates a cluster object and performs a worker' do - expect(ClusterProvisionWorker).to receive(:perform_async) - - expect { subject } - .to change { Clusters::Cluster.count }.by(1) - .and change { Clusters::Providers::Gcp.count }.by(1) - - expect(subject.name).to eq('test-cluster') - expect(subject.user).to eq(user) - expect(subject.project).to eq(project) - expect(subject.provider.gcp_project_id).to eq('gcp-project') - expect(subject.provider.zone).to eq('us-central1-a') - expect(subject.provider.num_nodes).to eq(1) - expect(subject.provider.machine_type).to eq('machine_type-a') - expect(subject.provider.access_token).to eq(access_token) - expect(subject.provider).to be_legacy_abac - expect(subject.platform).to be_nil - end -end - -shared_examples 'create cluster service error' do - it 'returns an error' do - expect(ClusterProvisionWorker).not_to receive(:perform_async) - expect { subject }.to change { Clusters::Cluster.count }.by(0) - expect(subject.errors[:"provider_gcp.gcp_project_id"]).to be_present - end -end