kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Pushing to see how this tests behaves

Browse source
This commit is contained in:
Francisco Lopez 2017-11-07 11:58:10 +01:00
parent d948e67913
commit c491b9505a
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
spec/requests/rack_attack_global_spec.rb
View file

@ -91,7 +91,7 @@ describe 'Rack Attack global throttles' do
expect_rejection { get(*get_args) }
Timecop.travel((NEXT_TIME_PERIOD_BUFFER + period).from_now) do
Timecop.travel(period.from_now) do
requests_per_period.times do
get(*get_args)
expect(response).to have_http_status 200
@ -171,7 +171,7 @@ describe 'Rack Attack global throttles' do
expect_rejection { get url_that_does_not_require_authentication }
Timecop.travel((NEXT_TIME_PERIOD_BUFFER + period).from_now) do
Timecop.travel(period.from_now) do
requests_per_period.times do
get url_that_does_not_require_authentication
expect(response).to have_http_status 200
@ -334,7 +334,7 @@ describe 'Rack Attack global throttles' do
expect_rejection { get url_that_requires_authentication }
Timecop.travel((NEXT_TIME_PERIOD_BUFFER + period).from_now) do
Timecop.travel(period.from_now) do
requests_per_period.times do
get url_that_requires_authentication
expect(response).to have_http_status 200
@ -405,11 +405,11 @@ describe 'Rack Attack global throttles' do
end
def expect_rejection(&block)
NUM_TRIES_FOR_REJECTION.times do |i|
# NUM_TRIES_FOR_REJECTION.times do |i|
yield
break if response.status == 429 # success
Rails.logger.warn "Flaky test expected HTTP status 429 but got #{response.status}. Will attempt again (#{i + 1}/#{NUM_TRIES_FOR_REJECTION})" if i + 1 < NUM_TRIES_FOR_REJECTION
end
# break if response.status == 429 # success
# Rails.logger.warn "Flaky test expected HTTP status 429 but got #{response.status}. Will attempt again (#{i + 1}/#{NUM_TRIES_FOR_REJECTION})" if i + 1 < NUM_TRIES_FOR_REJECTION
# end
expect(response).to have_http_status(429)
end