Fix remaining offenses

This commit is contained in:
Kamil Trzcinski 2016-10-18 13:51:12 +02:00
parent ad85928752
commit c4e45d89d4
2 changed files with 5 additions and 4 deletions

View file

@ -32,7 +32,7 @@ feature 'Widget Deployments Header', feature: true, js: true do
given(:manual) { create(:ci_build, :manual, pipeline: pipeline, name: 'close_app') }
given(:deployment) do
create(:deployment, environment: environment, ref: merge_request.target_branch,
sha: sha, deployable: build, on_stop: 'close_app')
sha: sha, deployable: build, on_stop: 'close_app')
end
background do

View file

@ -150,8 +150,8 @@ describe Environment, models: true do
let!(:close_action) { create(:ci_build, :manual, pipeline: build.pipeline, name: 'close_app') }
it 'returns the same action' do
is_expected.to eq(close_action)
is_expected.to include(user: user)
expect(subject).to eq(close_action)
expect(subject.user).to eq(user)
end
end
@ -160,7 +160,8 @@ describe Environment, models: true do
it 'returns a new action of the same type' do
is_expected.to be_persisted
is_expected.to include(name: close_action.name, user: user)
expect(subject.name).to eq(close_action.name)
expect(subject.user).to eq(user)
end
end
end