kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix code examples and add code highligth

This commit is contained in:
Filipa Lacerda 2017-03-10 23:15:18 +00:00
parent 6b1b616ea9
commit c508335719
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
doc/development/frontend.md
View File

@ -291,7 +291,7 @@ When exactly one object is needed for a given task, prefer to define it as a
`class` rather than as an object literal. Prefer also to explicitly restrict `class` rather than as an object literal. Prefer also to explicitly restrict
instantiation, unless flexibility is important (e.g. for testing). instantiation, unless flexibility is important (e.g. for testing).
``` ```javascript
// bad // bad
gl.MyThing = { gl.MyThing = {
@ -340,21 +340,20 @@ When writing a class that needs to manipulate the DOM guarantee a container opti
This is useful when we need that class to be instantiated more than once in the same page. This is useful when we need that class to be instantiated more than once in the same page.
Bad: Bad:
``` ```javascript
class Foo { class Foo {
constructor() { constructor() {
document.querySelector('.bar'); document.querySelector('.bar');
} }
} }
new Foo(); new Foo();
``` ```
Good: Good:
``` ```javascript
class Foo { class Foo {
constructor(opts) { constructor(opts) {
document.querySelector(opts.container); opts.container.querySelector('.bar');
} }
} }