kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Validate config form only when service is marked active

Browse source
This commit is contained in:
kushalpandya 2017-05-25 15:05:19 +05:30 committed by Jarka Kadlecova
parent 791e5024ef
commit c5e28a7b41
1 changed files with 15 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
app/assets/javascripts/integrations/integration_settings_form.js
View file

@ -22,7 +22,7 @@ export default class IntegrationSettingsForm {
init() {
// Initialize View
this.toggleSubmitBtnLabel(this.$serviceToggle.is(':checked'));
this.toggleServiceState(this.$serviceToggle.is(':checked'));
// Bind Event Listeners
this.$serviceToggle.on('change', this.handleServiceToggle);
@ -31,13 +31,24 @@ export default class IntegrationSettingsForm {
handleSettingsSave(e) {
if (this.$serviceToggle.is(':checked')) {
e.preventDefault();
this.testSettings(this.$form.serialize());
if (this.$form.get(0).checkValidity()) {
e.preventDefault();
this.testSettings(this.$form.serialize());
}
}
}
handleServiceToggle(e) {
this.toggleSubmitBtnLabel($(e.currentTarget).is(':checked'));
this.toggleServiceState($(e.currentTarget).is(':checked'));
}
toggleServiceState(serviceActive) {
this.toggleSubmitBtnLabel(serviceActive);
if (serviceActive) {
this.$form.removeAttr('novalidate');
} else if (!this.$form.attr('novalidate')) {
this.$form.attr('novalidate', 'novalidate');
}
}
/**