kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Add ! for verify_record! because it could raise

Browse source
This commit is contained in:
Lin Jen-Shin 2016-05-21 09:46:27 -07:00
parent 75415663f8
commit c64cd113cc
3 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/gitlab/email/handler/base_handler.rb
View file

@ -42,7 +42,7 @@ module Gitlab
end.join end.join
end end
def verify_record(record, exception, error_title) def verify_record!(record, exception, error_title)
return if record.persisted? return if record.persisted?
msg = error_title + record.errors.full_messages.map do |error| msg = error_title + record.errors.full_messages.map do |error|

2
lib/gitlab/email/handler/create_issue_handler.rb
View file

@ -12,7 +12,7 @@ module Gitlab
def execute def execute
validate_permission!(:create_issue) validate_permission!(:create_issue)
verify_record( verify_record!(
create_issue, create_issue,
InvalidIssueError, InvalidIssueError,
"The issue could not be created for the following reasons:" "The issue could not be created for the following reasons:"

2
lib/gitlab/email/handler/create_note_handler.rb
View file

@ -18,7 +18,7 @@ module Gitlab
raise NoteableNotFoundError unless sent_notification.noteable raise NoteableNotFoundError unless sent_notification.noteable
raise EmptyEmailError if message.blank? raise EmptyEmailError if message.blank?
verify_record( verify_record!(
create_note, create_note,
InvalidNoteError, InvalidNoteError,
"The comment could not be created for the following reasons:" "The comment could not be created for the following reasons:"