From c7a46b04196859929e8e4c04fbcbf8490f228edf Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 21 Aug 2020 00:10:44 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .markdownlint.json | 1 + .../javascripts/snippets/components/edit.vue | 2 +- .../javascripts/snippets/components/show.vue | 2 +- .../snippets/components/snippet_blob_edit.vue | 2 +- .../components/states/ready_to_merge.vue | 12 +- app/assets/stylesheets/framework/lists.scss | 6 +- app/assets/stylesheets/pages/members.scss | 4 - app/controllers/projects/forks_controller.rb | 13 +- app/finders/fork_targets_finder.rb | 6 +- app/graphql/gitlab_schema.rb | 4 +- .../metrics/dashboard/annotations/delete.rb | 2 +- app/graphql/types/jira_user_type.rb | 2 +- app/models/issue.rb | 27 +++ app/models/issue_link.rb | 38 ++++ app/models/system_note_metadata.rb | 3 +- app/serializers/fork_namespace_entity.rb | 6 +- app/serializers/linked_issue_entity.rb | 37 ++++ .../linked_project_issue_entity.rb | 29 +++ .../linked_project_issue_serializer.rb | 5 + app/services/issuable_links/create_service.rb | 115 +++++++++++ .../issuable_links/destroy_service.rb | 31 +++ app/services/issuable_links/list_service.rb | 27 +++ app/services/issue_links/create_service.rb | 42 ++++ app/services/issue_links/destroy_service.rb | 24 +++ app/services/issue_links/list_service.rb | 18 ++ app/services/issues/duplicate_service.rb | 9 +- app/services/issues/move_service.rb | 9 + app/services/projects/fork_service.rb | 4 +- .../quick_actions/interpret_service.rb | 1 + app/services/system_note_service.rb | 8 + .../system_notes/issuables_service.rb | 28 +++ app/views/admin/dashboard/index.html.haml | 4 +- app/views/shared/members/_member.html.haml | 2 +- ...forking-outside-a-group-is-extremely-s.yml | 5 + ...remove-upcoming-db-deprecation-warning.yml | 5 + config/routes/issues.rb | 2 + doc/administration/auth/cognito.md | 2 +- doc/administration/gitaly/index.md | 18 ++ .../troubleshooting/tracing_correlation_id.md | 2 +- doc/api/feature_flags.md | 4 +- doc/api/graphql/getting_started.md | 4 +- .../graphql/reference/gitlab_schema.graphql | 4 +- doc/api/graphql/reference/gitlab_schema.json | 4 +- doc/api/graphql/reference/index.md | 2 +- doc/api/services.md | 2 +- doc/ci/directed_acyclic_graph/index.md | 2 +- doc/ci/multi_project_pipelines.md | 3 +- .../documentation/feature_flags.md | 4 +- doc/development/elasticsearch.md | 2 +- doc/development/geo/framework.md | 2 +- doc/development/telemetry/snowplow.md | 2 +- doc/development/telemetry/usage_ping.md | 79 +++++-- doc/integration/salesforce.md | 2 +- doc/operations/feature_flags.md | 4 +- doc/operations/incident_management/alerts.md | 8 +- .../incident_management/generic_alerts.md | 125 +++++++++++ .../img/alert_list_v13_1.png | Bin doc/operations/incident_management/index.md | 2 +- doc/operations/metrics/alerts.md | 2 +- doc/operations/product_analytics.md | 4 +- doc/user/application_security/dast/index.md | 4 +- doc/user/group/iterations/index.md | 4 +- .../group/saml_sso/group_managed_accounts.md | 3 +- .../project/integrations/generic_alerts.md | 124 +---------- doc/user/project/integrations/overview.md | 2 +- doc/user/project/integrations/servicenow.md | 41 ++++ .../merge_requests/squash_and_merge.md | 4 +- .../external_database_checker.rb | 53 ++--- lib/gitlab/database.rb | 30 --- lib/gitlab/quick_actions/relate_actions.rb | 29 +++ locale/gitlab.pot | 10 +- spec/factories/issue_links.rb | 8 + spec/finders/fork_targets_finder_spec.rb | 8 + .../add_context_commits_modal_spec.js.snap | 2 +- .../discussions/toggle_resolve_spec.rb | 2 +- .../external_database_checker_spec.rb | 81 ++------ spec/lib/gitlab/database_spec.rb | 40 ---- spec/models/issue_link_spec.rb | 53 +++++ spec/models/issue_spec.rb | 44 ++++ .../dashboard/annotations/create_spec.rb | 4 +- .../dashboard/annotations/delete_spec.rb | 2 +- .../graphql/mutations/todos/mark_done_spec.rb | 2 +- .../graphql/mutations/todos/restore_spec.rb | 2 +- .../serializers/fork_namespace_entity_spec.rb | 9 +- .../linked_project_issue_entity_spec.rb | 23 +++ .../issue_links/create_service_spec.rb | 176 ++++++++++++++++ .../issue_links/destroy_service_spec.rb | 61 ++++++ .../services/issue_links/list_service_spec.rb | 194 ++++++++++++++++++ .../services/issues/duplicate_service_spec.rb | 11 + spec/services/issues/move_service_spec.rb | 39 ++++ .../notes/quick_actions_service_spec.rb | 36 +++- .../quick_actions/interpret_service_spec.rb | 97 +++++++++ spec/services/system_note_service_spec.rb | 34 +++ .../system_notes/issuables_service_spec.rb | 32 +++ 94 files changed, 1674 insertions(+), 408 deletions(-) create mode 100644 app/models/issue_link.rb create mode 100644 app/serializers/linked_issue_entity.rb create mode 100644 app/serializers/linked_project_issue_entity.rb create mode 100644 app/serializers/linked_project_issue_serializer.rb create mode 100644 app/services/issuable_links/create_service.rb create mode 100644 app/services/issuable_links/destroy_service.rb create mode 100644 app/services/issuable_links/list_service.rb create mode 100644 app/services/issue_links/create_service.rb create mode 100644 app/services/issue_links/destroy_service.rb create mode 100644 app/services/issue_links/list_service.rb create mode 100644 changelogs/unreleased/235912-fork-interface-with-prevent-forking-outside-a-group-is-extremely-s.yml create mode 100644 changelogs/unreleased/remove-upcoming-db-deprecation-warning.yml create mode 100644 doc/operations/incident_management/generic_alerts.md rename doc/{user/project/operations => operations/incident_management}/img/alert_list_v13_1.png (100%) create mode 100644 doc/user/project/integrations/servicenow.md create mode 100644 lib/gitlab/quick_actions/relate_actions.rb create mode 100644 spec/factories/issue_links.rb create mode 100644 spec/models/issue_link_spec.rb create mode 100644 spec/serializers/linked_project_issue_entity_spec.rb create mode 100644 spec/services/issue_links/create_service_spec.rb create mode 100644 spec/services/issue_links/destroy_service_spec.rb create mode 100644 spec/services/issue_links/list_service_spec.rb diff --git a/.markdownlint.json b/.markdownlint.json index 1c276dc42ba..88273682d3a 100644 --- a/.markdownlint.json +++ b/.markdownlint.json @@ -71,6 +71,7 @@ "Gzip", "Helm", "HipChat", + "ID", "Ingress", "jasmine-jquery", "JavaScript", diff --git a/app/assets/javascripts/snippets/components/edit.vue b/app/assets/javascripts/snippets/components/edit.vue index 2c067a36f75..22cb0e1a718 100644 --- a/app/assets/javascripts/snippets/components/edit.vue +++ b/app/assets/javascripts/snippets/components/edit.vue @@ -204,7 +204,7 @@ export default { v-if="isLoading" :label="__('Loading snippet')" size="lg" - class="loading-animation prepend-top-20 append-bottom-20" + class="loading-animation prepend-top-20 gl-mb-6" />