Enable even more frozen string in lib/**/*.rb

Enables frozen string for the following files:

* lib/generators/**/*.rb
* lib/gitaly/**/*.rb
* lib/google_api/**/*.rb
* lib/haml_lint/**/*.rb
* lib/json_web_token/**/*.rb
* lib/mattermost/**/*.rb
* lib/microsoft_teams/**/*.rb
* lib/object_storage/**/*.rb
* lib/omni_auth/**/*.rb
* lib/peek/**/*.rb
* lib/rouge/**/*.rb
* lib/rspec_flaky/**/*.rb
* lib/system_check/**/*.rb

Partially addresses #47424.

.rubocop.yml

@@ -48,7 +48,8 @@ Style/FrozenStringLiteralComment:
     - 'danger/**/*'
     - 'db/**/*'
     - 'ee/**/*'
-    - 'lib/**/*'
+    - 'lib/gitlab/**/*'
+    - 'lib/tasks/**/*'
     - 'qa/**/*'
     - 'rubocop/**/*'
     - 'scripts/**/*'

changelogs/unreleased/even-more-frozen-string-lib.yml

@@ -0,0 +1,5 @@
+---
+title: Enable even more frozen string in lib/**/*.rb
+merge_request:
+author: gfyoung
+type: performance

lib/generators/rails/post_deployment_migration/post_deployment_migration_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rails/generators'
 
 module Rails

lib/gitaly/server.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Gitaly
   class Server
     def self.all

lib/google_api/auth.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module GoogleApi
   class Auth
     attr_reader :access_token, :redirect_uri, :state

lib/google_api/cloud_platform/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'google/apis/compute_v1'
 require 'google/apis/container_v1'
 require 'google/apis/cloudbilling_v1'

lib/haml_lint/inline_javascript.rb

@@ -1,4 +1,7 @@
-unless Rails.env.production? # rubocop:disable Naming/FileName
+# rubocop:disable Naming/FileName
+# frozen_string_literal: true
+
+unless Rails.env.production?
   require 'haml_lint/haml_visitor'
   require 'haml_lint/linter'
   require 'haml_lint/linter_registry'

lib/json_web_token/rsa_token.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module JSONWebToken
   class RSAToken < Token
     attr_reader :key_file

lib/json_web_token/token.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module JSONWebToken
   class Token
     attr_accessor :issuer, :subject, :audience, :id

lib/mattermost/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mattermost
   ClientError = Class.new(Mattermost::Error)
 

lib/mattermost/command.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mattermost
   class Command < Client
     def create(params)

lib/mattermost/error.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mattermost
   Error = Class.new(StandardError)
 end

lib/mattermost/session.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mattermost
   class NoSessionError < Mattermost::Error
     def message

lib/mattermost/team.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Mattermost
   class Team < Client
     # Returns all teams that the current user is a member of

lib/microsoft_teams/activity.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MicrosoftTeams
   class Activity
     def initialize(title:, subtitle:, text:, image:)

lib/microsoft_teams/notifier.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module MicrosoftTeams
   class Notifier
     def initialize(webhook)

lib/object_storage/direct_upload.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module ObjectStorage
   #
   # The DirectUpload c;ass generates a set of presigned URLs

lib/omni_auth/strategies/bitbucket.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'omniauth-oauth2'
 
 module OmniAuth

lib/omni_auth/strategies/jwt.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'omniauth'
 require 'jwt'
 

lib/peek/rblineprof/custom_controller_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peek
   module Rblineprof
     module CustomControllerHelpers
@@ -41,7 +43,7 @@ module Peek
             ]
           end.sort_by{ |a,b,c,d,e,f| -f }
 
-          output = "<div class='modal-dialog modal-xl'><div class='modal-content'>"
+          output = ["<div class='modal-dialog modal-xl'><div class='modal-content'>"]
           output << "<div class='modal-header'>"
           output << "<h4>Line profiling: #{human_description(params[:lineprofiler])}</h4>"
           output << "<button class='close' type='button' data-dismiss='modal' aria-label='close'><span aria-hidden='true'>&times;</span></button>"
@@ -93,7 +95,7 @@ module Peek
 
           output << "</div></div></div>"
 
-          response.body += "<div class='modal' id='modal-peek-line-profile' tabindex=-1>#{output}</div>".html_safe
+          response.body += "<div class='modal' id='modal-peek-line-profile' tabindex=-1>#{output.join}</div>".html_safe
         end
 
         ret

lib/peek/views/gitaly.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peek
   module Views
     class Gitaly < View

lib/peek/views/host.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Peek
   module Views
     class Host < View

lib/rouge/formatters/html_gitlab.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Rouge
   module Formatters
     class HTMLGitlab < Rouge::Formatters::HTML

lib/rouge/plugins/common_mark.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # A rouge plugin for CommonMark markdown engine.
 # Used to highlight code generated by CommonMark.
 

lib/rspec_flaky/config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RspecFlaky
   class Config
     def self.generate_report?

lib/rspec_flaky/example.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RspecFlaky
   # This is a wrapper class for RSpec::Core::Example
   class Example

lib/rspec_flaky/flaky_example.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module RspecFlaky
   # This represents a flaky RSpec example and is mainly meant to be saved in a JSON file
   class FlakyExample < OpenStruct

lib/rspec_flaky/flaky_examples_collection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/hash_with_indifferent_access'
 
 require_relative 'flaky_example'

lib/rspec_flaky/listener.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 require_dependency 'rspec_flaky/config'

lib/rspec_flaky/report.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 require 'time'
 

lib/system_check/app/active_users_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class ActiveUsersCheck < SystemCheck::BaseCheck

lib/system_check/app/database_config_exists_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class DatabaseConfigExistsCheck < SystemCheck::BaseCheck

lib/system_check/app/git_config_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class GitConfigCheck < SystemCheck::BaseCheck

lib/system_check/app/git_user_default_ssh_config_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class GitUserDefaultSSHConfigCheck < SystemCheck::BaseCheck

lib/system_check/app/git_version_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class GitVersionCheck < SystemCheck::BaseCheck

lib/system_check/app/gitlab_config_exists_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class GitlabConfigExistsCheck < SystemCheck::BaseCheck

lib/system_check/app/gitlab_config_up_to_date_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class GitlabConfigUpToDateCheck < SystemCheck::BaseCheck

lib/system_check/app/init_script_exists_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class InitScriptExistsCheck < SystemCheck::BaseCheck

lib/system_check/app/init_script_up_to_date_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class InitScriptUpToDateCheck < SystemCheck::BaseCheck

lib/system_check/app/log_writable_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class LogWritableCheck < SystemCheck::BaseCheck

lib/system_check/app/migrations_are_up_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class MigrationsAreUpCheck < SystemCheck::BaseCheck

lib/system_check/app/orphaned_group_members_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class OrphanedGroupMembersCheck < SystemCheck::BaseCheck

lib/system_check/app/projects_have_namespace_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class ProjectsHaveNamespaceCheck < SystemCheck::BaseCheck

lib/system_check/app/redis_version_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class RedisVersionCheck < SystemCheck::BaseCheck

lib/system_check/app/ruby_version_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class RubyVersionCheck < SystemCheck::BaseCheck

lib/system_check/app/tmp_writable_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class TmpWritableCheck < SystemCheck::BaseCheck

lib/system_check/app/uploads_directory_exists_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class UploadsDirectoryExistsCheck < SystemCheck::BaseCheck

lib/system_check/app/uploads_path_permission_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class UploadsPathPermissionCheck < SystemCheck::BaseCheck

lib/system_check/app/uploads_path_tmp_permission_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module App
     class UploadsPathTmpPermissionCheck < SystemCheck::BaseCheck

lib/system_check/base_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   # Base class for Checks. You must inherit from here
   # and implement the methods below when necessary

lib/system_check/helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module Helpers
     include ::Gitlab::TaskHelpers

lib/system_check/incoming_email/foreman_configured_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module IncomingEmail
     class ForemanConfiguredCheck < SystemCheck::BaseCheck

lib/system_check/incoming_email/imap_authentication_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module IncomingEmail
     class ImapAuthenticationCheck < SystemCheck::BaseCheck

lib/system_check/incoming_email/initd_configured_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module IncomingEmail
     class InitdConfiguredCheck < SystemCheck::BaseCheck

lib/system_check/incoming_email/mail_room_running_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module IncomingEmail
     class MailRoomRunningCheck < SystemCheck::BaseCheck

lib/system_check/orphans/namespace_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module Orphans
     class NamespaceCheck < SystemCheck::BaseCheck

lib/system_check/orphans/repository_check.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   module Orphans
     class RepositoryCheck < SystemCheck::BaseCheck

lib/system_check/simple_executor.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module SystemCheck
   # Simple Executor is current default executor for GitLab
   # It is a simple port from display logic in the old check.rake