kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Make permission checks easier to understand

Browse source
This commit is contained in:
Lin Jen-Shin 2017-07-20 01:31:20 +08:00
parent a05bc477b9
commit c9c715cd55
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/services/ci/create_pipeline_service.rb
View file

@ -23,16 +23,16 @@ module Ci
unless allowed_to_trigger_pipeline?(triggering_user)
if can?(triggering_user, :create_pipeline, project)
if branch? || tag?
return error("Insufficient permissions for protected ref '#{ref}'")
else
return error('Reference not found')
end
return error("Insufficient permissions for protected ref '#{ref}'")
else
return error('Insufficient permissions to create a new pipeline')
end
end
unless branch? || tag?
return error('Reference not found')
end
unless commit
return error('Commit not found')
end
@ -93,7 +93,7 @@ module Ci
elsif tag?
access.can_create_tag?(ref)
else
false
true # Allow it for now and we'll reject when we check ref existence
end
end