Remove feature gates for Repository Languages

The repository languages feature got introduced through:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19480. This MR
included feature flags to guard against performance regressions, which
allowed GitLab to test it on gitlab.com before the customers would be
exposed.

.com worked out fine, as shown by our internal monitoring tools, which
prompts feature gate removal.

Given the docs weren't present yet, these were added too.
This commit is contained in:
Zeger-Jan van de Weg 2018-08-14 11:40:10 +02:00
parent 00c474ae4e
commit caaadb87b1
No known key found for this signature in database
GPG Key ID: 65F6A8D64A88ABAC
5 changed files with 11 additions and 8 deletions

View File

@ -21,8 +21,7 @@
%nav.project-stats{ class: [container_class, ("limit-container-width" unless fluid_layout)] }
= render 'stat_anchor_list', anchors: @project.statistics_anchors(show_auto_devops_callout: show_auto_devops_callout)
= render 'stat_anchor_list', anchors: @project.statistics_buttons(show_auto_devops_callout: show_auto_devops_callout)
- if Feature.enabled?(:repository_languages, @project.namespace.becomes(Namespace))
= repository_languages_bar(@project.repository_languages)
= repository_languages_bar(@project.repository_languages)
%div{ class: [container_class, ("limit-container-width" unless fluid_layout)] }
- if @project.archived?

View File

@ -14,8 +14,6 @@ class DetectRepositoryLanguagesWorker
user = User.find_by(id: user_id)
return unless project && user
return if Feature.disabled?(:repository_languages, project.namespace)
try_obtain_lease do
::Projects::DetectRepositoryLanguagesService.new(project, user).execute
end

Binary file not shown.

After

Width:  |  Height:  |  Size: 86 KiB

View File

@ -155,6 +155,16 @@ The repository graph displays visually the Git flow strategy used in that reposi
Find it under your project's **Repository > Graph**.
## Repository Languages
For the default branch of each repository, GitLab will determine what programming languages
were used and display this on the projects pages.
![Repository Languages bar](img/repository_languages.png)
Not all files are detected, among others; documentation,
vendored code, and most markup languages are excluded.
## Compare
Select branches to compare and view the changes inline:

View File

@ -5,10 +5,6 @@ describe Projects::DetectRepositoryLanguagesService, :clean_gitlab_redis_shared_
subject { described_class.new(project, project.owner) }
before do
allow(Feature).to receive(:disabled?).and_return(false)
end
describe '#execute' do
context 'without previous detection' do
it 'inserts new programming languages in the database' do