Merge branch 'optimise-runner-update-cached-info' into 'master'

Optimise runner update cached info

See merge request gitlab-org/gitlab-ce!19187

app/models/ci/runner.rb

@@ -219,10 +219,8 @@ module Ci
 
       cache_attributes(values)
 
-      if persist_cached_data?
+      # We save data without validation, it will always change due to `contacted_at`
-        self.assign_attributes(values)
+      self.update_columns(values) if persist_cached_data?
-        self.save if self.changed?
-      end
     end
 
     def pick_build!(build)

changelogs/unreleased/optimise-runner-update-cached-info.yml

@@ -0,0 +1,5 @@
+---
+title: Update runner cached informations without performing validations
+merge_request:
+author:
+type: performance

spec/models/ci/runner_spec.rb

@@ -549,7 +549,7 @@ describe Ci::Runner do
   end
 
   describe '#update_cached_info' do
-    let(:runner) { create(:ci_runner) }
+    let(:runner) { create(:ci_runner, :project) }
 
     subject { runner.update_cached_info(architecture: '18-bit') }
 
@@ -570,17 +570,22 @@ describe Ci::Runner do
         runner.contacted_at = 2.hours.ago
       end
 
-      it 'updates database' do
+      context 'with invalid runner' do
-        expect_redis_update
+        before do
-
+          runner.projects = []
-        expect { subject }.to change { runner.reload.read_attribute(:contacted_at) }
-          .and change { runner.reload.read_attribute(:architecture) }
         end
 
-      it 'updates cache' do
+        it 'still updates redis cache and database' do
-        expect_redis_update
+          expect(runner).to be_invalid
 
-        subject
+          expect_redis_update
+          does_db_update
+        end
+      end
+
+      it 'updates redis cache and database' do
+        expect_redis_update
+        does_db_update
       end
     end
 
@@ -590,6 +595,11 @@ describe Ci::Runner do
         expect(redis).to receive(:set).with(redis_key, anything, any_args)
       end
     end
+
+    def does_db_update
+      expect { subject }.to change { runner.reload.read_attribute(:contacted_at) }
+        .and change { runner.reload.read_attribute(:architecture) }
+    end
   end
 
   describe '#destroy' do