diff --git a/.rubocop.yml b/.rubocop.yml index d34b133edee..19f0b0b294f 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -254,7 +254,6 @@ Gitlab/HTTParty: Gitlab/Json: Enabled: true Exclude: - - 'db/**/*' - 'qa/**/*' - 'scripts/**/*' - 'tooling/rspec_flaky/**/*' diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index d52cf65a704..7fceb2eecaa 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -90,45 +90,6 @@ Graphql/OldTypes: - 'app/graphql/mutations/snippets/create.rb' - 'app/graphql/mutations/snippets/update.rb' - 'app/graphql/mutations/user_callouts/create.rb' - - 'app/graphql/resolvers/alert_management/alert_resolver.rb' - - 'app/graphql/resolvers/alert_management/alert_status_counts_resolver.rb' - - 'app/graphql/resolvers/blobs_resolver.rb' - - 'app/graphql/resolvers/ci/config_resolver.rb' - - 'app/graphql/resolvers/ci/runners_resolver.rb' - - 'app/graphql/resolvers/ci/template_resolver.rb' - - 'app/graphql/resolvers/concerns/group_issuable_resolver.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - - 'app/graphql/resolvers/concerns/resolves_pipelines.rb' - - 'app/graphql/resolvers/container_repositories_resolver.rb' - - 'app/graphql/resolvers/design_management/design_resolver.rb' - - 'app/graphql/resolvers/design_management/version/design_at_version_resolver.rb' - - 'app/graphql/resolvers/design_management/version_in_collection_resolver.rb' - - 'app/graphql/resolvers/design_management/versions_resolver.rb' - - 'app/graphql/resolvers/environments_resolver.rb' - - 'app/graphql/resolvers/full_path_resolver.rb' - - 'app/graphql/resolvers/group_labels_resolver.rb' - - 'app/graphql/resolvers/group_milestones_resolver.rb' - - 'app/graphql/resolvers/labels_resolver.rb' - - 'app/graphql/resolvers/members_resolver.rb' - - 'app/graphql/resolvers/merge_request_resolver.rb' - - 'app/graphql/resolvers/merge_requests_resolver.rb' - - 'app/graphql/resolvers/metrics/dashboard_resolver.rb' - - 'app/graphql/resolvers/milestones_resolver.rb' - - 'app/graphql/resolvers/namespace_projects_resolver.rb' - - 'app/graphql/resolvers/packages_base_resolver.rb' - - 'app/graphql/resolvers/project_milestones_resolver.rb' - - 'app/graphql/resolvers/project_pipeline_resolver.rb' - - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - - 'app/graphql/resolvers/projects/services_resolver.rb' - - 'app/graphql/resolvers/projects_resolver.rb' - - 'app/graphql/resolvers/release_resolver.rb' - - 'app/graphql/resolvers/repository_branch_names_resolver.rb' - - 'app/graphql/resolvers/snippets_resolver.rb' - - 'app/graphql/resolvers/terraform/states_resolver.rb' - - 'app/graphql/resolvers/tree_resolver.rb' - - 'app/graphql/resolvers/user_resolver.rb' - - 'app/graphql/resolvers/user_starred_projects_resolver.rb' - - 'app/graphql/resolvers/users_resolver.rb' - 'app/graphql/types/access_level_type.rb' - 'app/graphql/types/admin/analytics/usage_trends/measurement_type.rb' - 'app/graphql/types/admin/sidekiq_queues/delete_jobs_response_type.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index eb5cb835516..fa3999e2a82 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -996a4adda765e8ced18c72eca0ebd27848afa3c9 +818f3d85a2c8e6596376f1d2276aa22660203a6c diff --git a/app/assets/javascripts/diffs/components/settings_dropdown.vue b/app/assets/javascripts/diffs/components/settings_dropdown.vue index 178f93b651e..2d9ac76b3e4 100644 --- a/app/assets/javascripts/diffs/components/settings_dropdown.vue +++ b/app/assets/javascripts/diffs/components/settings_dropdown.vue @@ -60,14 +60,14 @@ export default { {{ __('List view') }} {{ __('Tree view') }} diff --git a/app/assets/javascripts/diffs/index.js b/app/assets/javascripts/diffs/index.js index ea83523008c..9d974c132b5 100644 --- a/app/assets/javascripts/diffs/index.js +++ b/app/assets/javascripts/diffs/index.js @@ -93,7 +93,7 @@ export default function initDiffsApp(store) { const treeListStored = localStorage.getItem(TREE_LIST_STORAGE_KEY); const renderTreeList = treeListStored !== null ? parseBoolean(treeListStored) : true; - this.setRenderTreeList(renderTreeList); + this.setRenderTreeList({ renderTreeList, trackClick: false }); // NOTE: A "true" or "checked" value for `showWhitespace` is '0' not '1'. // Check for cookie and save that setting for future use. @@ -104,6 +104,7 @@ export default function initDiffsApp(store) { this.setShowWhitespace({ url: this.endpointUpdateUser, showWhitespace: hideWhitespace !== '1', + trackClick: false, }); Cookies.remove(DIFF_WHITESPACE_COOKIE_NAME); } else { @@ -111,6 +112,7 @@ export default function initDiffsApp(store) { this.setShowWhitespace({ showWhitespace: this.showWhitespaceDefault, updateDatabase: false, + trackClick: false, }); } }, diff --git a/app/assets/javascripts/diffs/store/actions.js b/app/assets/javascripts/diffs/store/actions.js index 66510edf3db..f8cc39fc238 100644 --- a/app/assets/javascripts/diffs/store/actions.js +++ b/app/assets/javascripts/diffs/store/actions.js @@ -560,12 +560,12 @@ export const closeDiffFileCommentForm = ({ commit }, fileHash) => { commit(types.CLOSE_DIFF_FILE_COMMENT_FORM, fileHash); }; -export const setRenderTreeList = ({ commit }, renderTreeList) => { +export const setRenderTreeList = ({ commit }, { renderTreeList, trackClick = true }) => { commit(types.SET_RENDER_TREE_LIST, renderTreeList); localStorage.setItem(TREE_LIST_STORAGE_KEY, renderTreeList); - if (window.gon?.features?.diffSettingsUsageData) { + if (window.gon?.features?.diffSettingsUsageData && trackClick) { api.trackRedisHllUserEvent(TRACKING_CLICK_FILE_BROWSER_SETTING); if (renderTreeList) { @@ -578,7 +578,7 @@ export const setRenderTreeList = ({ commit }, renderTreeList) => { export const setShowWhitespace = async ( { state, commit }, - { url, showWhitespace, updateDatabase = true }, + { url, showWhitespace, updateDatabase = true, trackClick = true }, ) => { if (updateDatabase && Boolean(window.gon?.current_user_id)) { await axios.put(url || state.endpointUpdateUser, { show_whitespace_in_diffs: showWhitespace }); @@ -587,7 +587,7 @@ export const setShowWhitespace = async ( commit(types.SET_SHOW_WHITESPACE, showWhitespace); notesEventHub.$emit('refetchDiffData'); - if (window.gon?.features?.diffSettingsUsageData) { + if (window.gon?.features?.diffSettingsUsageData && trackClick) { api.trackRedisHllUserEvent(TRACKING_CLICK_WHITESPACE_SETTING); if (showWhitespace) { diff --git a/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue b/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue index a477aedd233..665e8ee69f7 100644 --- a/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue +++ b/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue @@ -1,6 +1,6 @@ diff --git a/app/assets/javascripts/vue_shared/components/remove_member_modal.vue b/app/assets/javascripts/members/components/modals/remove_member_modal.vue similarity index 63% rename from app/assets/javascripts/vue_shared/components/remove_member_modal.vue rename to app/assets/javascripts/members/components/modals/remove_member_modal.vue index 07272a5b8d6..00b6ebf9a73 100644 --- a/app/assets/javascripts/vue_shared/components/remove_member_modal.vue +++ b/app/assets/javascripts/members/components/modals/remove_member_modal.vue @@ -1,7 +1,6 @@