From cb8bd7d5946ca50a2de99645687a633a0c8105be Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 22 Jul 2021 12:10:04 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .rubocop.yml | 1 - .rubocop_manual_todo.yml | 39 ----- GITALY_SERVER_VERSION | 2 +- .../diffs/components/settings_dropdown.vue | 4 +- app/assets/javascripts/diffs/index.js | 4 +- app/assets/javascripts/diffs/store/actions.js | 8 +- .../action_buttons/remove_member_button.vue | 35 +++-- .../modals}/remove_member_modal.vue | 72 +++++---- .../components/table/members_table.vue | 3 + .../javascripts/members/store/actions.js | 8 + .../members/store/mutation_types.js | 3 + .../javascripts/members/store/mutations.js | 7 + app/assets/javascripts/members/store/state.js | 2 + .../pages/admin/groups/show/index.js | 22 +-- .../javascripts/pages/admin/projects/index.js | 18 --- .../pages/groups/group_members/index.js | 17 --- .../pages/projects/project_members/index.js | 17 --- .../runner/components/runner_update_form.vue | 8 +- .../components/constants.js | 5 + .../components/feature_card.vue | 7 +- .../merge_requests/creations_controller.rb | 4 - .../projects/merge_requests_controller.rb | 1 - .../alert_management/alert_resolver.rb | 6 +- .../alert_status_counts_resolver.rb | 4 +- app/graphql/resolvers/blobs_resolver.rb | 4 +- app/graphql/resolvers/ci/config_resolver.rb | 8 +- .../resolvers/ci/runner_setup_resolver.rb | 4 +- app/graphql/resolvers/ci/runners_resolver.rb | 4 +- app/graphql/resolvers/ci/template_resolver.rb | 2 +- .../resolvers/ci/test_suite_resolver.rb | 2 +- .../concerns/group_issuable_resolver.rb | 2 +- .../concerns/issue_resolver_arguments.rb | 18 +-- .../resolvers/concerns/resolves_pipelines.rb | 4 +- .../container_repositories_resolver.rb | 2 +- .../design_management/design_resolver.rb | 2 +- .../design_management/designs_resolver.rb | 2 +- .../version/design_at_version_resolver.rb | 2 +- .../version/designs_at_version_resolver.rb | 2 +- .../version_in_collection_resolver.rb | 2 +- .../design_management/versions_resolver.rb | 2 +- app/graphql/resolvers/echo_resolver.rb | 4 +- .../resolvers/environments_resolver.rb | 6 +- .../error_tracking/sentry_errors_resolver.rb | 4 +- app/graphql/resolvers/full_path_resolver.rb | 2 +- .../resolvers/group_labels_resolver.rb | 4 +- .../resolvers/group_milestones_resolver.rb | 4 +- app/graphql/resolvers/labels_resolver.rb | 4 +- app/graphql/resolvers/members_resolver.rb | 2 +- .../resolvers/merge_request_resolver.rb | 2 +- .../resolvers/merge_requests_resolver.rb | 20 +-- .../resolvers/metrics/dashboard_resolver.rb | 2 +- app/graphql/resolvers/milestones_resolver.rb | 6 +- .../resolvers/namespace_projects_resolver.rb | 6 +- .../resolvers/packages_base_resolver.rb | 4 +- .../resolvers/project_milestones_resolver.rb | 2 +- .../resolvers/project_pipeline_resolver.rb | 4 +- .../projects/jira_projects_resolver.rb | 2 +- .../resolvers/projects/services_resolver.rb | 2 +- app/graphql/resolvers/projects_resolver.rb | 12 +- app/graphql/resolvers/release_resolver.rb | 2 +- .../repository_branch_names_resolver.rb | 8 +- .../resolvers/snippets/blobs_resolver.rb | 2 +- app/graphql/resolvers/snippets_resolver.rb | 2 +- .../resolvers/terraform/states_resolver.rb | 2 +- app/graphql/resolvers/todo_resolver.rb | 6 +- app/graphql/resolvers/tree_resolver.rb | 6 +- .../user_discussions_count_resolver.rb | 2 +- .../user_merge_requests_resolver_base.rb | 2 +- .../resolvers/user_notes_count_resolver.rb | 2 +- app/graphql/resolvers/user_resolver.rb | 2 +- .../user_starred_projects_resolver.rb | 2 +- .../resolvers/users/group_count_resolver.rb | 2 +- app/graphql/resolvers/users_resolver.rb | 8 +- app/helpers/application_helper.rb | 6 + .../generate_distribution_key_service.rb | 61 ++++---- .../debian/sign_distribution_service.rb | 38 +++++ app/views/admin/dashboard/index.html.haml | 1 + app/views/admin/groups/show.html.haml | 1 - app/views/admin/projects/show.html.haml | 1 - .../groups/group_members/index.html.haml | 1 - .../groups/settings/_permissions.html.haml | 12 +- app/views/layouts/_head.html.haml | 7 +- app/views/projects/edit.html.haml | 2 + .../projects/project_members/index.html.haml | 1 - .../projects/settings/_general.html.haml | 2 - app/views/shared/issuable/_form.html.haml | 2 - .../_metadata_issuable_reviewer.html.haml | 3 +- .../mr_collapsed_approval_rules.yml | 8 - ...7153211_migrate_k8s_service_integration.rb | 2 +- .../geo/replication/troubleshooting.md | 26 +++- doc/development/fe_guide/haml.md | 74 ++++++++++ doc/development/fe_guide/index.md | 4 + doc/development/sidekiq_style_guide.md | 18 +++ doc/raketasks/backup_restore.md | 72 ++++++++- doc/user/infrastructure/iac/index.md | 139 ++++++++++++++++++ doc/user/infrastructure/index.md | 137 +---------------- doc/user/infrastructure/mr_integration.md | 2 +- lib/gitlab/ci/yaml_processor/dag.rb | 2 +- .../form_builders/gitlab_ui_form_builder.rb | 55 +++++++ .../import_export/json/legacy_reader.rb | 2 +- .../import_export/json/ndjson_reader.rb | 4 +- lib/gitlab/import_export/lfs_restorer.rb | 2 +- lib/gitlab/json_cache.rb | 4 +- locale/gitlab.pot | 27 ++-- qa/qa/page/group/members.rb | 2 +- rubocop/cop/gitlab/json.rb | 2 +- .../packages/debian/distribution_key.rb | 4 +- .../import_export/export_file_spec.rb | 3 +- spec/fixtures/private_key.asc | 17 +++ spec/fixtures/public_key.asc | 15 ++ .../components/settings_dropdown_spec.js | 8 +- spec/frontend/diffs/store/actions_spec.js | 4 +- .../invite_action_buttons_spec.js | 2 +- .../remove_member_button_spec.js | 27 ++-- .../modals}/remove_member_modal_spec.js | 87 +++++++---- .../components/table/members_table_spec.js | 1 + spec/frontend/members/mock_data.js | 9 ++ spec/frontend/members/store/actions_spec.js | 32 +++- spec/frontend/members/store/mutations_spec.js | 30 +++- .../components/feature_card_spec.js | 34 +++-- spec/graphql/resolvers/base_resolver_spec.rb | 38 ++--- .../concerns/caching_array_resolver_spec.rb | 4 +- .../concerns/resolves_pipelines_spec.rb | 2 +- spec/graphql/resolvers/echo_resolver_spec.rb | 2 +- .../graphql/resolvers/issues_resolver_spec.rb | 2 +- .../namespace_projects_resolver_spec.rb | 2 +- .../resolvers/project_resolver_spec.rb | 4 +- .../terraform/states_resolver_spec.rb | 3 +- .../user_discussions_count_resolver_spec.rb | 2 +- .../user_notes_count_resolver_spec.rb | 2 +- spec/helpers/application_helper_spec.rb | 19 +++ spec/lib/gitlab/ci/yaml_processor_spec.rb | 2 +- .../gitlab_ui_form_builder_spec.rb | 88 +++++++++++ .../group/legacy_tree_restorer_spec.rb | 2 +- .../import_export/group/tree_restorer_spec.rb | 2 +- .../import_test_coverage_spec.rb | 2 +- spec/lib/gitlab/json_cache_spec.rb | 6 +- spec/requests/git_http_spec.rb | 4 +- spec/rubocop/cop/gitlab/json_spec.rb | 15 +- .../generate_distribution_key_service_spec.rb | 32 ++-- .../debian/sign_distribution_service_spec.rb | 61 ++++++++ spec/support/import_export/common_util.rb | 6 +- .../admin/dashboard/index.html.haml_spec.rb | 8 + 143 files changed, 1156 insertions(+), 644 deletions(-) rename app/assets/javascripts/{vue_shared/components => members/components/modals}/remove_member_modal.vue (63%) create mode 100644 app/services/packages/debian/sign_distribution_service.rb delete mode 100644 config/feature_flags/development/mr_collapsed_approval_rules.yml create mode 100644 doc/development/fe_guide/haml.md create mode 100644 doc/user/infrastructure/iac/index.md create mode 100644 lib/gitlab/form_builders/gitlab_ui_form_builder.rb create mode 100644 spec/fixtures/private_key.asc create mode 100644 spec/fixtures/public_key.asc rename spec/frontend/{vue_shared/components => members/components/modals}/remove_member_modal_spec.js (50%) create mode 100644 spec/lib/gitlab/form_builders/gitlab_ui_form_builder_spec.rb create mode 100644 spec/services/packages/debian/sign_distribution_service_spec.rb diff --git a/.rubocop.yml b/.rubocop.yml index d34b133edee..19f0b0b294f 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -254,7 +254,6 @@ Gitlab/HTTParty: Gitlab/Json: Enabled: true Exclude: - - 'db/**/*' - 'qa/**/*' - 'scripts/**/*' - 'tooling/rspec_flaky/**/*' diff --git a/.rubocop_manual_todo.yml b/.rubocop_manual_todo.yml index d52cf65a704..7fceb2eecaa 100644 --- a/.rubocop_manual_todo.yml +++ b/.rubocop_manual_todo.yml @@ -90,45 +90,6 @@ Graphql/OldTypes: - 'app/graphql/mutations/snippets/create.rb' - 'app/graphql/mutations/snippets/update.rb' - 'app/graphql/mutations/user_callouts/create.rb' - - 'app/graphql/resolvers/alert_management/alert_resolver.rb' - - 'app/graphql/resolvers/alert_management/alert_status_counts_resolver.rb' - - 'app/graphql/resolvers/blobs_resolver.rb' - - 'app/graphql/resolvers/ci/config_resolver.rb' - - 'app/graphql/resolvers/ci/runners_resolver.rb' - - 'app/graphql/resolvers/ci/template_resolver.rb' - - 'app/graphql/resolvers/concerns/group_issuable_resolver.rb' - - 'app/graphql/resolvers/concerns/issue_resolver_arguments.rb' - - 'app/graphql/resolvers/concerns/resolves_pipelines.rb' - - 'app/graphql/resolvers/container_repositories_resolver.rb' - - 'app/graphql/resolvers/design_management/design_resolver.rb' - - 'app/graphql/resolvers/design_management/version/design_at_version_resolver.rb' - - 'app/graphql/resolvers/design_management/version_in_collection_resolver.rb' - - 'app/graphql/resolvers/design_management/versions_resolver.rb' - - 'app/graphql/resolvers/environments_resolver.rb' - - 'app/graphql/resolvers/full_path_resolver.rb' - - 'app/graphql/resolvers/group_labels_resolver.rb' - - 'app/graphql/resolvers/group_milestones_resolver.rb' - - 'app/graphql/resolvers/labels_resolver.rb' - - 'app/graphql/resolvers/members_resolver.rb' - - 'app/graphql/resolvers/merge_request_resolver.rb' - - 'app/graphql/resolvers/merge_requests_resolver.rb' - - 'app/graphql/resolvers/metrics/dashboard_resolver.rb' - - 'app/graphql/resolvers/milestones_resolver.rb' - - 'app/graphql/resolvers/namespace_projects_resolver.rb' - - 'app/graphql/resolvers/packages_base_resolver.rb' - - 'app/graphql/resolvers/project_milestones_resolver.rb' - - 'app/graphql/resolvers/project_pipeline_resolver.rb' - - 'app/graphql/resolvers/projects/jira_projects_resolver.rb' - - 'app/graphql/resolvers/projects/services_resolver.rb' - - 'app/graphql/resolvers/projects_resolver.rb' - - 'app/graphql/resolvers/release_resolver.rb' - - 'app/graphql/resolvers/repository_branch_names_resolver.rb' - - 'app/graphql/resolvers/snippets_resolver.rb' - - 'app/graphql/resolvers/terraform/states_resolver.rb' - - 'app/graphql/resolvers/tree_resolver.rb' - - 'app/graphql/resolvers/user_resolver.rb' - - 'app/graphql/resolvers/user_starred_projects_resolver.rb' - - 'app/graphql/resolvers/users_resolver.rb' - 'app/graphql/types/access_level_type.rb' - 'app/graphql/types/admin/analytics/usage_trends/measurement_type.rb' - 'app/graphql/types/admin/sidekiq_queues/delete_jobs_response_type.rb' diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index eb5cb835516..fa3999e2a82 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -996a4adda765e8ced18c72eca0ebd27848afa3c9 +818f3d85a2c8e6596376f1d2276aa22660203a6c diff --git a/app/assets/javascripts/diffs/components/settings_dropdown.vue b/app/assets/javascripts/diffs/components/settings_dropdown.vue index 178f93b651e..2d9ac76b3e4 100644 --- a/app/assets/javascripts/diffs/components/settings_dropdown.vue +++ b/app/assets/javascripts/diffs/components/settings_dropdown.vue @@ -60,14 +60,14 @@ export default { {{ __('List view') }} {{ __('Tree view') }} diff --git a/app/assets/javascripts/diffs/index.js b/app/assets/javascripts/diffs/index.js index ea83523008c..9d974c132b5 100644 --- a/app/assets/javascripts/diffs/index.js +++ b/app/assets/javascripts/diffs/index.js @@ -93,7 +93,7 @@ export default function initDiffsApp(store) { const treeListStored = localStorage.getItem(TREE_LIST_STORAGE_KEY); const renderTreeList = treeListStored !== null ? parseBoolean(treeListStored) : true; - this.setRenderTreeList(renderTreeList); + this.setRenderTreeList({ renderTreeList, trackClick: false }); // NOTE: A "true" or "checked" value for `showWhitespace` is '0' not '1'. // Check for cookie and save that setting for future use. @@ -104,6 +104,7 @@ export default function initDiffsApp(store) { this.setShowWhitespace({ url: this.endpointUpdateUser, showWhitespace: hideWhitespace !== '1', + trackClick: false, }); Cookies.remove(DIFF_WHITESPACE_COOKIE_NAME); } else { @@ -111,6 +112,7 @@ export default function initDiffsApp(store) { this.setShowWhitespace({ showWhitespace: this.showWhitespaceDefault, updateDatabase: false, + trackClick: false, }); } }, diff --git a/app/assets/javascripts/diffs/store/actions.js b/app/assets/javascripts/diffs/store/actions.js index 66510edf3db..f8cc39fc238 100644 --- a/app/assets/javascripts/diffs/store/actions.js +++ b/app/assets/javascripts/diffs/store/actions.js @@ -560,12 +560,12 @@ export const closeDiffFileCommentForm = ({ commit }, fileHash) => { commit(types.CLOSE_DIFF_FILE_COMMENT_FORM, fileHash); }; -export const setRenderTreeList = ({ commit }, renderTreeList) => { +export const setRenderTreeList = ({ commit }, { renderTreeList, trackClick = true }) => { commit(types.SET_RENDER_TREE_LIST, renderTreeList); localStorage.setItem(TREE_LIST_STORAGE_KEY, renderTreeList); - if (window.gon?.features?.diffSettingsUsageData) { + if (window.gon?.features?.diffSettingsUsageData && trackClick) { api.trackRedisHllUserEvent(TRACKING_CLICK_FILE_BROWSER_SETTING); if (renderTreeList) { @@ -578,7 +578,7 @@ export const setRenderTreeList = ({ commit }, renderTreeList) => { export const setShowWhitespace = async ( { state, commit }, - { url, showWhitespace, updateDatabase = true }, + { url, showWhitespace, updateDatabase = true, trackClick = true }, ) => { if (updateDatabase && Boolean(window.gon?.current_user_id)) { await axios.put(url || state.endpointUpdateUser, { show_whitespace_in_diffs: showWhitespace }); @@ -587,7 +587,7 @@ export const setShowWhitespace = async ( commit(types.SET_SHOW_WHITESPACE, showWhitespace); notesEventHub.$emit('refetchDiffData'); - if (window.gon?.features?.diffSettingsUsageData) { + if (window.gon?.features?.diffSettingsUsageData && trackClick) { api.trackRedisHllUserEvent(TRACKING_CLICK_WHITESPACE_SETTING); if (showWhitespace) { diff --git a/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue b/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue index a477aedd233..665e8ee69f7 100644 --- a/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue +++ b/app/assets/javascripts/members/components/action_buttons/remove_member_button.vue @@ -1,6 +1,6 @@ diff --git a/app/assets/javascripts/vue_shared/components/remove_member_modal.vue b/app/assets/javascripts/members/components/modals/remove_member_modal.vue similarity index 63% rename from app/assets/javascripts/vue_shared/components/remove_member_modal.vue rename to app/assets/javascripts/members/components/modals/remove_member_modal.vue index 07272a5b8d6..00b6ebf9a73 100644 --- a/app/assets/javascripts/vue_shared/components/remove_member_modal.vue +++ b/app/assets/javascripts/members/components/modals/remove_member_modal.vue @@ -1,7 +1,6 @@