kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Apply suggestion to doc/development/code_review.md

This commit is contained in:
Marcia Ramos 2019-02-21 16:43:53 +00:00
parent 6349a18588
commit cbeab67a27
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
doc/development/code_review.md
View File

@ -205,7 +205,7 @@ first time.
- Try to respond to every comment.
- The merge request author resolves only the discussions they have fully
addressed. If there's an open reply, an open discussion, a suggestion,
a question, or anything else, the discussion must be left to be resolved
a question, or anything else, the discussion should be left to be resolved
by the reviewer.
- Push commits based on earlier rounds of feedback as isolated commits to the
branch. Do not squash until the branch is ready to merge. Reviewers should be