adds events to services api deserialization
This commit is contained in:
parent
4b7ec44b91
commit
cd51af1a99
|
@ -1,23 +1,23 @@
|
|||
module ServicesHelper
|
||||
def service_event_description(event)
|
||||
case event
|
||||
when "push"
|
||||
when "push", "push_events"
|
||||
"Event will be triggered by a push to the repository"
|
||||
when "tag_push"
|
||||
when "tag_push", "tag_push_events"
|
||||
"Event will be triggered when a new tag is pushed to the repository"
|
||||
when "note"
|
||||
when "note", "note_events"
|
||||
"Event will be triggered when someone adds a comment"
|
||||
when "issue"
|
||||
when "issue", "issue_events"
|
||||
"Event will be triggered when an issue is created/updated/closed"
|
||||
when "confidential_issue"
|
||||
when "confidential_issue", "confidential_issue_events"
|
||||
"Event will be triggered when a confidential issue is created/updated/closed"
|
||||
when "merge_request"
|
||||
when "merge_request", "merge_request_events"
|
||||
"Event will be triggered when a merge request is created/updated/merged"
|
||||
when "build"
|
||||
when "build", "build_events"
|
||||
"Event will be triggered when a build status changes"
|
||||
when "wiki_page"
|
||||
when "wiki_page", "wiki_page_events"
|
||||
"Event will be triggered when a wiki page is created/updated"
|
||||
when "commit"
|
||||
when "commit", "commit_events"
|
||||
"Event will be triggered when a commit is created/updated"
|
||||
end
|
||||
end
|
||||
|
|
|
@ -25,7 +25,7 @@ You can create a Personal Access Token here:
|
|||
http://app.asana.com/-/account_api'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'asana'
|
||||
end
|
||||
|
||||
|
@ -44,10 +44,14 @@ http://app.asana.com/-/account_api'
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def client
|
||||
@_client ||= begin
|
||||
Asana::Client.new do |c|
|
||||
|
|
|
@ -12,7 +12,7 @@ class AssemblaService < Service
|
|||
'Project Management Software (Source Commits Endpoint)'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'assembla'
|
||||
end
|
||||
|
||||
|
@ -23,10 +23,14 @@ class AssemblaService < Service
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
|
||||
|
|
|
@ -40,7 +40,7 @@ class BambooService < CiService
|
|||
'You must set up automatic revision labeling and a repository trigger in Bamboo.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'bamboo'
|
||||
end
|
||||
|
||||
|
@ -56,7 +56,7 @@ class BambooService < CiService
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
|
|
|
@ -19,7 +19,15 @@ class BugzillaService < IssueTrackerService
|
|||
end
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'bugzilla'
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -24,10 +24,14 @@ class BuildkiteService < CiService
|
|||
hook.save
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
|
||||
|
@ -54,7 +58,7 @@ class BuildkiteService < CiService
|
|||
'Continuous integration and deployments'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'buildkite'
|
||||
end
|
||||
|
||||
|
|
|
@ -19,14 +19,18 @@ class BuildsEmailService < Service
|
|||
'Email the builds status to a list of recipients.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'builds_email'
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(build)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(push_data)
|
||||
return unless supported_events.include?(push_data[:object_kind])
|
||||
return unless should_build_be_notified?(push_data)
|
||||
|
|
|
@ -12,7 +12,7 @@ class CampfireService < Service
|
|||
'Simple web-based real-time group chat'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'campfire'
|
||||
end
|
||||
|
||||
|
@ -24,10 +24,14 @@ class CampfireService < Service
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
|
||||
|
|
|
@ -25,7 +25,7 @@ class ChatNotificationService < Service
|
|||
valid?
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w[push issue confidential_issue merge_request note tag_push
|
||||
build pipeline wiki_page]
|
||||
end
|
||||
|
|
|
@ -13,8 +13,8 @@ class ChatSlashCommandsService < Service
|
|||
ActiveSupport::SecurityUtils.variable_size_secure_compare(token, self.token)
|
||||
end
|
||||
|
||||
def supported_events
|
||||
[]
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def can_test?
|
||||
|
|
|
@ -8,10 +8,13 @@ class CiService < Service
|
|||
self.respond_to?(:token) && self.token.present? && ActiveSupport::SecurityUtils.variable_size_secure_compare(token, self.token)
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
# Return complete url to build page
|
||||
#
|
||||
# Ex.
|
||||
|
|
|
@ -23,7 +23,7 @@ class CustomIssueTrackerService < IssueTrackerService
|
|||
end
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'custom_issue_tracker'
|
||||
end
|
||||
|
||||
|
@ -36,4 +36,12 @@ class CustomIssueTrackerService < IssueTrackerService
|
|||
{ type: 'text', name: 'new_issue_url', placeholder: 'New Issue url' }
|
||||
]
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -5,8 +5,8 @@
|
|||
class DeploymentService < Service
|
||||
default_value_for :category, 'deployment'
|
||||
|
||||
def supported_events
|
||||
[]
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def predefined_variables
|
||||
|
|
|
@ -32,7 +32,7 @@ class DroneCiService < CiService
|
|||
true
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push merge_request tag_push)
|
||||
end
|
||||
|
||||
|
@ -87,7 +87,7 @@ class DroneCiService < CiService
|
|||
'Drone is a Continuous Integration platform built on Docker, written in Go'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'drone_ci'
|
||||
end
|
||||
|
||||
|
|
|
@ -12,14 +12,18 @@ class EmailsOnPushService < Service
|
|||
'Email the commits and diff of each push to a list of recipients.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'emails_on_push'
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push tag_push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(push_data)
|
||||
return unless supported_events.include?(push_data[:object_kind])
|
||||
|
||||
|
|
|
@ -13,7 +13,7 @@ class ExternalWikiService < Service
|
|||
'Replaces the link to the internal wiki with a link to an external wiki.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'external_wiki'
|
||||
end
|
||||
|
||||
|
@ -29,4 +29,12 @@ class ExternalWikiService < Service
|
|||
nil
|
||||
end
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -12,7 +12,7 @@ class FlowdockService < Service
|
|||
'Flowdock is a collaboration web app for technical teams.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'flowdock'
|
||||
end
|
||||
|
||||
|
@ -22,10 +22,14 @@ class FlowdockService < Service
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
|
||||
|
|
|
@ -12,7 +12,7 @@ class GemnasiumService < Service
|
|||
'Gemnasium monitors your project dependencies and alerts you about updates and security vulnerabilities.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'gemnasium'
|
||||
end
|
||||
|
||||
|
@ -23,10 +23,14 @@ class GemnasiumService < Service
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
|
||||
|
|
|
@ -7,7 +7,7 @@ class GitlabIssueTrackerService < IssueTrackerService
|
|||
|
||||
default_value_for :default, true
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'gitlab'
|
||||
end
|
||||
|
||||
|
|
|
@ -27,7 +27,7 @@ class HipchatService < Service
|
|||
'Private group chat and IM'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'hipchat'
|
||||
end
|
||||
|
||||
|
@ -45,10 +45,14 @@ class HipchatService < Service
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push issue confidential_issue merge_request note tag_push build)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
message = create_message(data)
|
||||
|
|
|
@ -17,14 +17,18 @@ class IrkerService < Service
|
|||
'gateway.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'irker'
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
|
||||
|
|
|
@ -57,7 +57,7 @@ class IssueTrackerService < Service
|
|||
end
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
|
|
|
@ -12,10 +12,14 @@ class JiraService < IssueTrackerService
|
|||
# This is confusing, but JiraService does not really support these events.
|
||||
# The values here are required to display correct options in the service
|
||||
# configuration screen.
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(commit merge_request)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
# {PROJECT-KEY}-{NUMBER} Examples: JIRA-1, PROJECT-1
|
||||
def reference_pattern
|
||||
@reference_pattern ||= %r{(?<issue>\b([A-Z][A-Z0-9_]+-)\d+)}
|
||||
|
@ -81,7 +85,7 @@ class JiraService < IssueTrackerService
|
|||
end
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'jira'
|
||||
end
|
||||
|
||||
|
|
|
@ -52,7 +52,7 @@ class KubernetesService < DeploymentService
|
|||
'deployments with `app=$CI_ENVIRONMENT_SLUG`'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'kubernetes'
|
||||
end
|
||||
|
||||
|
@ -158,6 +158,14 @@ class KubernetesService < DeploymentService
|
|||
opts
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def kubeclient_auth_options
|
||||
{ bearer_token: token }
|
||||
end
|
||||
|
|
|
@ -7,7 +7,7 @@ class MattermostService < ChatNotificationService
|
|||
'Receive event notifications in Mattermost'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'mattermost'
|
||||
end
|
||||
|
||||
|
@ -38,4 +38,12 @@ class MattermostService < ChatNotificationService
|
|||
def default_channel_placeholder
|
||||
"#town-square"
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -15,7 +15,7 @@ class MattermostSlashCommandsService < ChatSlashCommandsService
|
|||
"Perform common operations on GitLab in Mattermost"
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'mattermost_slash_commands'
|
||||
end
|
||||
|
||||
|
@ -48,4 +48,12 @@ class MattermostSlashCommandsService < ChatSlashCommandsService
|
|||
method: 'P',
|
||||
username: 'GitLab')
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -15,14 +15,18 @@ class PipelinesEmailService < Service
|
|||
'Email the pipelines status to a list of recipients.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'pipelines_email'
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w[pipeline]
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data, force: false)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
return unless force || should_pipeline_be_notified?(data)
|
||||
|
|
|
@ -14,7 +14,7 @@ class PivotaltrackerService < Service
|
|||
'Project Management Software (Source Commits Endpoint)'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'pivotaltracker'
|
||||
end
|
||||
|
||||
|
@ -34,10 +34,14 @@ class PivotaltrackerService < Service
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
return unless allowed_branch?(data[:ref])
|
||||
|
|
|
@ -13,7 +13,7 @@ class PushoverService < Service
|
|||
'Pushover makes it easy to get real-time notifications on your Android device, iPhone, iPad, and Desktop.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'pushover'
|
||||
end
|
||||
|
||||
|
@ -61,10 +61,14 @@ class PushoverService < Service
|
|||
]
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
return unless supported_events.include?(data[:object_kind])
|
||||
|
||||
|
|
|
@ -19,7 +19,15 @@ class RedmineService < IssueTrackerService
|
|||
end
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'redmine'
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -7,7 +7,7 @@ class SlackService < ChatNotificationService
|
|||
'Receive event notifications in Slack'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'slack'
|
||||
end
|
||||
|
||||
|
@ -37,4 +37,12 @@ class SlackService < ChatNotificationService
|
|||
def default_channel_placeholder
|
||||
"#general"
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -9,7 +9,7 @@ class SlackSlashCommandsService < ChatSlashCommandsService
|
|||
"Perform common operations on GitLab in Slack"
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'slack_slash_commands'
|
||||
end
|
||||
|
||||
|
@ -25,4 +25,12 @@ class SlackSlashCommandsService < ChatSlashCommandsService
|
|||
def format(text)
|
||||
Slack::Notifier::LinkFormatter.format(text) if text
|
||||
end
|
||||
|
||||
def self.supported_events
|
||||
%w()
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
end
|
||||
|
|
|
@ -43,14 +43,18 @@ class TeamcityService < CiService
|
|||
'requests build, that setting is in the vsc root advanced settings.'
|
||||
end
|
||||
|
||||
def to_param
|
||||
def self.to_param
|
||||
'teamcity'
|
||||
end
|
||||
|
||||
def supported_events
|
||||
def self.supported_events
|
||||
%w(push)
|
||||
end
|
||||
|
||||
def self.event_names
|
||||
self.supported_events.map { |event| "#{event}_events" }
|
||||
end
|
||||
|
||||
def fields
|
||||
[
|
||||
{ type: 'text', name: 'teamcity_url',
|
||||
|
|
|
@ -76,6 +76,7 @@ class Service < ActiveRecord::Base
|
|||
|
||||
def to_param
|
||||
# implement inside child
|
||||
self.class.to_param
|
||||
end
|
||||
|
||||
def fields
|
||||
|
@ -92,7 +93,8 @@ class Service < ActiveRecord::Base
|
|||
end
|
||||
|
||||
def event_names
|
||||
supported_events.map { |event| "#{event}_events" }
|
||||
# implement inside child
|
||||
self.class.event_names
|
||||
end
|
||||
|
||||
def event_field(event)
|
||||
|
@ -104,7 +106,7 @@ class Service < ActiveRecord::Base
|
|||
end
|
||||
|
||||
def supported_events
|
||||
%w(push tag_push issue confidential_issue merge_request wiki_page)
|
||||
self.class.supported_events
|
||||
end
|
||||
|
||||
def execute(data)
|
||||
|
|
|
@ -0,0 +1,4 @@
|
|||
---
|
||||
title: Adds service trigger events to api
|
||||
merge_request: 8324
|
||||
author:
|
|
@ -145,7 +145,7 @@ module API
|
|||
name: :room,
|
||||
type: String,
|
||||
desc: 'Campfire room'
|
||||
},
|
||||
}
|
||||
],
|
||||
'custom-issue-tracker' => [
|
||||
{
|
||||
|
@ -534,7 +534,36 @@ module API
|
|||
desc: 'The password of the user'
|
||||
}
|
||||
]
|
||||
}.freeze
|
||||
}
|
||||
|
||||
service_classes = [
|
||||
AsanaService,
|
||||
AssemblaService,
|
||||
BambooService,
|
||||
BugzillaService,
|
||||
BuildkiteService,
|
||||
BuildsEmailService,
|
||||
CampfireService,
|
||||
CustomIssueTrackerService,
|
||||
DroneCiService,
|
||||
EmailsOnPushService,
|
||||
ExternalWikiService,
|
||||
FlowdockService,
|
||||
GemnasiumService,
|
||||
HipchatService,
|
||||
IrkerService,
|
||||
JiraService,
|
||||
KubernetesService,
|
||||
MattermostSlashCommandsService,
|
||||
SlackSlashCommandsService,
|
||||
PipelinesEmailService,
|
||||
PivotaltrackerService,
|
||||
PushoverService,
|
||||
RedmineService,
|
||||
SlackService,
|
||||
MattermostService,
|
||||
TeamcityService,
|
||||
].freeze
|
||||
|
||||
trigger_services = {
|
||||
'mattermost-slash-commands' => [
|
||||
|
@ -568,6 +597,20 @@ module API
|
|||
services.each do |service_slug, settings|
|
||||
desc "Set #{service_slug} service for project"
|
||||
params do
|
||||
service_classes.each do |service|
|
||||
event_names = service.try(:event_names) || []
|
||||
event_names.each do |event_name|
|
||||
services[service.to_param.gsub("_", "-")] << {
|
||||
required: false,
|
||||
name: event_name.to_sym,
|
||||
type: String,
|
||||
desc: ServicesHelper.instance_method(:service_event_description)
|
||||
.bind(self).call(event_name)
|
||||
}
|
||||
end
|
||||
end
|
||||
services.freeze
|
||||
|
||||
settings.each do |setting|
|
||||
if setting[:required]
|
||||
requires setting[:name], type: setting[:type], desc: setting[:desc]
|
||||
|
@ -581,7 +624,7 @@ module API
|
|||
service_params = declared_params(include_missing: false).merge(active: true)
|
||||
|
||||
if service.update_attributes(service_params)
|
||||
true
|
||||
present service, with: Entities::ProjectService, include_passwords: current_user.is_admin?
|
||||
else
|
||||
render_api_error!('400 Bad Request', 400)
|
||||
end
|
||||
|
|
|
@ -16,6 +16,15 @@ describe API::Services, api: true do
|
|||
put api("/projects/#{project.id}/services/#{dashed_service}", user), service_attrs
|
||||
|
||||
expect(response).to have_http_status(200)
|
||||
|
||||
current_service = project.services.first
|
||||
event = current_service.event_names.empty? ? "foo" : current_service.event_names.first
|
||||
state = current_service[event] || false
|
||||
|
||||
put api("/projects/#{project.id}/services/#{dashed_service}?#{event}=#{!state}", user), service_attrs
|
||||
|
||||
expect(response).to have_http_status(200)
|
||||
expect(project.services.first[event]).not_to eq(state) unless event == "foo"
|
||||
end
|
||||
|
||||
it "returns if required fields missing" do
|
||||
|
|
Loading…
Reference in New Issue