From ced6c9ae9a9a80c884cafbea9c717b578dfac326 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 11 Feb 2021 00:08:50 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../batch_comments/components/draft_note.vue | 8 +- .../components/preview_item.vue | 15 ++- .../diffs/components/diff_line_note_form.vue | 2 +- .../notes/components/discussion_notes.vue | 8 +- .../notes/components/noteable_note.vue | 4 +- .../protected_tags/protected_tag_edit.js | 9 +- app/assets/stylesheets/framework/tables.scss | 3 - .../projects/merge_requests_controller.rb | 1 - .../ci/create_job_artifacts_service.rb | 9 ++ .../shared/_tags_list.html.haml | 1 - changelogs/unreleased/ar-fix-border-color.yml | 5 + ...ve_vuln_tracking-db_add_tracking_table.yml | 5 + .../unreleased/rf-update-brakeman-rules.yml | 5 + .../development/multiline_comments.yml | 8 -- ...ting_metrics_report_artifact_uploaders.yml | 8 ++ config/known_invalid_graphql_queries.yml | 1 + ...108134919_add_finding_fingerprint_table.rb | 40 +++++++ ...bility_findings_remediations_join_table.rb | 2 + db/schema_migrations/20201108134919 | 1 + db/structure.sql | 32 ++++++ doc/administration/gitaly/index.md | 33 ++++++ doc/administration/gitaly/praefect.md | 58 ++++++---- doc/administration/logs.md | 5 +- doc/development/chatops_on_gitlabcom.md | 14 +-- doc/development/code_review.md | 5 +- .../documentation/styleguide/index.md | 16 --- doc/development/fe_guide/icons.md | 10 +- .../project/merge_requests/code_quality.md | 34 +++++- .../reviewing_and_managing_merge_requests.md | 26 +---- .../ci/templates/Security/SAST.gitlab-ci.yml | 3 +- .../known_events/common.yml | 5 + locale/gitlab.pot | 105 +++++++++++++++++- rubocop/rubocop-migrations.yml | 1 + .../security/configuration_controller_spec.rb | 2 + .../components/draft_note_spec.js | 21 ++-- .../components/preview_item_spec.js | 19 +++- .../components/diff_line_note_form_spec.js | 1 + .../notes/components/discussion_notes_spec.js | 21 ++-- .../notes/components/noteable_note_spec.js | 9 -- spec/requests/api/generic_packages_spec.rb | 30 ++--- spec/requests/api/group_import_spec.rb | 4 +- spec/requests/api/maven_packages_spec.rb | 11 +- .../api/nuget_project_packages_spec.rb | 14 +-- spec/requests/api/project_import_spec.rb | 5 +- spec/requests/api/pypi_packages_spec.rb | 18 +-- .../import/gitlab_groups_controller_spec.rb | 6 +- .../import/gitlab_projects_controller_spec.rb | 3 +- .../ci/create_job_artifacts_service_spec.rb | 28 +++++ .../ci/create_pipeline_service_spec.rb | 2 +- .../api/conan_packages_shared_context.rb | 6 +- .../requests/api/workhorse_shared_context.rb | 6 + .../api/debian_packages_shared_examples.rb | 9 +- .../api/nuget_packages_shared_examples.rb | 2 +- .../requests/api/packages_shared_examples.rb | 10 +- 54 files changed, 480 insertions(+), 229 deletions(-) create mode 100644 changelogs/unreleased/ar-fix-border-color.yml create mode 100644 changelogs/unreleased/improve_vuln_tracking-db_add_tracking_table.yml create mode 100644 changelogs/unreleased/rf-update-brakeman-rules.yml delete mode 100644 config/feature_flags/development/multiline_comments.yml create mode 100644 config/feature_flags/development/usage_data_i_testing_metrics_report_artifact_uploaders.yml create mode 100644 db/migrate/20201108134919_add_finding_fingerprint_table.rb create mode 100644 db/schema_migrations/20201108134919 create mode 100644 spec/support/shared_contexts/requests/api/workhorse_shared_context.rb diff --git a/app/assets/javascripts/batch_comments/components/draft_note.vue b/app/assets/javascripts/batch_comments/components/draft_note.vue index 5564bca6df0..b480cf098f2 100644 --- a/app/assets/javascripts/batch_comments/components/draft_note.vue +++ b/app/assets/javascripts/batch_comments/components/draft_note.vue @@ -3,7 +3,6 @@ import { mapActions, mapGetters, mapState } from 'vuex'; import { GlButton } from '@gitlab/ui'; import NoteableNote from '~/notes/components/noteable_note.vue'; -import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import PublishButton from './publish_button.vue'; export default { @@ -12,7 +11,6 @@ export default { PublishButton, GlButton, }, - mixins: [glFeatureFlagsMixin()], props: { draft: { type: Object, @@ -63,14 +61,14 @@ export default { this.isEditingDraft = false; }, handleMouseEnter(draft) { - if (this.glFeatures.multilineComments && draft.position) { + if (draft.position) { this.setSelectedCommentPositionHover(draft.position.line_range); } }, handleMouseLeave(draft) { - // Even though position isn't used here we still don't want to unecessarily call a mutation + // Even though position isn't used here we still don't want to unnecessarily call a mutation // The lack of position tells us that highlighting is irrelevant in this context - if (this.glFeatures.multilineComments && draft.position) { + if (draft.position) { this.setSelectedCommentPositionHover(); } }, diff --git a/app/assets/javascripts/batch_comments/components/preview_item.vue b/app/assets/javascripts/batch_comments/components/preview_item.vue index 589734df795..7f3892ae066 100644 --- a/app/assets/javascripts/batch_comments/components/preview_item.vue +++ b/app/assets/javascripts/batch_comments/components/preview_item.vue @@ -3,7 +3,6 @@ import { mapGetters } from 'vuex'; import { GlSprintf, GlIcon } from '@gitlab/ui'; import { IMAGE_DIFF_POSITION_TYPE } from '~/diffs/constants'; import { sprintf, __ } from '~/locale'; -import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import { getStartLineNumber, getEndLineNumber, @@ -16,7 +15,7 @@ export default { GlIcon, GlSprintf, }, - mixins: [resolvedStatusMixin, glFeatureFlagsMixin()], + mixins: [resolvedStatusMixin], props: { draft: { type: Object, @@ -71,6 +70,10 @@ export default { return this.draft.position || this.discussion.position; }, startLineNumber() { + if (this.position?.position_type === IMAGE_DIFF_POSITION_TYPE) { + // eslint-disable-next-line @gitlab/require-i18n-strings + return `${this.position.x}x ${this.position.y}y`; + } return getStartLineNumber(this.position?.line_range); }, endLineNumber() { @@ -90,16 +93,12 @@ export default { - + {{ titleText }}