From cee230a158e72a973150a17034b58c869f7e9407 Mon Sep 17 00:00:00 2001
From: Riyad Preukschas <riyad@informatik.uni-bremen.de>
Date: Fri, 14 Sep 2012 01:32:55 +0200
Subject: [PATCH] Update JS for adding and removing diff line notes

---
 app/assets/javascripts/note.js       | 37 +++++++++++++++++++++++++---
 app/views/notes/_create_line.js.haml | 19 +++++++++++---
 2 files changed, 48 insertions(+), 8 deletions(-)

diff --git a/app/assets/javascripts/note.js b/app/assets/javascripts/note.js
index ccc84ac9e65..7cbf44b98bf 100644
--- a/app/assets/javascripts/note.js
+++ b/app/assets/javascripts/note.js
@@ -17,8 +17,9 @@ var NoteList = {
       // get initial set of notes
       this.getContent();
 
-      $('.delete-note').live('ajax:success', function() {
-        $(this).closest('li').fadeOut(); });
+      $("#notes-list, #new-notes-list").on("ajax:success", ".delete-note", function() {
+        $(this).closest('li').fadeOut();
+      });
 
       $(".note-form-holder").on("ajax:before", function(){
         $(".submit_note").disable()
@@ -197,13 +198,41 @@ var NoteList = {
 var PerLineNotes = {
   init:
     function() {
-      $(".line_note_link, .line_note_reply_link").on("click", function(e) {
+      /**
+       * Called when clicking on the "add note" or "reply" button for a diff line.
+       *
+       * Shows the note form below the line.
+       * Sets some hidden fields in the form.
+       */
+      $(".diff_file_content").on("click", ".line_note_link, .line_note_reply_link", function(e) {
         var form = $(".per_line_form");
         $(this).closest("tr").after(form);
-        form.find("#note_line_code").val($(this).attr("line_code"));
+        form.find("#note_line_code").val($(this).data("lineCode"));
         form.show();
         return false;
       });
+
       disableButtonIfEmptyField(".line-note-text", ".submit_inline_note");
+
+      /**
+       * Called in response to successfully deleting a note on a diff line.
+       *
+       * Removes the actual note from view.
+       * Removes the reply button if the last note for that line has been removed.
+       */
+      $(".diff_file_content").on("ajax:success", ".delete-note", function() {
+        var trNote = $(this).closest("tr");
+        trNote.fadeOut(function() {
+          $(this).remove();
+        });
+
+        // check if this is the last note for this line
+        // elements must really be removed for this to work reliably
+        var trLine = trNote.prev();
+        var trRpl  = trNote.next();
+        if (trLine.hasClass("line_holder") && trRpl.hasClass("reply")) {
+          trRpl.fadeOut(function() { $(this).remove(); });
+        }
+      });
     }
 }
diff --git a/app/views/notes/_create_line.js.haml b/app/views/notes/_create_line.js.haml
index 662909f7967..ab862b2fea2 100644
--- a/app/views/notes/_create_line.js.haml
+++ b/app/views/notes/_create_line.js.haml
@@ -1,8 +1,19 @@
 - if note.valid?
   :plain
+    // hide and reset the form
     $(".per_line_form").hide();
     $('.line-note-form-holder textarea').val("");
-    $("a.line_note_reply_link[line_code='#{note.line_code}']").closest("tr").remove();
-    var trEl = $(".#{note.line_code}").parent();
-    trEl.after("#{escape_javascript(render partial: "notes/per_line_show", locals: {note: note})}");
-    trEl.after("#{escape_javascript(render partial: "notes/reply_button", locals: {line_code: note.line_code})}");
+
+    // find the reply button for this line
+    // (might not be there if this is the first note)
+    var trRpl = $("a.line_note_reply_link[data-line-code='#{note.line_code}']").closest("tr");
+    if (trRpl.size() == 0) {
+      // find the commented line ...
+      var trEl = $(".#{note.line_code}").parent();
+      // ... and insert the note and the reply button after it
+      trEl.after("#{escape_javascript(render "notes/reply_button", line_code: note.line_code)}");
+      trEl.after("#{escape_javascript(render "notes/per_line_show", note: note)}");
+    } else {
+      // instert new note before reply button
+      trRpl.before("#{escape_javascript(render "notes/per_line_show", note: note)}");
+    }