added bang option to spec
This commit is contained in:
parent
11044ab1a0
commit
cf6286313d
1 changed files with 30 additions and 0 deletions
|
@ -7,6 +7,7 @@ describe Users::UpdateService, services: true do
|
||||||
describe '#execute' do
|
describe '#execute' do
|
||||||
it 'updates the name' do
|
it 'updates the name' do
|
||||||
result = update_user(user, user, name: 'New Name')
|
result = update_user(user, user, name: 'New Name')
|
||||||
|
|
||||||
expect(result).to eq({ status: :success })
|
expect(result).to eq({ status: :success })
|
||||||
expect(user.name).to eq('New Name')
|
expect(user.name).to eq('New Name')
|
||||||
end
|
end
|
||||||
|
@ -14,6 +15,7 @@ describe Users::UpdateService, services: true do
|
||||||
context 'when updated by an admin' do
|
context 'when updated by an admin' do
|
||||||
it 'updates the name' do
|
it 'updates the name' do
|
||||||
result = update_user(admin, user, name: 'New Name')
|
result = update_user(admin, user, name: 'New Name')
|
||||||
|
|
||||||
expect(result).to eq({ status: :success })
|
expect(result).to eq({ status: :success })
|
||||||
expect(user.name).to eq('New Name')
|
expect(user.name).to eq('New Name')
|
||||||
end
|
end
|
||||||
|
@ -29,4 +31,32 @@ describe Users::UpdateService, services: true do
|
||||||
described_class.new(current_user, user, opts).execute
|
described_class.new(current_user, user, opts).execute
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
describe '#execute!' do
|
||||||
|
it 'updates the name' do
|
||||||
|
result = update_user(user, user, name: 'New Name')
|
||||||
|
|
||||||
|
expect(result).to be true
|
||||||
|
expect(user.name).to eq('New Name')
|
||||||
|
end
|
||||||
|
|
||||||
|
context 'when updated by an admin' do
|
||||||
|
it 'updates the name' do
|
||||||
|
result = update_user(admin, user, name: 'New Name')
|
||||||
|
|
||||||
|
expect(result).to be true
|
||||||
|
expect(user.name).to eq('New Name')
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
it 'returns an error result when record cannot be updated' do
|
||||||
|
expect do
|
||||||
|
update_user(user, create(:user), { name: 'New Name' })
|
||||||
|
end.to raise_error Gitlab::Access::AccessDeniedError
|
||||||
|
end
|
||||||
|
|
||||||
|
def update_user(current_user, user, opts)
|
||||||
|
described_class.new(current_user, user, opts).execute!
|
||||||
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in a new issue