kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Use shared_example rather than methods, feedback:

Browse source 
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5347#note_13173653
This commit is contained in:
Lin Jen-Shin 2016-07-20 17:30:34 +08:00
parent 709e805d65
commit cf78c35701
1 changed files with 12 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
spec/requests/api/builds_spec.rb
View file

@ -217,14 +217,15 @@ describe API::API, api: true do
fixture_file_upload(Rails.root + 'spec/fixtures/dk.png', 'image/gif')
end
def verify
download_headers =
{ 'Content-Transfer-Encoding' => 'binary',
'Content-Disposition' =>
"attachment; filename=#{build.artifacts_file.filename}" }
let(:download_headers) do
{ 'Content-Transfer-Encoding' => 'binary',
'Content-Disposition' =>
"attachment; filename=#{build.artifacts_file.filename}" }
end
expect(response).to have_http_status(200)
expect(response.headers).to include(download_headers)
shared_examples 'a valid file' do
it { expect(response).to have_http_status(200) }
it { expect(response.headers).to include(download_headers) }
end
context 'with regular branch' do
@ -237,7 +238,7 @@ describe API::API, api: true do
get path_for_ref('master')
end
it('gives the file') { verify }
it_behaves_like 'a valid file'
end
context 'with branch name containing slash' do
@ -250,7 +251,7 @@ describe API::API, api: true do
get path_for_ref('improve/awesome')
end
it('gives the file') { verify }
it_behaves_like 'a valid file'
end
context 'with latest pipeline' do
@ -269,7 +270,7 @@ describe API::API, api: true do
get path_for_ref
end
it('gives the file') { verify }
it_behaves_like 'a valid file'
end
context 'with success pipeline' do
@ -285,7 +286,7 @@ describe API::API, api: true do
get path_for_ref
end
it('gives the file') { verify }
it_behaves_like 'a valid file'
end
end
end