kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Stop new merge request page tabs updating the URL

Browse source 
The tabs on the merge_requests#new where changing the URL to URLs meant
for merge_requests#show. The URL don't actually exist on the new page,
so the simplest solution is to not update the URL for this page.

Closes #30419
This commit is contained in:
Phil Hughes 2017-04-05 10:42:31 +01:00
parent d4d95ad32f
commit d0821ae667
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/views/projects/merge_requests/_new_submit.html.haml
View file

@ -53,5 +53,6 @@
:javascript :javascript
var merge_request = new MergeRequest({ var merge_request = new MergeRequest({
action: "#{(@show_changes_tab ? 'new/diffs' : 'new')}" action: "#{(@show_changes_tab ? 'new/diffs' : 'new')}",
setUrl: false,
}); });

4
changelogs/unreleased/mr-new-page-changing-url.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: Fixed tabs on new merge request page causing incorrect URLs
merge_request:
author: