Merge branch 'fix-shibboleth-auth-with-no-uid' into 'master'

fix shibboleth misconfigurations resulting in authentication bypass

This merge request fixes #22267 where a misconfigured Shibboleth `HTTP_UID` or `HTTP_EPPN` could result in users being logged into an account that did not belong to them.

See merge request !7428
This commit is contained in:
Rémy Coutable 2016-11-16 17:28:56 +00:00
commit d1afb845b1
2 changed files with 8 additions and 0 deletions

View file

@ -0,0 +1,4 @@
---
title: fix shibboleth misconfigurations resulting in authentication bypass
merge_request: 7428
author:

View file

@ -241,6 +241,10 @@ Devise.setup do |config|
end
end
if provider['name'] == 'shibboleth'
provider['args'][:fail_with_empty_uid] = true
end
# A Hash from the configuration will be passed as is.
provider_arguments << provider['args'].symbolize_keys
end