From d237ada361f68864b2f46af58a097dcbde844675 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Wed, 12 Jan 2022 00:16:35 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .gitlab/ci/rails.gitlab-ci.yml | 4 +- CHANGELOG.md | 12 + GITALY_SERVER_VERSION | 2 +- app/assets/javascripts/behaviors/gl_emoji.js | 6 +- app/assets/javascripts/emoji/index.js | 15 +- .../components/header/validation_segment.vue | 5 +- .../components/pipeline_editor_tabs.vue | 1 + .../pipeline_graph/pipeline_graph.vue | 7 +- .../concerns/sessionless_authentication.rb | 2 +- app/controllers/import/github_controller.rb | 21 +- app/graphql/resolvers/base_issues_resolver.rb | 2 +- .../integrations/slack_mattermost_notifier.rb | 7 + .../chat_message/alert_message.rb | 4 +- .../integrations/chat_message/base_message.rb | 20 +- .../chat_message/deployment_message.rb | 6 +- .../chat_message/issue_message.rb | 6 +- .../chat_message/merge_message.rb | 8 +- .../integrations/chat_message/note_message.rb | 6 +- .../chat_message/pipeline_message.rb | 18 +- .../integrations/chat_message/push_message.rb | 10 +- .../chat_message/wiki_page_message.rb | 6 +- .../archive_extraction_service.rb | 74 ++++ .../packages/npm/create_package_service.rb | 18 +- doc/administration/configure.md | 2 +- .../monitoring/prometheus/gitlab_metrics.md | 2 +- .../package_information/deprecation_policy.md | 2 +- .../package_information/index.md | 2 +- .../reference_architectures/10k_users.md | 2 +- .../reference_architectures/3k_users.md | 2 +- .../reference_architectures/50k_users.md | 2 +- .../reference_architectures/5k_users.md | 2 +- doc/administration/troubleshooting/sidekiq.md | 2 +- doc/ci/docker/using_docker_build.md | 336 +++++++++--------- doc/ci/docker/using_kaniko.md | 2 +- doc/install/aws/gitlab_hybrid_on_aws.md | 6 +- doc/user/application_security/sast/index.md | 6 + doc/user/packages/container_registry/index.md | 19 +- .../browser_performance_testing.md | 2 +- .../project/merge_requests/code_quality.md | 4 +- .../load_performance_testing.md | 2 +- lib/api/projects.rb | 1 + .../common/pipelines/uploads_pipeline.rb | 39 +- lib/gitlab/import_export/command_line_util.rb | 4 + lib/gitlab/legacy_github_import/client.rb | 5 +- lib/gitlab/url_blocker.rb | 4 +- qa/qa/page/project/pipeline_editor/show.rb | 53 +++ .../pipeline/pipeline_editor_lint_spec.rb | 95 +++++ scripts/undercoverage | 2 +- .../dashboard/projects_controller_spec.rb | 4 - spec/controllers/dashboard_controller_spec.rb | 3 - spec/controllers/groups_controller_spec.rb | 20 -- .../import/github_controller_spec.rb | 57 ++- .../projects/commits_controller_spec.rb | 23 -- .../projects/issues_controller_spec.rb | 36 -- .../projects/raw_controller_spec.rb | 58 ++- .../projects/repositories_controller_spec.rb | 48 +++ .../projects/tags_controller_spec.rb | 22 -- spec/controllers/projects_controller_spec.rb | 22 -- spec/fixtures/symlink_export.tar | Bin 0 -> 10240 bytes spec/frontend/behaviors/gl_emoji_spec.js | 12 + .../graphql/resolvers/issues_resolver_spec.rb | 6 +- ...le_subscription_adapter_identifier_spec.rb | 6 + .../common/pipelines/uploads_pipeline_spec.rb | 24 +- .../import_export/command_line_util_spec.rb | 35 ++ spec/lib/gitlab/url_blocker_spec.rb | 56 ++- .../chat_message/alert_message_spec.rb | 2 + .../chat_message/base_message_spec.rb | 18 + .../chat_message/deployment_message_spec.rb | 90 ++--- .../chat_message/issue_message_spec.rb | 2 + .../chat_message/merge_message_spec.rb | 2 + .../chat_message/note_message_spec.rb | 15 +- .../chat_message/pipeline_message_spec.rb | 2 + .../chat_message/push_message_spec.rb | 2 + .../chat_message/wiki_page_message_spec.rb | 2 + spec/requests/api/graphql_spec.rb | 28 +- spec/requests/api/projects_spec.rb | 23 ++ .../dashboard/projects_controller_spec.rb | 11 + spec/requests/dashboard_controller_spec.rb | 15 + spec/requests/groups_controller_spec.rb | 51 +++ .../projects/commits_controller_spec.rb | 27 ++ .../projects/issues_controller_spec.rb | 42 ++- .../merge_requests_controller_spec.rb | 27 ++ .../requests/projects/tags_controller_spec.rb | 27 ++ spec/requests/projects_controller_spec.rb | 27 ++ spec/requests/users_controller_spec.rb | 6 +- .../archive_extraction_service_spec.rb | 60 ++++ .../npm/create_package_service_spec.rb | 54 ++- ...ionless_auth_controller_shared_examples.rb | 112 ------ .../chat_message_shared_examples.rb | 56 +++ ...essionless_auth_request_shared_examples.rb | 164 ++++++--- 90 files changed, 1513 insertions(+), 642 deletions(-) create mode 100644 app/services/bulk_imports/archive_extraction_service.rb create mode 100644 qa/qa/specs/features/browser_ui/4_verify/pipeline/pipeline_editor_lint_spec.rb create mode 100644 spec/fixtures/symlink_export.tar create mode 100644 spec/requests/dashboard/projects_controller_spec.rb create mode 100644 spec/requests/dashboard_controller_spec.rb create mode 100644 spec/requests/groups_controller_spec.rb create mode 100644 spec/requests/projects/commits_controller_spec.rb create mode 100644 spec/requests/projects/merge_requests_controller_spec.rb create mode 100644 spec/requests/projects/tags_controller_spec.rb create mode 100644 spec/requests/projects_controller_spec.rb create mode 100644 spec/services/bulk_imports/archive_extraction_service_spec.rb delete mode 100644 spec/support/shared_examples/controllers/sessionless_auth_controller_shared_examples.rb create mode 100644 spec/support/shared_examples/models/integrations/chat_message_shared_examples.rb diff --git a/.gitlab/ci/rails.gitlab-ci.yml b/.gitlab/ci/rails.gitlab-ci.yml index 89e9d3bc8b6..5ba4d08e317 100644 --- a/.gitlab/ci/rails.gitlab-ci.yml +++ b/.gitlab/ci/rails.gitlab-ci.yml @@ -598,8 +598,10 @@ rspec:undercoverage: else echo "Using \$CI_COMMIT_SHA ($CI_COMMIT_SHA) for this non-merge result pipeline."; fi; + - UNDERCOVERAGE_COMPARE="${CI_MERGE_REQUEST_DIFF_BASE_SHA:-$(git merge-base origin/master HEAD)}" + - echo "Undercoverage comparing with ${UNDERCOVERAGE_COMPARE}" - if [ -f scripts/undercoverage ]; then - run_timed_command "scripts/undercoverage"; + run_timed_command "scripts/undercoverage ${UNDERCOVERAGE_COMPARE}"; fi; rspec:feature-flags: diff --git a/CHANGELOG.md b/CHANGELOG.md index 7f94a6ed393..f5d48b4ceb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ documentation](doc/development/changelog.md) for instructions on adding your own entry. +## 14.6.2 (2022-01-10) + +No changes. + ## 14.6.1 (2022-01-04) ### Fixed (2 changes) @@ -387,6 +391,10 @@ entry. - [Fix OpenStruct use](gitlab-org/gitlab@f8466f5943a1afeabaf9cf781f7804a8df515a0e) by @mehulsharma ([merge request](gitlab-org/gitlab!74702)) - [Update Sidekiq to 6.3.1](gitlab-org/gitlab@22e8bc0af656717e56428a7227c467fe08021c66) ([merge request](gitlab-org/gitlab!73973)) +## 14.5.3 (2022-01-11) + +No changes. + ## 14.5.2 (2021-12-03) No changes. @@ -929,6 +937,10 @@ No changes. - [Add pipeline artifacts and uploads sizes to project REST API](gitlab-org/gitlab@58d66f28faf42ae98ca11ff1ba0bdd9180e988ad) by @guillaume.chauvel ([merge request](gitlab-org/gitlab!72075)) - [Remove not used parameter from epics finder](gitlab-org/gitlab@49fce172b57b2f376a114726b1dd1900fe36a238) ([merge request](gitlab-org/gitlab!72285)) **GitLab Enterprise Edition** +## 14.4.5 (2022-01-11) + +No changes. + ## 14.4.4 (2021-12-03) No changes. diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index d8dda2e23cc..62d572c550a 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -3627c14a64ce48446e8a67299c3161ff7290d1ad +e02b0d67e48ed5a4493b073c9836d376a780f34d diff --git a/app/assets/javascripts/behaviors/gl_emoji.js b/app/assets/javascripts/behaviors/gl_emoji.js index 8fe90b6bb15..8fd03d3132d 100644 --- a/app/assets/javascripts/behaviors/gl_emoji.js +++ b/app/assets/javascripts/behaviors/gl_emoji.js @@ -64,10 +64,12 @@ class GlEmoji extends HTMLElement { this.classList.add('emoji-icon'); this.classList.add(fallbackSpriteClass); } else if (hasImageFallback) { - this.innerHTML = emojiImageTag(name, fallbackSrc); + this.innerHTML = ''; + this.appendChild(emojiImageTag(name, fallbackSrc)); } else { const src = emojiFallbackImageSrc(name); - this.innerHTML = emojiImageTag(name, src); + this.innerHTML = ''; + this.appendChild(emojiImageTag(name, src)); } } }); diff --git a/app/assets/javascripts/emoji/index.js b/app/assets/javascripts/emoji/index.js index b507792cc91..aaae1624bee 100644 --- a/app/assets/javascripts/emoji/index.js +++ b/app/assets/javascripts/emoji/index.js @@ -1,6 +1,7 @@ import { escape, minBy } from 'lodash'; import emojiRegexFactory from 'emoji-regex'; import emojiAliases from 'emojis/aliases.json'; +import { setAttributes } from '~/lib/utils/dom_utils'; import AccessorUtilities from '../lib/utils/accessor'; import axios from '../lib/utils/axios_utils'; import { CACHE_KEY, CACHE_VERSION_KEY, CATEGORY_ICON_MAP, FREQUENTLY_USED_KEY } from './constants'; @@ -220,7 +221,19 @@ export function emojiFallbackImageSrc(inputName) { } export function emojiImageTag(name, src) { - return `:${name}:`; + const img = document.createElement('img'); + + img.className = 'emoji'; + setAttributes(img, { + title: `:${name}:`, + alt: `:${name}:`, + src, + width: '20', + height: '20', + align: 'absmiddle', + }); + + return img; } export function glEmojiTag(inputName, options) { diff --git a/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue b/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue index 280ad2951a7..23f1592cac1 100644 --- a/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue +++ b/app/assets/javascripts/pipeline_editor/components/header/validation_segment.vue @@ -111,7 +111,10 @@ export default { - {{ message }} + + + {{ message }} + diff --git a/app/assets/javascripts/pipeline_editor/components/pipeline_editor_tabs.vue b/app/assets/javascripts/pipeline_editor/components/pipeline_editor_tabs.vue index a418668933b..c75b1d4bb11 100644 --- a/app/assets/javascripts/pipeline_editor/components/pipeline_editor_tabs.vue +++ b/app/assets/javascripts/pipeline_editor/components/pipeline_editor_tabs.vue @@ -146,6 +146,7 @@ export default {