Fix tests for Drop filename enforcement
This commit is contained in:
parent
8bf9438150
commit
d30e71b381
|
@ -19,7 +19,7 @@ describe Ci::CreateTraceArtifactService do
|
|||
it 'creates trace artifact' do
|
||||
expect { subject }.to change { Ci::JobArtifact.count }.by(1)
|
||||
|
||||
expect(job.job_artifacts_trace.read_attribute(:file)).to eq('trace.log')
|
||||
expect(job.job_artifacts_trace.read_attribute(:file)).to eq('sample_trace')
|
||||
end
|
||||
|
||||
context 'when the job has already had trace artifact' do
|
||||
|
|
|
@ -38,22 +38,6 @@ describe JobArtifactUploader do
|
|||
end
|
||||
end
|
||||
|
||||
describe '#filename' do
|
||||
subject { uploader.filename }
|
||||
|
||||
context 'when artifact file_type is archive' do
|
||||
let(:job_artifact) { create(:ci_job_artifact, :archive) }
|
||||
|
||||
it { is_expected.to be_nil }
|
||||
end
|
||||
|
||||
context 'when artifact file_type is trace' do
|
||||
let(:job_artifact) { create(:ci_job_artifact, :trace) }
|
||||
|
||||
it { is_expected.to eq('trace.log') }
|
||||
end
|
||||
end
|
||||
|
||||
context 'file is stored in valid local_path' do
|
||||
let(:file) do
|
||||
fixture_file_upload(
|
||||
|
|
Loading…
Reference in New Issue