From d3655fe56f42e7d1821d783b274154a6f69c59c5 Mon Sep 17 00:00:00 2001 From: "Luke \"Jared\" Bennett" Date: Wed, 24 May 2017 08:47:25 +0000 Subject: [PATCH] Add review comments to compare_spec.rb --- spec/features/projects/compare_spec.rb | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spec/features/projects/compare_spec.rb b/spec/features/projects/compare_spec.rb index a8e00d434e8..4162f2579d1 100644 --- a/spec/features/projects/compare_spec.rb +++ b/spec/features/projects/compare_spec.rb @@ -52,9 +52,11 @@ describe "Compare", js: true do def select_using_dropdown(dropdown_type, selection) dropdown = find(".js-compare-#{dropdown_type}-dropdown") dropdown.find(".compare-dropdown-toggle").click + # find input before using to wait for the inputs visiblity dropdown.find('.dropdown-menu') dropdown.fill_in("Filter by Git revision", with: selection) wait_for_requests + # find before all to wait for the items visiblity dropdown.find("a[data-ref=\"#{selection}\"]", match: :first) dropdown.all("a[data-ref=\"#{selection}\"]").last.click end