Don't execute hooks if ci was supposed to be skipped

And we should preserve the return value
2016-07-29 17:06:09 +08:00 · 2016-07-29 17:06:09 +08:00 · d41e83e91a
parent b831ef716b
commit d41e83e91a
1 changed files with 3 additions and 2 deletions
--- a/app/models/ci/pipeline.rb
+++ b/app/models/ci/pipeline.rb
@ -237,8 +237,9 @@ module Ci
      self.started_at = statuses.started_at
      self.finished_at = statuses.finished_at
      self.duration = statuses.latest.duration
-      save
-      execute_hooks
+      saved = save
+      execute_hooks if saved && !skip_ci?
+      saved
    end

    def execute_hooks