formatting and test structure

This commit is contained in:
Sebastian Klier 2016-04-05 14:05:35 +08:00
parent a88f0a1fd8
commit d472810e49
3 changed files with 45 additions and 28 deletions

View file

@ -19,7 +19,7 @@ class SlackService
@wiki_page_url = obj_attr[:url]
@description = obj_attr[:content]
@action = \
@action =
case obj_attr[:action]
when "create"
"created"

View file

@ -1,5 +1,5 @@
class AddEventToServices < ActiveRecord::Migration
def change
add_column :services, :wiki_page_events, :boolean, :default => true
add_column :services, :wiki_page_events, :boolean, default: true
end
end

View file

@ -11,11 +11,9 @@ describe SlackService::WikiPageMessage, models: true do
},
project_name: 'project_name',
project_url: 'somewhere.com',
object_attributes: {
title: 'Wiki page title',
url: 'url',
action: 'create',
content: 'Wiki page description'
}
}
@ -23,12 +21,34 @@ describe SlackService::WikiPageMessage, models: true do
let(:color) { '#345' }
context 'create' do
it 'returns a message regarding creation of pages' do
expect(subject.pretext).to eq(
describe '#pretext' do
context 'when :action == "create"' do
before { args[:object_attributes][:action] = 'create' }
it do
expect(pretext).to eq(
'Test User created <url|wiki page> in <somewhere.com|project_name>: '\
'*Wiki page title*')
expect(subject.attachments).to eq([
end
end
context 'when :action == "update"' do
before { args[:object_attributes][:action] = 'update' }
it do
expect(pretext).to eq(
'Test User edited <url|wiki page> in <somewhere.com|project_name>: '\
'*Wiki page title*')
end
end
end
describe '#attachments' do
context 'when :action == "create"' do
before { args[:object_attributes][:action] = 'create' }
it do
expect(attachments).to eq([
{
text: "Wiki page description",
color: color,
@ -37,15 +57,11 @@ describe SlackService::WikiPageMessage, models: true do
end
end
context 'update' do
before do
args[:object_attributes][:action] = 'update'
end
it 'returns a message regarding updating of pages' do
expect(subject.pretext). to eq(
'Test User edited <url|wiki page> in <somewhere.com|project_name>: '\
'*Wiki page title*')
expect(subject.attachments).to eq([
context 'when :action == "update"' do
before { args[:object_attributes][:action] = 'update' }
it do
expect(attachments).to eq([
{
text: "Wiki page description",
color: color,
@ -53,4 +69,5 @@ describe SlackService::WikiPageMessage, models: true do
])
end
end
end
end