Fix creating group with space in group path
This commit is contained in:
parent
c49517a004
commit
d54a281e3d
2 changed files with 17 additions and 5 deletions
|
@ -44,7 +44,7 @@
|
||||||
name: "#{j(@project.name)}"
|
name: "#{j(@project.name)}"
|
||||||
};
|
};
|
||||||
|
|
||||||
- if @group and @group.path
|
- if @group && @group.persisted? && @group.path
|
||||||
:javascript
|
:javascript
|
||||||
gl.groupOptions = gl.groupOptions || {};
|
gl.groupOptions = gl.groupOptions || {};
|
||||||
gl.groupOptions["#{j(@group.path)}"] = {
|
gl.groupOptions["#{j(@group.path)}"] = {
|
||||||
|
|
|
@ -1,14 +1,26 @@
|
||||||
require 'spec_helper'
|
require 'spec_helper'
|
||||||
|
|
||||||
feature 'Group', feature: true do
|
feature 'Group', feature: true do
|
||||||
describe 'description' do
|
|
||||||
let(:group) { create(:group) }
|
|
||||||
let(:path) { group_path(group) }
|
|
||||||
|
|
||||||
before do
|
before do
|
||||||
login_as(:admin)
|
login_as(:admin)
|
||||||
end
|
end
|
||||||
|
|
||||||
|
describe 'creating a group with space in group path' do
|
||||||
|
it 'renders new group form with validation errors' do
|
||||||
|
visit new_group_path
|
||||||
|
fill_in 'Group path', with: 'space group'
|
||||||
|
|
||||||
|
click_button 'Create group'
|
||||||
|
|
||||||
|
expect(current_path).to eq(groups_path)
|
||||||
|
expect(page).to have_content("Path can contain only letters, digits, '_', '-' and '.'. Cannot start with '-' or end in '.'.")
|
||||||
|
end
|
||||||
|
end
|
||||||
|
|
||||||
|
describe 'description' do
|
||||||
|
let(:group) { create(:group) }
|
||||||
|
let(:path) { group_path(group) }
|
||||||
|
|
||||||
it 'parses Markdown' do
|
it 'parses Markdown' do
|
||||||
group.update_attribute(:description, 'This is **my** group')
|
group.update_attribute(:description, 'This is **my** group')
|
||||||
visit path
|
visit path
|
||||||
|
|
Loading…
Reference in a new issue