Enable reply_to_individual_notes feature flag by default

This commit is contained in:
Winnie Hellmann 2019-02-26 22:14:03 +01:00
parent c9e5ce8dbd
commit d5aa36f1e0
4 changed files with 9 additions and 5 deletions

View File

@ -8,7 +8,7 @@ module IssuableActions
before_action :authorize_destroy_issuable!, only: :destroy
before_action :authorize_admin_issuable!, only: :bulk_update
before_action only: :show do
push_frontend_feature_flag(:reply_to_individual_notes)
push_frontend_feature_flag(:reply_to_individual_notes, default_enabled: true)
end
end

View File

@ -14,7 +14,7 @@ class IndividualNoteDiscussion < Discussion
end
def can_convert_to_discussion?
noteable.supports_replying_to_individual_notes? && Feature.enabled?(:reply_to_individual_notes)
noteable.supports_replying_to_individual_notes? && Feature.enabled?(:reply_to_individual_notes, default_enabled: true)
end
def convert_to_discussion!(save: false)

View File

@ -0,0 +1,5 @@
---
title: Add button to start discussion from single comment
merge_request: 25575
author:
type: added

View File

@ -67,7 +67,7 @@ describe 'Merge request > User posts notes', :js do
end
end
describe 'when reply_to_individual_notes feature flag is not set' do
describe 'when reply_to_individual_notes feature flag is disabled' do
before do
stub_feature_flags(reply_to_individual_notes: false)
visit project_merge_request_path(project, merge_request)
@ -78,9 +78,8 @@ describe 'Merge request > User posts notes', :js do
end
end
describe 'when reply_to_individual_notes feature flag is set' do
describe 'when reply_to_individual_notes feature flag is not set' do
before do
stub_feature_flags(reply_to_individual_notes: true)
visit project_merge_request_path(project, merge_request)
end