kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

hide the version check image if internet connection is broken

Browse source
This commit is contained in:
Ken Ding 2017-01-20 00:59:11 +10:30
parent 8c0e358a97
commit d5f34b3771
4 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
app/assets/javascripts/dispatcher.js.es6
View file

@ -261,6 +261,9 @@
case 'projects:artifacts:browse':
new BuildArtifacts();
break;
case 'help:index':
gl.VersionCheckImage.bindErrorEvent($('img.js-version-status-badge'));
break;
case 'search:show':
new Search();
break;

10
app/assets/javascripts/version_check_image.js.es6 Normal file
View file

@ -0,0 +1,10 @@
(() => {
class VersionCheckImage {
static bindErrorEvent(imageElement) {
imageElement.off('error').on('error', () => imageElement.hide());
}
}
window.gl = window.gl || {};
gl.VersionCheckImage = VersionCheckImage;
})();

3
app/helpers/version_check_helper.rb
View file

@ -1,7 +1,8 @@
module VersionCheckHelper
def version_status_badge
if Rails.env.production? && current_application_settings.version_check_enabled
image_tag VersionCheck.new.url
image_url = VersionCheck.new.url
image_tag image_url, class: 'js-version-status-badge'
end
end
end

4
changelogs/unreleased/broken_iamge_when_doing_offline_update_check-help_page-.yml Normal file
View file

@ -0,0 +1,4 @@
---
title: Hide version check image if there is no internet connection
merge_request: 8355
author: Ken Ding