Extract and memoize `user_access`

Because it is sometimes never used.
This commit is contained in:
Michael Kozono 2017-05-23 12:26:46 -07:00
parent 0e3cfc75a3
commit d7eee7332b
1 changed files with 9 additions and 6 deletions

View File

@ -22,18 +22,13 @@ module Gitlab
PUSH_COMMANDS = %w{ git-receive-pack }.freeze
ALL_COMMANDS = DOWNLOAD_COMMANDS + PUSH_COMMANDS
attr_reader :actor, :project, :protocol, :user_access, :authentication_abilities
attr_reader :actor, :project, :protocol, :authentication_abilities
def initialize(actor, project, protocol, authentication_abilities:)
@actor = actor
@project = project
@protocol = protocol
@authentication_abilities = authentication_abilities
@user_access = if ci?
CiAccess.new
else
UserAccess.new(user, project: project)
end
end
def check(cmd, changes)
@ -244,5 +239,13 @@ module Gitlab
nil
end
end
def user_access
@user_access ||= if ci?
CiAccess.new
else
UserAccess.new(user, project: project)
end
end
end
end