Extract and memoize `user_access`
Because it is sometimes never used.
This commit is contained in:
parent
0e3cfc75a3
commit
d7eee7332b
|
@ -22,18 +22,13 @@ module Gitlab
|
||||||
PUSH_COMMANDS = %w{ git-receive-pack }.freeze
|
PUSH_COMMANDS = %w{ git-receive-pack }.freeze
|
||||||
ALL_COMMANDS = DOWNLOAD_COMMANDS + PUSH_COMMANDS
|
ALL_COMMANDS = DOWNLOAD_COMMANDS + PUSH_COMMANDS
|
||||||
|
|
||||||
attr_reader :actor, :project, :protocol, :user_access, :authentication_abilities
|
attr_reader :actor, :project, :protocol, :authentication_abilities
|
||||||
|
|
||||||
def initialize(actor, project, protocol, authentication_abilities:)
|
def initialize(actor, project, protocol, authentication_abilities:)
|
||||||
@actor = actor
|
@actor = actor
|
||||||
@project = project
|
@project = project
|
||||||
@protocol = protocol
|
@protocol = protocol
|
||||||
@authentication_abilities = authentication_abilities
|
@authentication_abilities = authentication_abilities
|
||||||
@user_access = if ci?
|
|
||||||
CiAccess.new
|
|
||||||
else
|
|
||||||
UserAccess.new(user, project: project)
|
|
||||||
end
|
|
||||||
end
|
end
|
||||||
|
|
||||||
def check(cmd, changes)
|
def check(cmd, changes)
|
||||||
|
@ -244,5 +239,13 @@ module Gitlab
|
||||||
nil
|
nil
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
def user_access
|
||||||
|
@user_access ||= if ci?
|
||||||
|
CiAccess.new
|
||||||
|
else
|
||||||
|
UserAccess.new(user, project: project)
|
||||||
|
end
|
||||||
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
Loading…
Reference in New Issue